c-ares

224 Commits

14 Branches

96 Tags

22 MiB

Tag: Branch: Tree: 69950390b2

Commit Graph

Author	SHA1	Message	Date
bradh352	f4c079d9d0	more portability updates	4 years ago
bradh352	498ce747d3	portability updates for test cases	4 years ago
Fionn Fitzmaurice	6d6cd5daf6	Avoid buffer overflow in RC4 loop comparison (#336 ) The rc4 function iterates over a buffer of size buffer_len who's maximum value is INT_MAX with a counter of type short that is not guaranteed to have maximum size INT_MAX. In circumstances where short is narrower than int and where buffer_len is larger than the maximum value of a short, it may be possible to loop infinitely as counter will overflow and never be greater than or equal to buffer_len. The solution is to make the comparison be between types of equal width. This commit defines counter as an int. Fix By: Fionn Fitzmaurice (@fionn)	4 years ago

Author

SHA1

Message

Date

bradh352

f4c079d9d0

more portability updates

4 years ago

bradh352

498ce747d3

portability updates for test cases

4 years ago

Fionn Fitzmaurice

6d6cd5daf6

Avoid buffer overflow in RC4 loop comparison (#336 )

The rc4 function iterates over a buffer of size buffer_len who's maximum
value is INT_MAX with a counter of type short that is not guaranteed to
have maximum size INT_MAX.

In circumstances where short is narrower than int and where buffer_len
is larger than the maximum value of a short, it may be possible to loop
infinitely as counter will overflow and never be greater than or equal
to buffer_len.

The solution is to make the comparison be between types of equal width.
This commit defines counter as an int.

Fix By: Fionn Fitzmaurice (@fionn)

4 years ago

3 Commits (69950390b2d8063b6540dc75941a30ea56d11918)