c-ares

82 Commits

14 Branches

96 Tags

22 MiB

Tag: Branch: Tree: 5ea4616d2c

Commit Graph

Author	SHA1	Message	Date
Felix Yan	9c4c483f06	Fix building when latest ax_code_coverage.m4 is imported (#418 ) ax_code_coverage.m4 dropped the @CODE_COVERAGE_RULES@ macro, so we need to switch to the latest recommendation from the m4 file. This requires updates to Makefile.am. Fix By: Felix Yan (@felixonmars)	3 years ago
Fionn Fitzmaurice	6d6cd5daf6	Avoid buffer overflow in RC4 loop comparison (#336 ) The rc4 function iterates over a buffer of size buffer_len who's maximum value is INT_MAX with a counter of type short that is not guaranteed to have maximum size INT_MAX. In circumstances where short is narrower than int and where buffer_len is larger than the maximum value of a short, it may be possible to loop infinitely as counter will overflow and never be greater than or equal to buffer_len. The solution is to make the comparison be between types of equal width. This commit defines counter as an int. Fix By: Fionn Fitzmaurice (@fionn)	4 years ago

Author

SHA1

Message

Date

Felix Yan

9c4c483f06

Fix building when latest ax_code_coverage.m4 is imported (#418 )

ax_code_coverage.m4 dropped the @CODE_COVERAGE_RULES@ macro, so we need to switch to the latest recommendation from the m4 file.  This requires updates to Makefile.am.

Fix By: Felix Yan (@felixonmars)

3 years ago

Fionn Fitzmaurice

6d6cd5daf6

Avoid buffer overflow in RC4 loop comparison (#336 )

The rc4 function iterates over a buffer of size buffer_len who's maximum
value is INT_MAX with a counter of type short that is not guaranteed to
have maximum size INT_MAX.

In circumstances where short is narrower than int and where buffer_len
is larger than the maximum value of a short, it may be possible to loop
infinitely as counter will overflow and never be greater than or equal
to buffer_len.

The solution is to make the comparison be between types of equal width.
This commit defines counter as an int.

Fix By: Fionn Fitzmaurice (@fionn)

4 years ago

2 Commits (5ea4616d2c3f0098b6f225bc15acceac0376da4b)