c-ares

135 Commits

14 Branches

97 Tags

23 MiB

Tag: Branch: Tree: 2aa086f822

Commit Graph

Author	SHA1	Message	Date
Daniel Bevenius	de042a65f4	add build to .gitignore (#410 ) This commit adds the build directory to be ignored by git. The motivation for adding this to .gitignore as opposed to .git/info/exclude is that the CMake example in INSTALL.md uses build as the name of the directory to be used by CMake. This will cause git to report build as an untracked file. Fix By: Daniel Bevenius (@danbev)	4 years ago
Fionn Fitzmaurice	6d6cd5daf6	Avoid buffer overflow in RC4 loop comparison (#336 ) The rc4 function iterates over a buffer of size buffer_len who's maximum value is INT_MAX with a counter of type short that is not guaranteed to have maximum size INT_MAX. In circumstances where short is narrower than int and where buffer_len is larger than the maximum value of a short, it may be possible to loop infinitely as counter will overflow and never be greater than or equal to buffer_len. The solution is to make the comparison be between types of equal width. This commit defines counter as an int. Fix By: Fionn Fitzmaurice (@fionn)	5 years ago

Author

SHA1

Message

Date

Daniel Bevenius

de042a65f4

add build to .gitignore (#410 )

This commit adds the build directory to be ignored by git.

The motivation for adding this to .gitignore as opposed to
.git/info/exclude is that the CMake example in INSTALL.md uses build
as the name of the directory to be used by CMake. This will cause
git to report build as an untracked file.

Fix By: Daniel Bevenius (@danbev)

4 years ago

Fionn Fitzmaurice

6d6cd5daf6

Avoid buffer overflow in RC4 loop comparison (#336 )

The rc4 function iterates over a buffer of size buffer_len who's maximum
value is INT_MAX with a counter of type short that is not guaranteed to
have maximum size INT_MAX.

In circumstances where short is narrower than int and where buffer_len
is larger than the maximum value of a short, it may be possible to loop
infinitely as counter will overflow and never be greater than or equal
to buffer_len.

The solution is to make the comparison be between types of equal width.
This commit defines counter as an int.

Fix By: Fionn Fitzmaurice (@fionn)

5 years ago

2 Commits (2aa086f822aad5017a6f2061ef656f237a62d0ed)