From de04975c4812e1ea1e914f9384fb35971575852c Mon Sep 17 00:00:00 2001 From: David Drysdale <drysdale@google.com> Date: Thu, 24 Dec 2015 13:42:43 +0000 Subject: [PATCH] ares_striendstr: fix so non-NULL return can happen This looks to have been broken since it was first introduced in 2005 in commit aba0b775ea30 ("Added ares_getnameinfo which mimics the getnameinfo API") --- ares_getnameinfo.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/ares_getnameinfo.c b/ares_getnameinfo.c index b0bc6da8..e74c7a0f 100644 --- a/ares_getnameinfo.c +++ b/ares_getnameinfo.c @@ -417,7 +417,5 @@ static char *ares_striendstr(const char *s1, const char *s2) c2++; } } - if (c2 == c1 && c2 == NULL) - return (char *)c1_begin; - return NULL; + return (char *)c1_begin; }