mirror of https://github.com/c-ares/c-ares.git
fix: potential `WIN32_LEAN_AND_MEAN` redefinition (#869)
For non-cmake/autotools builds WIN32_LEAN_AND_MEAN was being defined in ares_build.h.dist, this can cause conflicts with projects that import c-ares and already define this. The Node.js upgrade to c-ares v1.32.2, causes compilation failures like the following: ``` ../../third_party/electron_node/deps/cares/include\ares_build.h(168,11): err or: 'WIN32_LEAN_AND_MEAN' macro redefined [-Werror,-Wmacro-redefined] 168 | # define WIN32_LEAN_AND_MEAN | ^ <command line>(25,9): note: previous definition is here 25 | #define WIN32_LEAN_AND_MEAN 1 | ^ 1 error generated. [287 processes, 49437/51449 @ 48.5/s : 1018.562s] CC obj/third_party/electro n_node/deps/cares/cares/ares__socket.obj FAILED: obj/third_party/electron_node/deps/cares/cares/ares__socket.obj ``` Authored-By: Shelley Vohr (@codebytere)pull/870/head
parent
9e9bd1f516
commit
d2681a8f41
1 changed files with 0 additions and 1 deletions
Loading…
Reference in new issue