remove tests that depend on randomness

pull/600/head
Brad House 1 year ago
parent 4ec6b5ce4c
commit a116fede19
  1. 44
      test/ares-test-mock-ai.cc
  2. 43
      test/ares-test-mock.cc

@ -633,52 +633,11 @@ class MockMultiServerChannelTestAI
}
};
class RotateMultiMockTestAI : public MockMultiServerChannelTestAI {
public:
RotateMultiMockTestAI() : MockMultiServerChannelTestAI(true) {}
};
class NoRotateMultiMockTestAI : public MockMultiServerChannelTestAI {
public:
NoRotateMultiMockTestAI() : MockMultiServerChannelTestAI(false) {}
};
TEST_P(RotateMultiMockTestAI, ThirdServer) {
struct ares_options opts = {0};
int optmask = 0;
EXPECT_EQ(ARES_SUCCESS, ares_save_options(channel_, &opts, &optmask));
EXPECT_EQ(0, (optmask & ARES_OPT_NOROTATE));
ares_destroy_options(&opts);
DNSPacket servfailrsp;
servfailrsp.set_response().set_aa().set_rcode(SERVFAIL)
.add_question(new DNSQuestion("www.example.com", T_A));
DNSPacket notimplrsp;
notimplrsp.set_response().set_aa().set_rcode(NOTIMP)
.add_question(new DNSQuestion("www.example.com", T_A));
DNSPacket okrsp;
okrsp.set_response().set_aa()
.add_question(new DNSQuestion("www.example.com", T_A))
.add_answer(new DNSARR("www.example.com", 100, {2,3,4,5}));
ON_CALL(*servers_[0], OnRequest("www.example.com", T_A))
.WillByDefault(SetReply(servers_[0].get(), &notimplrsp));
ON_CALL(*servers_[1], OnRequest("www.example.com", T_A))
.WillByDefault(SetReply(servers_[1].get(), &okrsp));
ON_CALL(*servers_[2], OnRequest("www.example.com", T_A))
.WillByDefault(SetReply(servers_[2].get(), &okrsp));
CheckExample();
ON_CALL(*servers_[0], OnRequest("www.example.com", T_A))
.WillByDefault(SetReply(servers_[0].get(), &servfailrsp));
ON_CALL(*servers_[1], OnRequest("www.example.com", T_A))
.WillByDefault(SetReply(servers_[1].get(), &okrsp));
ON_CALL(*servers_[2], OnRequest("www.example.com", T_A))
.WillByDefault(SetReply(servers_[2].get(), &okrsp));
CheckExample();
}
TEST_P(NoRotateMultiMockTestAI, ThirdServer) {
struct ares_options opts = {0};
int optmask = 0;
@ -770,9 +729,6 @@ INSTANTIATE_TEST_SUITE_P(AddressFamiliesAI, MockNoCheckRespChannelTestAI,
INSTANTIATE_TEST_SUITE_P(AddressFamiliesAI, MockEDNSChannelTestAI,
::testing::ValuesIn(ares::test::families_modes));
INSTANTIATE_TEST_SUITE_P(TransportModesAI, RotateMultiMockTestAI,
::testing::ValuesIn(ares::test::families_modes));
INSTANTIATE_TEST_SUITE_P(TransportModesAI, NoRotateMultiMockTestAI,
::testing::ValuesIn(ares::test::families_modes));

@ -1215,52 +1215,11 @@ class MockMultiServerChannelTest
}
};
class RotateMultiMockTest : public MockMultiServerChannelTest {
public:
RotateMultiMockTest() : MockMultiServerChannelTest(true) {}
};
class NoRotateMultiMockTest : public MockMultiServerChannelTest {
public:
NoRotateMultiMockTest() : MockMultiServerChannelTest(false) {}
};
TEST_P(RotateMultiMockTest, ThirdServer) {
struct ares_options opts = {0};
int optmask = 0;
EXPECT_EQ(ARES_SUCCESS, ares_save_options(channel_, &opts, &optmask));
EXPECT_EQ(0, (optmask & ARES_OPT_NOROTATE));
ares_destroy_options(&opts);
DNSPacket servfailrsp;
servfailrsp.set_response().set_aa().set_rcode(SERVFAIL)
.add_question(new DNSQuestion("www.example.com", T_A));
DNSPacket notimplrsp;
notimplrsp.set_response().set_aa().set_rcode(NOTIMP)
.add_question(new DNSQuestion("www.example.com", T_A));
DNSPacket okrsp;
okrsp.set_response().set_aa()
.add_question(new DNSQuestion("www.example.com", T_A))
.add_answer(new DNSARR("www.example.com", 100, {2,3,4,5}));
ON_CALL(*servers_[0], OnRequest("www.example.com", T_A))
.WillByDefault(SetReply(servers_[0].get(), &notimplrsp));
ON_CALL(*servers_[1], OnRequest("www.example.com", T_A))
.WillByDefault(SetReply(servers_[1].get(), &okrsp));
ON_CALL(*servers_[2], OnRequest("www.example.com", T_A))
.WillByDefault(SetReply(servers_[2].get(), &okrsp));
CheckExample();
ON_CALL(*servers_[0], OnRequest("www.example.com", T_A))
.WillByDefault(SetReply(servers_[0].get(), &servfailrsp));
ON_CALL(*servers_[1], OnRequest("www.example.com", T_A))
.WillByDefault(SetReply(servers_[1].get(), &okrsp));
ON_CALL(*servers_[2], OnRequest("www.example.com", T_A))
.WillByDefault(SetReply(servers_[2].get(), &okrsp));
CheckExample();
}
TEST_P(NoRotateMultiMockTest, ThirdServer) {
struct ares_options opts = {0};
int optmask = 0;
@ -1325,8 +1284,6 @@ INSTANTIATE_TEST_SUITE_P(AddressFamilies, MockNoCheckRespChannelTest, ::testing:
INSTANTIATE_TEST_SUITE_P(AddressFamilies, MockEDNSChannelTest, ::testing::ValuesIn(ares::test::families_modes));
INSTANTIATE_TEST_SUITE_P(TransportModes, RotateMultiMockTest, ::testing::ValuesIn(ares::test::families_modes));
INSTANTIATE_TEST_SUITE_P(TransportModes, NoRotateMultiMockTest, ::testing::ValuesIn(ares::test::families_modes));
} // namespace test

Loading…
Cancel
Save