From 7e0378a42aa9e37887d68d87cdce87124a34a4b6 Mon Sep 17 00:00:00 2001 From: Daniel Stenberg Date: Tue, 16 Aug 2016 08:04:12 +0200 Subject: [PATCH] read_tcp_data: remove superfluous NULL check CID 56884 by Coverity. The pointer is already derefenced before this point so it can't be NULL here anyway. --- ares_process.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/ares_process.c b/ares_process.c index 0325f519..1d1e7b8b 100644 --- a/ares_process.c +++ b/ares_process.c @@ -391,8 +391,7 @@ static void read_tcp_data(ares_channel channel, fd_set *read_fds, */ process_answer(channel, server->tcp_buffer, server->tcp_length, i, 1, now); - if (server->tcp_buffer) - ares_free(server->tcp_buffer); + ares_free(server->tcp_buffer); server->tcp_buffer = NULL; server->tcp_lenbuf_pos = 0; server->tcp_buffer_pos = 0;