|
|
|
/*
|
|
|
|
* Copyright (C) The c-ares project
|
|
|
|
*
|
|
|
|
* Permission to use, copy, modify, and distribute this
|
|
|
|
* software and its documentation for any purpose and without
|
|
|
|
* fee is hereby granted, provided that the above copyright
|
|
|
|
* notice appear in all copies and that both that copyright
|
|
|
|
* notice and this permission notice appear in supporting
|
|
|
|
* documentation, and that the name of M.I.T. not be used in
|
|
|
|
* advertising or publicity pertaining to distribution of the
|
|
|
|
* software without specific, written prior permission.
|
|
|
|
* M.I.T. makes no representations about the suitability of
|
|
|
|
* this software for any purpose. It is provided "as is"
|
|
|
|
* without express or implied warranty.
|
|
|
|
*
|
|
|
|
* SPDX-License-Identifier: MIT
|
|
|
|
*/
|
|
|
|
// This file includes tests that attempt to do real lookups
|
|
|
|
// of DNS names using the local machine's live infrastructure.
|
|
|
|
// As a result, we don't check the results very closely, to allow
|
|
|
|
// for varying local configurations.
|
|
|
|
|
|
|
|
#include "ares-test.h"
|
|
|
|
|
|
|
|
#ifdef HAVE_NETDB_H
|
|
|
|
#include <netdb.h>
|
|
|
|
#endif
|
|
|
|
|
|
|
|
namespace ares {
|
|
|
|
namespace test {
|
|
|
|
|
|
|
|
// Use the address of CloudFlare's public DNS servers as example addresses that are
|
|
|
|
// likely to be accessible everywhere/everywhen. We used to use google but they
|
|
|
|
// stopped returning reverse dns answers in Dec 2023
|
|
|
|
unsigned char cflare_addr4[4] = { 0x01, 0x01, 0x01, 0x01 };
|
|
|
|
unsigned char cflare_addr6[16] = {
|
|
|
|
0x26, 0x06, 0x47, 0x00, 0x47, 0x00, 0x00, 0x00,
|
|
|
|
0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x11, 0x11
|
|
|
|
};
|
|
|
|
|
|
|
|
MATCHER_P(IncludesAtLeastNumAddresses, n, "") {
|
|
|
|
if(!arg)
|
|
|
|
return false;
|
|
|
|
int cnt = 0;
|
|
|
|
for (const ares_addrinfo_node* ai = arg->nodes; ai != NULL; ai = ai->ai_next)
|
|
|
|
cnt++;
|
|
|
|
return cnt >= n;
|
|
|
|
}
|
|
|
|
|
|
|
|
MATCHER_P(OnlyIncludesAddrType, addrtype, "") {
|
|
|
|
if(!arg)
|
|
|
|
return false;
|
|
|
|
for (const ares_addrinfo_node* ai = arg->nodes; ai != NULL; ai = ai->ai_next)
|
|
|
|
if (ai->ai_family != addrtype)
|
|
|
|
return false;
|
|
|
|
return true;
|
|
|
|
}
|
|
|
|
|
|
|
|
MATCHER_P(IncludesAddrType, addrtype, "") {
|
|
|
|
if(!arg)
|
|
|
|
return false;
|
|
|
|
for (const ares_addrinfo_node* ai = arg->nodes; ai != NULL; ai = ai->ai_next)
|
|
|
|
if (ai->ai_family == addrtype)
|
|
|
|
return true;
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
|
|
|
//VIRT_NONVIRT_TEST_F(DefaultChannelTest, LiveGetAddrInfoV4) {
|
|
|
|
//struct ares_addrinfo_hints hints = {};
|
|
|
|
//hints.ai_family = AF_INET;
|
|
|
|
//AddrInfoResult result;
|
|
|
|
//ares_getaddrinfo(channel_, "www.google.com.", NULL, &hints, AddrInfoCallback, &result);
|
|
|
|
//Process();
|
|
|
|
//EXPECT_TRUE(result.done_);
|
|
|
|
//EXPECT_EQ(ARES_SUCCESS, result.status_);
|
|
|
|
//EXPECT_THAT(result.ai_, IncludesAtLeastNumAddresses(1));
|
|
|
|
//EXPECT_THAT(result.ai_, OnlyIncludesAddrType(AF_INET));
|
|
|
|
//}
|
|
|
|
|
|
|
|
//VIRT_NONVIRT_TEST_F(DefaultChannelTest, LiveGetAddrInfoV6) {
|
|
|
|
//struct ares_addrinfo_hints hints = {};
|
|
|
|
//hints.ai_family = AF_INET6;
|
|
|
|
//AddrInfoResult result;
|
|
|
|
//ares_getaddrinfo(channel_, "www.google.com.", NULL, &hints, AddrInfoCallback, &result);
|
|
|
|
//Process();
|
|
|
|
//EXPECT_TRUE(result.done_);
|
|
|
|
//EXPECT_EQ(ARES_SUCCESS, result.status_);
|
|
|
|
//EXPECT_THAT(result.ai_, IncludesAtLeastNumAddresses(1));
|
|
|
|
//EXPECT_THAT(result.ai_, OnlyIncludesAddrType(AF_INET6));
|
|
|
|
//}
|
|
|
|
|
|
|
|
//VIRT_NONVIRT_TEST_F(DefaultChannelTest, LiveGetAddrInfoUnspec) {
|
|
|
|
//struct ares_addrinfo_hints hints = {};
|
|
|
|
//hints.ai_family = AF_UNSPEC;
|
|
|
|
//AddrInfoResult result;
|
|
|
|
//ares_getaddrinfo(channel_, "www.google.com.", NULL, &hints, AddrInfoCallback, &result);
|
|
|
|
//Process();
|
|
|
|
//EXPECT_TRUE(result.done_);
|
|
|
|
//EXPECT_EQ(ARES_SUCCESS, result.status_);
|
|
|
|
//EXPECT_THAT(result.ai_, IncludesAtLeastNumAddresses(2));
|
|
|
|
//EXPECT_THAT(result.ai_, IncludesAddrType(AF_INET6));
|
|
|
|
//EXPECT_THAT(result.ai_, IncludesAddrType(AF_INET));
|
|
|
|
//}
|
|
|
|
|
|
|
|
VIRT_NONVIRT_TEST_F(DefaultChannelTest, LiveGetHostByNameV4) {
|
|
|
|
HostResult result;
|
|
|
|
ares_gethostbyname(channel_, "www.google.com.", AF_INET, HostCallback, &result);
|
|
|
|
Process();
|
|
|
|
EXPECT_TRUE(result.done_);
|
|
|
|
EXPECT_EQ(ARES_SUCCESS, result.status_);
|
|
|
|
EXPECT_LT(0, (int)result.host_.addrs_.size());
|
|
|
|
EXPECT_EQ(AF_INET, result.host_.addrtype_);
|
|
|
|
}
|
|
|
|
|
|
|
|
VIRT_NONVIRT_TEST_F(DefaultChannelTest, LiveGetHostByNameV6) {
|
|
|
|
HostResult result;
|
|
|
|
ares_gethostbyname(channel_, "www.google.com.", AF_INET6, HostCallback, &result);
|
|
|
|
Process();
|
|
|
|
EXPECT_TRUE(result.done_);
|
|
|
|
EXPECT_EQ(ARES_SUCCESS, result.status_);
|
|
|
|
EXPECT_LT(0, (int)result.host_.addrs_.size());
|
|
|
|
EXPECT_EQ(AF_INET6, result.host_.addrtype_);
|
|
|
|
}
|
|
|
|
|
|
|
|
VIRT_NONVIRT_TEST_F(DefaultChannelTest, LiveGetHostByAddrV4) {
|
|
|
|
HostResult result;
|
|
|
|
ares_gethostbyaddr(channel_, cflare_addr4, sizeof(cflare_addr4), AF_INET, HostCallback, &result);
|
|
|
|
Process();
|
|
|
|
EXPECT_TRUE(result.done_);
|
|
|
|
EXPECT_EQ(ARES_SUCCESS, result.status_);
|
|
|
|
EXPECT_LT(0, (int)result.host_.addrs_.size());
|
|
|
|
EXPECT_EQ(AF_INET, result.host_.addrtype_);
|
|
|
|
}
|
|
|
|
|
|
|
|
VIRT_NONVIRT_TEST_F(DefaultChannelTest, LiveGetHostByAddrV6) {
|
|
|
|
HostResult result;
|
|
|
|
ares_gethostbyaddr(channel_, cflare_addr6, sizeof(cflare_addr6), AF_INET6, HostCallback, &result);
|
|
|
|
Process();
|
|
|
|
EXPECT_TRUE(result.done_);
|
|
|
|
EXPECT_EQ(ARES_SUCCESS, result.status_);
|
|
|
|
EXPECT_LT(0, (int)result.host_.addrs_.size());
|
|
|
|
EXPECT_EQ(AF_INET6, result.host_.addrtype_);
|
|
|
|
}
|
|
|
|
|
|
|
|
VIRT_NONVIRT_TEST_F(DefaultChannelTest, LiveGetHostByNameFile) {
|
|
|
|
struct hostent *host = nullptr;
|
|
|
|
|
|
|
|
// Still need a channel even to query /etc/hosts.
|
|
|
|
EXPECT_EQ(ARES_ENOTFOUND,
|
|
|
|
ares_gethostbyname_file(nullptr, "localhost", AF_INET, &host));
|
|
|
|
|
|
|
|
int rc = ares_gethostbyname_file(channel_, "bogus.mcname", AF_INET, &host);
|
|
|
|
EXPECT_EQ(nullptr, host);
|
|
|
|
EXPECT_EQ(ARES_ENOTFOUND, rc);
|
|
|
|
|
|
|
|
rc = ares_gethostbyname_file(channel_, "localhost", AF_INET, &host);
|
|
|
|
if (rc == ARES_SUCCESS) {
|
|
|
|
EXPECT_NE(nullptr, host);
|
|
|
|
ares_free_hostent(host);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
TEST_P(DefaultChannelModeTest, LiveGetLocalhostByNameV4) {
|
|
|
|
HostResult result;
|
|
|
|
ares_gethostbyname(channel_, "localhost", AF_INET, HostCallback, &result);
|
|
|
|
Process();
|
|
|
|
EXPECT_TRUE(result.done_);
|
|
|
|
if (result.status_ != ARES_ECONNREFUSED) {
|
|
|
|
EXPECT_EQ(ARES_SUCCESS, result.status_);
|
|
|
|
EXPECT_EQ(1, (int)result.host_.addrs_.size());
|
|
|
|
EXPECT_EQ(AF_INET, result.host_.addrtype_);
|
|
|
|
EXPECT_NE(std::string::npos, result.host_.name_.find("localhost"));
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
TEST_P(DefaultChannelModeTest, LiveGetLocalhostByNameV6) {
|
|
|
|
HostResult result;
|
|
|
|
ares_gethostbyname(channel_, "localhost", AF_INET6, HostCallback, &result);
|
|
|
|
Process();
|
|
|
|
EXPECT_TRUE(result.done_);
|
|
|
|
if (result.status_ != ARES_ECONNREFUSED) {
|
|
|
|
EXPECT_EQ(ARES_SUCCESS, result.status_);
|
|
|
|
EXPECT_EQ(1, (int)result.host_.addrs_.size());
|
|
|
|
EXPECT_EQ(AF_INET6, result.host_.addrtype_);
|
|
|
|
std::stringstream ss;
|
|
|
|
ss << HostEnt(result.host_);
|
|
|
|
EXPECT_NE(std::string::npos, result.host_.name_.find("localhost"));
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
TEST_P(DefaultChannelModeTest, LiveGetNonExistLocalhostByNameV4) {
|
|
|
|
HostResult result;
|
|
|
|
ares_gethostbyname(channel_, "idonotexist.localhost", AF_INET, HostCallback, &result);
|
|
|
|
Process();
|
|
|
|
EXPECT_TRUE(result.done_);
|
|
|
|
if (result.status_ != ARES_ECONNREFUSED) {
|
|
|
|
EXPECT_EQ(ARES_SUCCESS, result.status_);
|
|
|
|
EXPECT_EQ(1, (int)result.host_.addrs_.size());
|
|
|
|
EXPECT_EQ(AF_INET, result.host_.addrtype_);
|
|
|
|
EXPECT_NE(std::string::npos, result.host_.name_.find("idonotexist.localhost"));
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
TEST_P(DefaultChannelModeTest, LiveGetNonExistLocalhostByNameV6) {
|
|
|
|
HostResult result;
|
|
|
|
ares_gethostbyname(channel_, "idonotexist.localhost", AF_INET6, HostCallback, &result);
|
|
|
|
Process();
|
|
|
|
EXPECT_TRUE(result.done_);
|
|
|
|
if (result.status_ != ARES_ECONNREFUSED) {
|
|
|
|
EXPECT_EQ(ARES_SUCCESS, result.status_);
|
|
|
|
EXPECT_EQ(1, (int)result.host_.addrs_.size());
|
|
|
|
EXPECT_EQ(AF_INET6, result.host_.addrtype_);
|
|
|
|
std::stringstream ss;
|
|
|
|
ss << HostEnt(result.host_);
|
|
|
|
EXPECT_NE(std::string::npos, result.host_.name_.find("idonotexist.localhost"));
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
TEST_P(DefaultChannelModeTest, LiveGetLocalhostByNameIPV4) {
|
|
|
|
HostResult result;
|
|
|
|
ares_gethostbyname(channel_, "127.0.0.1", AF_INET, HostCallback, &result);
|
|
|
|
Process();
|
|
|
|
EXPECT_TRUE(result.done_);
|
|
|
|
EXPECT_EQ(ARES_SUCCESS, result.status_);
|
|
|
|
EXPECT_EQ(1, (int)result.host_.addrs_.size());
|
|
|
|
EXPECT_EQ(AF_INET, result.host_.addrtype_);
|
|
|
|
std::stringstream ss;
|
|
|
|
ss << HostEnt(result.host_);
|
|
|
|
EXPECT_EQ("{'127.0.0.1' aliases=[] addrs=[127.0.0.1]}", ss.str());
|
|
|
|
}
|
|
|
|
|
|
|
|
TEST_P(DefaultChannelModeTest, LiveGetLocalhostByNameIPV6) {
|
|
|
|
HostResult result;
|
|
|
|
ares_gethostbyname(channel_, "::1", AF_INET6, HostCallback, &result);
|
|
|
|
Process();
|
|
|
|
EXPECT_TRUE(result.done_);
|
|
|
|
if (result.status_ != ARES_ENOTFOUND) {
|
|
|
|
EXPECT_EQ(ARES_SUCCESS, result.status_);
|
|
|
|
EXPECT_EQ(1, (int)result.host_.addrs_.size());
|
|
|
|
EXPECT_EQ(AF_INET6, result.host_.addrtype_);
|
|
|
|
std::stringstream ss;
|
|
|
|
ss << HostEnt(result.host_);
|
|
|
|
EXPECT_EQ("{'::1' aliases=[] addrs=[0000:0000:0000:0000:0000:0000:0000:0001]}", ss.str());
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
TEST_P(DefaultChannelModeTest, LiveGetLocalhostFailFamily) {
|
|
|
|
HostResult result;
|
|
|
|
ares_gethostbyname(channel_, "127.0.0.1", AF_INET+AF_INET6, HostCallback, &result);
|
|
|
|
Process();
|
|
|
|
EXPECT_TRUE(result.done_);
|
|
|
|
EXPECT_EQ(ARES_ENOTIMP, result.status_);
|
|
|
|
}
|
|
|
|
|
|
|
|
TEST_P(DefaultChannelModeTest, LiveGetLocalhostByAddrV4) {
|
|
|
|
HostResult result;
|
|
|
|
struct in_addr addr;
|
|
|
|
addr.s_addr = htonl(INADDR_LOOPBACK);
|
|
|
|
ares_gethostbyaddr(channel_, &addr, sizeof(addr), AF_INET, HostCallback, &result);
|
|
|
|
Process();
|
|
|
|
EXPECT_TRUE(result.done_);
|
|
|
|
if (result.status_ != ARES_ENOTFOUND) {
|
|
|
|
EXPECT_EQ(ARES_SUCCESS, result.status_);
|
|
|
|
EXPECT_LT(0, (int)result.host_.addrs_.size());
|
|
|
|
EXPECT_EQ(AF_INET, result.host_.addrtype_);
|
|
|
|
// oddly, travis does not resolve to localhost, but a random hostname starting with travis-job
|
|
|
|
if (result.host_.name_.find("travis-job") == std::string::npos) {
|
|
|
|
EXPECT_NE(std::string::npos,
|
|
|
|
result.host_.name_.find("localhost"));
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
TEST_P(DefaultChannelModeTest, LiveGetLocalhostByAddrV6) {
|
|
|
|
HostResult result;
|
|
|
|
struct in6_addr addr;
|
|
|
|
memset(&addr, 0, sizeof(addr));
|
|
|
|
addr.s6_addr[15] = 1; // in6addr_loopback
|
|
|
|
ares_gethostbyaddr(channel_, &addr, sizeof(addr), AF_INET6, HostCallback, &result);
|
|
|
|
Process();
|
|
|
|
EXPECT_TRUE(result.done_);
|
|
|
|
if (result.status_ != ARES_ENOTFOUND) {
|
|
|
|
EXPECT_EQ(ARES_SUCCESS, result.status_);
|
|
|
|
EXPECT_LT(0, (int)result.host_.addrs_.size());
|
|
|
|
EXPECT_EQ(AF_INET6, result.host_.addrtype_);
|
|
|
|
const std::string& name = result.host_.name_;
|
|
|
|
EXPECT_TRUE(std::string::npos != name.find("localhost") ||
|
|
|
|
std::string::npos != name.find("ip6-loopback"));
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
TEST_P(DefaultChannelModeTest, LiveGetHostByAddrFailFamily) {
|
|
|
|
HostResult result;
|
|
|
|
unsigned char addr[4] = {8, 8, 8, 8};
|
|
|
|
ares_gethostbyaddr(channel_, addr, sizeof(addr), AF_INET6+AF_INET,
|
|
|
|
HostCallback, &result);
|
|
|
|
EXPECT_TRUE(result.done_);
|
|
|
|
EXPECT_EQ(ARES_ENOTIMP, result.status_);
|
|
|
|
}
|
|
|
|
|
|
|
|
TEST_P(DefaultChannelModeTest, LiveGetHostByAddrFailAddrSize) {
|
|
|
|
HostResult result;
|
|
|
|
unsigned char addr[4] = {8, 8, 8, 8};
|
|
|
|
ares_gethostbyaddr(channel_, addr, sizeof(addr) - 1, AF_INET,
|
|
|
|
HostCallback, &result);
|
|
|
|
EXPECT_TRUE(result.done_);
|
|
|
|
EXPECT_EQ(ARES_ENOTIMP, result.status_);
|
|
|
|
}
|
|
|
|
|
|
|
|
TEST_P(DefaultChannelModeTest, LiveGetHostByAddrFailAlloc) {
|
|
|
|
HostResult result;
|
|
|
|
unsigned char addr[4] = {8, 8, 8, 8};
|
|
|
|
SetAllocFail(1);
|
|
|
|
ares_gethostbyaddr(channel_, addr, sizeof(addr), AF_INET,
|
|
|
|
HostCallback, &result);
|
|
|
|
EXPECT_TRUE(result.done_);
|
|
|
|
EXPECT_EQ(ARES_ENOMEM, result.status_);
|
|
|
|
}
|
|
|
|
|
|
|
|
INSTANTIATE_TEST_SUITE_P(Modes, DefaultChannelModeTest,
|
|
|
|
::testing::Values("f", "b", "fb", "bf"));
|
|
|
|
|
|
|
|
VIRT_NONVIRT_TEST_F(DefaultChannelTest, LiveSearchA) {
|
|
|
|
SearchResult result;
|
|
|
|
ares_search(channel_, "www.youtube.com.", C_IN, T_A,
|
|
|
|
SearchCallback, &result);
|
|
|
|
Process();
|
|
|
|
EXPECT_TRUE(result.done_);
|
|
|
|
EXPECT_EQ(ARES_SUCCESS, result.status_);
|
|
|
|
}
|
|
|
|
|
|
|
|
VIRT_NONVIRT_TEST_F(DefaultChannelTest, LiveSearchEmptyA) {
|
|
|
|
SearchResult result;
|
|
|
|
ares_search(channel_, "", C_IN, T_A,
|
|
|
|
SearchCallback, &result);
|
|
|
|
Process();
|
|
|
|
EXPECT_TRUE(result.done_);
|
|
|
|
EXPECT_NE(ARES_SUCCESS, result.status_);
|
|
|
|
}
|
|
|
|
|
|
|
|
VIRT_NONVIRT_TEST_F(DefaultChannelTest, LiveSearchNS) {
|
|
|
|
SearchResult result;
|
|
|
|
ares_search(channel_, "google.com.", C_IN, T_NS,
|
|
|
|
SearchCallback, &result);
|
|
|
|
Process();
|
|
|
|
EXPECT_TRUE(result.done_);
|
|
|
|
EXPECT_EQ(ARES_SUCCESS, result.status_);
|
|
|
|
}
|
|
|
|
|
|
|
|
VIRT_NONVIRT_TEST_F(DefaultChannelTest, LiveSearchMX) {
|
|
|
|
SearchResult result;
|
|
|
|
ares_search(channel_, "google.com.", C_IN, T_MX,
|
|
|
|
SearchCallback, &result);
|
|
|
|
Process();
|
|
|
|
EXPECT_TRUE(result.done_);
|
|
|
|
EXPECT_EQ(ARES_SUCCESS, result.status_);
|
|
|
|
}
|
|
|
|
|
|
|
|
VIRT_NONVIRT_TEST_F(DefaultChannelTest, LiveSearchTXT) {
|
|
|
|
SearchResult result;
|
|
|
|
ares_search(channel_, "google.com.", C_IN, T_TXT,
|
|
|
|
SearchCallback, &result);
|
|
|
|
Process();
|
|
|
|
EXPECT_TRUE(result.done_);
|
|
|
|
EXPECT_EQ(ARES_SUCCESS, result.status_);
|
|
|
|
}
|
|
|
|
|
|
|
|
VIRT_NONVIRT_TEST_F(DefaultChannelTest, LiveSearchSOA) {
|
|
|
|
SearchResult result;
|
|
|
|
ares_search(channel_, "google.com.", C_IN, T_SOA,
|
|
|
|
SearchCallback, &result);
|
|
|
|
Process();
|
|
|
|
EXPECT_TRUE(result.done_);
|
|
|
|
EXPECT_EQ(ARES_SUCCESS, result.status_);
|
|
|
|
}
|
|
|
|
|
|
|
|
VIRT_NONVIRT_TEST_F(DefaultChannelTest, LiveSearchSRV) {
|
|
|
|
SearchResult result;
|
|
|
|
ares_search(channel_, "_imap._tcp.gmail.com.", C_IN, T_SRV,
|
|
|
|
SearchCallback, &result);
|
|
|
|
Process();
|
|
|
|
EXPECT_TRUE(result.done_);
|
|
|
|
EXPECT_EQ(ARES_SUCCESS, result.status_);
|
|
|
|
}
|
|
|
|
|
|
|
|
VIRT_NONVIRT_TEST_F(DefaultChannelTest, LiveSearchANY) {
|
|
|
|
SearchResult result;
|
|
|
|
ares_search(channel_, "google.com.", C_IN, T_ANY,
|
|
|
|
SearchCallback, &result);
|
|
|
|
Process();
|
|
|
|
EXPECT_TRUE(result.done_);
|
|
|
|
EXPECT_EQ(ARES_SUCCESS, result.status_);
|
|
|
|
}
|
|
|
|
|
|
|
|
VIRT_NONVIRT_TEST_F(DefaultChannelTest, LiveGetNameInfoV4) {
|
|
|
|
NameInfoResult result;
|
|
|
|
struct sockaddr_in sockaddr;
|
|
|
|
memset(&sockaddr, 0, sizeof(sockaddr));
|
|
|
|
sockaddr.sin_family = AF_INET;
|
|
|
|
sockaddr.sin_port = htons(53);
|
|
|
|
sockaddr.sin_addr.s_addr = htonl(0x08080808);
|
|
|
|
ares_getnameinfo(channel_, (const struct sockaddr*)&sockaddr, sizeof(sockaddr),
|
|
|
|
ARES_NI_LOOKUPHOST|ARES_NI_LOOKUPSERVICE|ARES_NI_UDP,
|
|
|
|
NameInfoCallback, &result);
|
|
|
|
Process();
|
|
|
|
EXPECT_TRUE(result.done_);
|
|
|
|
EXPECT_EQ(ARES_SUCCESS, result.status_);
|
|
|
|
if (verbose) std::cerr << "8.8.8.8:53 => " << result.node_ << "/" << result.service_ << std::endl;
|
|
|
|
}
|
|
|
|
|
|
|
|
VIRT_NONVIRT_TEST_F(DefaultChannelTest, LiveGetNameInfoV4NoPort) {
|
|
|
|
NameInfoResult result;
|
|
|
|
struct sockaddr_in sockaddr;
|
|
|
|
memset(&sockaddr, 0, sizeof(sockaddr));
|
|
|
|
sockaddr.sin_family = AF_INET;
|
|
|
|
sockaddr.sin_port = htons(0);
|
|
|
|
sockaddr.sin_addr.s_addr = htonl(0x08080808);
|
|
|
|
ares_getnameinfo(channel_, (const struct sockaddr*)&sockaddr, sizeof(sockaddr),
|
|
|
|
ARES_NI_LOOKUPHOST|ARES_NI_LOOKUPSERVICE|ARES_NI_UDP,
|
|
|
|
NameInfoCallback, &result);
|
|
|
|
Process();
|
|
|
|
EXPECT_TRUE(result.done_);
|
|
|
|
EXPECT_EQ(ARES_SUCCESS, result.status_);
|
|
|
|
if (verbose) std::cerr << "8.8.8.8:0 => " << result.node_ << "/" << result.service_ << std::endl;
|
|
|
|
}
|
|
|
|
|
|
|
|
VIRT_NONVIRT_TEST_F(DefaultChannelTest, LiveGetNameInfoV4UnassignedPort) {
|
|
|
|
NameInfoResult result;
|
|
|
|
struct sockaddr_in sockaddr;
|
|
|
|
memset(&sockaddr, 0, sizeof(sockaddr));
|
|
|
|
sockaddr.sin_family = AF_INET;
|
|
|
|
sockaddr.sin_port = htons(4); // Unassigned at IANA
|
|
|
|
sockaddr.sin_addr.s_addr = htonl(0x08080808);
|
|
|
|
ares_getnameinfo(channel_, (const struct sockaddr*)&sockaddr, sizeof(sockaddr),
|
|
|
|
ARES_NI_LOOKUPHOST|ARES_NI_LOOKUPSERVICE|ARES_NI_UDP,
|
|
|
|
NameInfoCallback, &result);
|
|
|
|
Process();
|
|
|
|
EXPECT_TRUE(result.done_);
|
|
|
|
EXPECT_EQ(ARES_SUCCESS, result.status_);
|
|
|
|
if (verbose) std::cerr << "8.8.8.8:4 => " << result.node_ << "/" << result.service_ << std::endl;
|
|
|
|
}
|
|
|
|
|
|
|
|
VIRT_NONVIRT_TEST_F(DefaultChannelTest, LiveGetNameInfoV6Both) {
|
|
|
|
NameInfoResult result;
|
|
|
|
struct sockaddr_in6 sockaddr;
|
|
|
|
memset(&sockaddr, 0, sizeof(sockaddr));
|
|
|
|
sockaddr.sin6_family = AF_INET6;
|
|
|
|
sockaddr.sin6_port = htons(53);
|
|
|
|
memcpy(sockaddr.sin6_addr.s6_addr, cflare_addr6, 16);
|
|
|
|
ares_getnameinfo(channel_, (const struct sockaddr*)&sockaddr, sizeof(sockaddr),
|
|
|
|
ARES_NI_TCP|ARES_NI_LOOKUPHOST|ARES_NI_LOOKUPSERVICE|ARES_NI_NOFQDN,
|
|
|
|
NameInfoCallback, &result);
|
|
|
|
Process();
|
|
|
|
EXPECT_TRUE(result.done_);
|
|
|
|
EXPECT_EQ(ARES_SUCCESS, result.status_);
|
|
|
|
if (verbose) std::cerr << "[2001:4860:4860::8888]:53 => " << result.node_ << "/" << result.service_ << std::endl;
|
|
|
|
}
|
|
|
|
|
|
|
|
VIRT_NONVIRT_TEST_F(DefaultChannelTest, LiveGetNameInfoV6Neither) {
|
|
|
|
NameInfoResult result;
|
|
|
|
struct sockaddr_in6 sockaddr;
|
|
|
|
memset(&sockaddr, 0, sizeof(sockaddr));
|
|
|
|
sockaddr.sin6_family = AF_INET6;
|
|
|
|
sockaddr.sin6_port = htons(53);
|
|
|
|
memcpy(sockaddr.sin6_addr.s6_addr, cflare_addr6, 16);
|
|
|
|
ares_getnameinfo(channel_, (const struct sockaddr*)&sockaddr, sizeof(sockaddr),
|
|
|
|
ARES_NI_TCP|ARES_NI_NOFQDN, // Neither specified => assume lookup host.
|
|
|
|
NameInfoCallback, &result);
|
|
|
|
Process();
|
|
|
|
EXPECT_TRUE(result.done_);
|
|
|
|
EXPECT_EQ(ARES_SUCCESS, result.status_);
|
|
|
|
if (verbose) std::cerr << "[2001:4860:4860::8888]:53 => " << result.node_ << "/" << result.service_ << std::endl;
|
|
|
|
}
|
|
|
|
|
|
|
|
VIRT_NONVIRT_TEST_F(DefaultChannelTest, LiveGetNameInfoV4Numeric) {
|
|
|
|
NameInfoResult result;
|
|
|
|
struct sockaddr_in sockaddr;
|
|
|
|
memset(&sockaddr, 0, sizeof(sockaddr));
|
|
|
|
sockaddr.sin_family = AF_INET;
|
|
|
|
sockaddr.sin_port = htons(53);
|
|
|
|
sockaddr.sin_addr.s_addr = htonl(0x08080808);
|
|
|
|
ares_getnameinfo(channel_, (const struct sockaddr*)&sockaddr, sizeof(sockaddr),
|
|
|
|
ARES_NI_LOOKUPHOST|ARES_NI_LOOKUPSERVICE|ARES_NI_TCP|ARES_NI_NUMERICHOST,
|
|
|
|
NameInfoCallback, &result);
|
|
|
|
Process();
|
|
|
|
EXPECT_TRUE(result.done_);
|
|
|
|
EXPECT_EQ(ARES_SUCCESS, result.status_);
|
|
|
|
EXPECT_EQ("8.8.8.8", result.node_);
|
|
|
|
if (verbose) std::cerr << "8.8.8.8:53 => " << result.node_ << "/" << result.service_ << std::endl;
|
|
|
|
}
|
|
|
|
|
|
|
|
VIRT_NONVIRT_TEST_F(DefaultChannelTest, LiveGetNameInfoV6Numeric) {
|
|
|
|
NameInfoResult result;
|
|
|
|
struct sockaddr_in6 sockaddr;
|
|
|
|
memset(&sockaddr, 0, sizeof(sockaddr));
|
|
|
|
sockaddr.sin6_family = AF_INET6;
|
|
|
|
sockaddr.sin6_port = htons(53);
|
|
|
|
memcpy(sockaddr.sin6_addr.s6_addr, cflare_addr6, 16);
|
|
|
|
ares_getnameinfo(channel_, (const struct sockaddr*)&sockaddr, sizeof(sockaddr),
|
|
|
|
ARES_NI_LOOKUPHOST|ARES_NI_LOOKUPSERVICE|ARES_NI_DCCP|ARES_NI_NUMERICHOST,
|
|
|
|
NameInfoCallback, &result);
|
|
|
|
Process();
|
|
|
|
EXPECT_TRUE(result.done_);
|
|
|
|
EXPECT_EQ(ARES_SUCCESS, result.status_);
|
|
|
|
EXPECT_EQ("2606:4700:4700::1111%0", result.node_);
|
|
|
|
if (verbose) std::cerr << "[2606:4700:4700::1111]:53 => " << result.node_ << "/" << result.service_ << std::endl;
|
|
|
|
}
|
|
|
|
|
|
|
|
VIRT_NONVIRT_TEST_F(DefaultChannelTest, LiveGetNameInfoV6LinkLocal) {
|
|
|
|
NameInfoResult result;
|
|
|
|
struct sockaddr_in6 sockaddr;
|
|
|
|
memset(&sockaddr, 0, sizeof(sockaddr));
|
|
|
|
sockaddr.sin6_family = AF_INET6;
|
|
|
|
sockaddr.sin6_port = htons(53);
|
|
|
|
unsigned char addr6[16] = {0xfe, 0x80, 0x01, 0x02, 0x01, 0x02, 0x00, 0x00,
|
|
|
|
0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x03, 0x04};
|
|
|
|
memcpy(sockaddr.sin6_addr.s6_addr, addr6, 16);
|
|
|
|
ares_getnameinfo(channel_, (const struct sockaddr*)&sockaddr, sizeof(sockaddr),
|
|
|
|
ARES_NI_LOOKUPHOST|ARES_NI_LOOKUPSERVICE|ARES_NI_DCCP|ARES_NI_NUMERICHOST,
|
|
|
|
NameInfoCallback, &result);
|
|
|
|
Process();
|
|
|
|
EXPECT_TRUE(result.done_);
|
|
|
|
EXPECT_EQ(ARES_SUCCESS, result.status_);
|
|
|
|
EXPECT_EQ("fe80:102:102::304%0", result.node_);
|
|
|
|
if (verbose) std::cerr << "[fe80:102:102::304]:53 => " << result.node_ << "/" << result.service_ << std::endl;
|
|
|
|
}
|
|
|
|
|
|
|
|
VIRT_NONVIRT_TEST_F(DefaultChannelTest, LiveGetNameInfoV4NotFound) {
|
|
|
|
NameInfoResult result;
|
|
|
|
struct sockaddr_in sockaddr;
|
|
|
|
memset(&sockaddr, 0, sizeof(sockaddr));
|
|
|
|
sockaddr.sin_family = AF_INET;
|
|
|
|
sockaddr.sin_port = htons(4); // Port 4 unassigned at IANA
|
|
|
|
// RFC5737 says 192.0.2.0 should not be used publicly.
|
|
|
|
sockaddr.sin_addr.s_addr = htonl(0xC0000200);
|
|
|
|
ares_getnameinfo(channel_, (const struct sockaddr*)&sockaddr, sizeof(sockaddr),
|
|
|
|
ARES_NI_LOOKUPHOST|ARES_NI_LOOKUPSERVICE|ARES_NI_UDP,
|
|
|
|
NameInfoCallback, &result);
|
|
|
|
Process();
|
|
|
|
EXPECT_TRUE(result.done_);
|
|
|
|
EXPECT_EQ(ARES_SUCCESS, result.status_);
|
|
|
|
EXPECT_EQ("192.0.2.0", result.node_);
|
|
|
|
if (verbose) std::cerr << "192.0.2.0:53 => " << result.node_ << "/" << result.service_ << std::endl;
|
|
|
|
}
|
|
|
|
|
|
|
|
VIRT_NONVIRT_TEST_F(DefaultChannelTest, LiveGetNameInfoV4NotFoundFail) {
|
|
|
|
NameInfoResult result;
|
|
|
|
struct sockaddr_in sockaddr;
|
|
|
|
memset(&sockaddr, 0, sizeof(sockaddr));
|
|
|
|
sockaddr.sin_family = AF_INET;
|
|
|
|
sockaddr.sin_port = htons(53);
|
|
|
|
// RFC5737 says 192.0.2.0 should not be used publicly.
|
|
|
|
sockaddr.sin_addr.s_addr = htonl(0xC0000200);
|
|
|
|
ares_getnameinfo(channel_, (const struct sockaddr*)&sockaddr, sizeof(sockaddr),
|
|
|
|
ARES_NI_LOOKUPHOST|ARES_NI_LOOKUPSERVICE|ARES_NI_UDP|ARES_NI_NAMEREQD,
|
|
|
|
NameInfoCallback, &result);
|
|
|
|
Process();
|
|
|
|
EXPECT_TRUE(result.done_);
|
|
|
|
EXPECT_EQ(ARES_ENOTFOUND, result.status_);
|
|
|
|
}
|
|
|
|
|
|
|
|
VIRT_NONVIRT_TEST_F(DefaultChannelTest, LiveGetNameInfoV6NotFound) {
|
|
|
|
NameInfoResult result;
|
|
|
|
struct sockaddr_in6 sockaddr;
|
|
|
|
memset(&sockaddr, 0, sizeof(sockaddr));
|
|
|
|
sockaddr.sin6_family = AF_INET6;
|
|
|
|
sockaddr.sin6_port = htons(53);
|
|
|
|
// 2001:db8::/32 is only supposed to be used in documentation.
|
|
|
|
unsigned char addr6[16] = {0x20, 0x01, 0x0d, 0xb8, 0x01, 0x02, 0x00, 0x00,
|
|
|
|
0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x03, 0x04};
|
|
|
|
memcpy(sockaddr.sin6_addr.s6_addr, addr6, 16);
|
|
|
|
ares_getnameinfo(channel_, (const struct sockaddr*)&sockaddr, sizeof(sockaddr),
|
|
|
|
ARES_NI_LOOKUPHOST|ARES_NI_LOOKUPSERVICE|ARES_NI_UDP,
|
|
|
|
NameInfoCallback, &result);
|
|
|
|
Process();
|
|
|
|
EXPECT_TRUE(result.done_);
|
|
|
|
EXPECT_EQ(ARES_SUCCESS, result.status_);
|
|
|
|
EXPECT_EQ("2001:db8:102::304%0", result.node_);
|
|
|
|
if (verbose) std::cerr << "[2001:db8:102::304]:53 => " << result.node_ << "/" << result.service_ << std::endl;
|
|
|
|
}
|
|
|
|
|
|
|
|
VIRT_NONVIRT_TEST_F(DefaultChannelTest, LiveGetNameInvalidFamily) {
|
|
|
|
NameInfoResult result;
|
|
|
|
struct sockaddr_in6 sockaddr;
|
|
|
|
memset(&sockaddr, 0, sizeof(sockaddr));
|
|
|
|
sockaddr.sin6_family = AF_INET6 + AF_INET;
|
|
|
|
sockaddr.sin6_port = htons(53);
|
|
|
|
memcpy(sockaddr.sin6_addr.s6_addr, cflare_addr6, 16);
|
|
|
|
ares_getnameinfo(channel_, (const struct sockaddr*)&sockaddr, sizeof(sockaddr),
|
|
|
|
ARES_NI_LOOKUPHOST|ARES_NI_LOOKUPSERVICE|ARES_NI_UDP,
|
|
|
|
NameInfoCallback, &result);
|
|
|
|
Process();
|
|
|
|
EXPECT_TRUE(result.done_);
|
|
|
|
EXPECT_EQ(ARES_ENOTIMP, result.status_);
|
|
|
|
}
|
|
|
|
|
|
|
|
VIRT_NONVIRT_TEST_F(DefaultChannelTest, LiveGetNameInvalidFlags) {
|
|
|
|
NameInfoResult result;
|
|
|
|
struct sockaddr_in6 sockaddr;
|
|
|
|
memset(&sockaddr, 0, sizeof(sockaddr));
|
|
|
|
sockaddr.sin6_family = AF_INET6;
|
|
|
|
sockaddr.sin6_port = htons(53);
|
|
|
|
memcpy(sockaddr.sin6_addr.s6_addr, cflare_addr6, 16);
|
|
|
|
// Ask for both a name-required, and a numeric host.
|
|
|
|
ares_getnameinfo(channel_, (const struct sockaddr*)&sockaddr, sizeof(sockaddr),
|
|
|
|
ARES_NI_LOOKUPHOST|ARES_NI_LOOKUPSERVICE|ARES_NI_UDP|ARES_NI_NUMERICHOST|ARES_NI_NAMEREQD,
|
|
|
|
NameInfoCallback, &result);
|
|
|
|
Process();
|
|
|
|
EXPECT_TRUE(result.done_);
|
|
|
|
EXPECT_EQ(ARES_EBADFLAGS, result.status_);
|
|
|
|
}
|
|
|
|
|
|
|
|
VIRT_NONVIRT_TEST_F(DefaultChannelTest, LiveGetServiceInfo) {
|
|
|
|
NameInfoResult result;
|
|
|
|
struct sockaddr_in sockaddr;
|
|
|
|
memset(&sockaddr, 0, sizeof(sockaddr));
|
|
|
|
sockaddr.sin_family = AF_INET;
|
|
|
|
sockaddr.sin_port = htons(53);
|
|
|
|
sockaddr.sin_addr.s_addr = htonl(0x08080808);
|
|
|
|
// Just look up service info
|
|
|
|
ares_getnameinfo(channel_, (const struct sockaddr*)&sockaddr, sizeof(sockaddr),
|
|
|
|
ARES_NI_LOOKUPSERVICE|ARES_NI_SCTP,
|
|
|
|
NameInfoCallback, &result);
|
|
|
|
Process();
|
|
|
|
EXPECT_TRUE(result.done_);
|
|
|
|
EXPECT_EQ(ARES_SUCCESS, result.status_);
|
|
|
|
EXPECT_EQ("", result.node_);
|
|
|
|
}
|
|
|
|
|
|
|
|
VIRT_NONVIRT_TEST_F(DefaultChannelTest, LiveGetServiceInfoNumeric) {
|
|
|
|
NameInfoResult result;
|
|
|
|
struct sockaddr_in sockaddr;
|
|
|
|
memset(&sockaddr, 0, sizeof(sockaddr));
|
|
|
|
sockaddr.sin_family = AF_INET;
|
|
|
|
sockaddr.sin_port = htons(53);
|
|
|
|
sockaddr.sin_addr.s_addr = htonl(0x08080808);
|
|
|
|
// Just look up service info
|
|
|
|
ares_getnameinfo(channel_, (const struct sockaddr*)&sockaddr, sizeof(sockaddr),
|
|
|
|
ARES_NI_LOOKUPSERVICE|ARES_NI_SCTP|ARES_NI_NUMERICSERV,
|
|
|
|
NameInfoCallback, &result);
|
|
|
|
Process();
|
|
|
|
EXPECT_TRUE(result.done_);
|
|
|
|
EXPECT_EQ(ARES_SUCCESS, result.status_);
|
|
|
|
EXPECT_EQ("", result.node_);
|
|
|
|
EXPECT_EQ("53", result.service_);
|
|
|
|
}
|
|
|
|
|
|
|
|
VIRT_NONVIRT_TEST_F(DefaultChannelTest, LiveGetNameInfoAllocFail) {
|
|
|
|
NameInfoResult result;
|
|
|
|
struct sockaddr_in sockaddr;
|
|
|
|
memset(&sockaddr, 0, sizeof(sockaddr));
|
|
|
|
sockaddr.sin_family = AF_INET;
|
|
|
|
sockaddr.sin_port = htons(53);
|
|
|
|
sockaddr.sin_addr.s_addr = htonl(0x08080808);
|
|
|
|
SetAllocFail(1);
|
|
|
|
ares_getnameinfo(channel_, (const struct sockaddr*)&sockaddr, sizeof(sockaddr),
|
|
|
|
ARES_NI_LOOKUPHOST|ARES_NI_LOOKUPSERVICE|ARES_NI_UDP,
|
|
|
|
NameInfoCallback, &result);
|
|
|
|
Process();
|
|
|
|
EXPECT_TRUE(result.done_);
|
|
|
|
EXPECT_EQ(ARES_ENOMEM, result.status_);
|
|
|
|
}
|
|
|
|
|
|
|
|
VIRT_NONVIRT_TEST_F(DefaultChannelTest, GetSock) {
|
|
|
|
ares_socket_t socks[3] = {ARES_SOCKET_BAD, ARES_SOCKET_BAD, ARES_SOCKET_BAD};
|
|
|
|
int bitmask = ares_getsock(channel_, socks, 3);
|
|
|
|
EXPECT_EQ(0, bitmask);
|
|
|
|
bitmask = ares_getsock(channel_, nullptr, 0);
|
|
|
|
EXPECT_EQ(0, bitmask);
|
|
|
|
|
|
|
|
// Ask again with a pending query.
|
|
|
|
HostResult result;
|
|
|
|
ares_gethostbyname(channel_, "www.google.com.", AF_INET, HostCallback, &result);
|
|
|
|
bitmask = ares_getsock(channel_, socks, 3);
|
|
|
|
EXPECT_NE(0, bitmask);
|
|
|
|
|
|
|
|
size_t sock_cnt = 0;
|
|
|
|
for (size_t i=0; i<3; i++) {
|
|
|
|
if (ARES_GETSOCK_READABLE(bitmask, i) || ARES_GETSOCK_WRITABLE(bitmask, i)) {
|
|
|
|
EXPECT_NE(ARES_SOCKET_BAD, socks[i]);
|
|
|
|
if (socks[i] != ARES_SOCKET_BAD)
|
|
|
|
sock_cnt++;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
EXPECT_NE((size_t)0, sock_cnt);
|
|
|
|
|
|
|
|
bitmask = ares_getsock(channel_, nullptr, 0);
|
|
|
|
EXPECT_EQ(0, bitmask);
|
|
|
|
|
|
|
|
Process();
|
|
|
|
}
|
|
|
|
|
|
|
|
TEST_F(LibraryTest, GetTCPSock) {
|
`ares_channel` -> `ares_channel_t *`: don't bury the pointer (#595)
`ares_channel` is defined as `typedef struct ares_channeldata *ares_channel;`. The problem with this, is it embeds the pointer into the typedef, which means an `ares_channel` can never be declared as `const` as if you write `const ares_channel channel`, that expands to `struct ares_channeldata * const ares_channel` and not `const struct ares_channeldata *channel`.
We will now typedef `ares_channel_t` as `typedef struct ares_channeldata ares_channel_t;`, so if you write `const ares_channel_t *channel`, it properly expands to `const struct ares_channeldata *channel`.
We are maintaining the old typedef for API compatibility with existing integrations, and due to typedef expansion this should not even cause any compiler warnings for existing code. There are no ABI implications with this change. I could be convinced to keep existing public functions as `ares_channel` if a sufficient argument exists, but internally we really need make this change for modern best practices.
This change will allow us to internally use `const ares_channel_t *` where appropriate. Whether or not we decide to change any public interfaces to use `const` may require further discussion on if there might be ABI implications (I don't think so, but I'm also not 100% sure what a compiler internally does with `const` when emitting machine code ... I think more likely ABI implications would occur going the opposite direction).
FYI, This PR was done via a combination of sed and clang-format, the only manual code change was the addition of the new typedef, and a couple doc fixes :)
Fix By: Brad House (@bradh352)
1 year ago
|
|
|
ares_channel_t *channel;
|
|
|
|
struct ares_options opts;
|
|
|
|
memset(&opts, 0, sizeof(opts));
|
|
|
|
opts.tcp_port = 53;
|
|
|
|
opts.flags = ARES_FLAG_USEVC;
|
|
|
|
int optmask = ARES_OPT_TCP_PORT | ARES_OPT_FLAGS;
|
|
|
|
EXPECT_EQ(ARES_SUCCESS, ares_init_options(&channel, &opts, optmask));
|
|
|
|
EXPECT_NE(nullptr, channel);
|
|
|
|
|
|
|
|
ares_socket_t socks[3] = {ARES_SOCKET_BAD, ARES_SOCKET_BAD, ARES_SOCKET_BAD};
|
|
|
|
int bitmask = ares_getsock(channel, socks, 3);
|
|
|
|
EXPECT_EQ(0, bitmask);
|
|
|
|
bitmask = ares_getsock(channel, nullptr, 0);
|
|
|
|
EXPECT_EQ(0, bitmask);
|
|
|
|
|
|
|
|
// Ask again with a pending query.
|
|
|
|
HostResult result;
|
|
|
|
ares_gethostbyname(channel, "www.google.com.", AF_INET, HostCallback, &result);
|
|
|
|
bitmask = ares_getsock(channel, socks, 3);
|
|
|
|
EXPECT_NE(0, bitmask);
|
|
|
|
|
|
|
|
size_t sock_cnt = 0;
|
|
|
|
for (size_t i=0; i<3; i++) {
|
|
|
|
if (ARES_GETSOCK_READABLE(bitmask, i) || ARES_GETSOCK_WRITABLE(bitmask, i)) {
|
|
|
|
EXPECT_NE(ARES_SOCKET_BAD, socks[i]);
|
|
|
|
if (socks[i] != ARES_SOCKET_BAD)
|
|
|
|
sock_cnt++;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
EXPECT_NE((size_t)0, sock_cnt);
|
|
|
|
|
|
|
|
bitmask = ares_getsock(channel, nullptr, 0);
|
|
|
|
EXPECT_EQ(0, bitmask);
|
|
|
|
|
|
|
|
ProcessWork(channel, NoExtraFDs, nullptr);
|
|
|
|
|
|
|
|
ares_destroy(channel);
|
|
|
|
}
|
|
|
|
|
|
|
|
TEST_F(DefaultChannelTest, VerifySocketFunctionCallback) {
|
|
|
|
VirtualizeIO vio(channel_);
|
|
|
|
|
|
|
|
auto my_functions = VirtualizeIO::default_functions;
|
|
|
|
size_t count = 0;
|
|
|
|
|
|
|
|
my_functions.asocket = [](int af, int type, int protocol, void * p) {
|
|
|
|
EXPECT_NE(nullptr, p);
|
|
|
|
(*reinterpret_cast<size_t *>(p))++;
|
|
|
|
return ::socket(af, type, protocol);
|
|
|
|
};
|
|
|
|
|
|
|
|
ares_set_socket_functions(channel_, &my_functions, &count);
|
|
|
|
|
|
|
|
{
|
|
|
|
count = 0;
|
|
|
|
HostResult result;
|
|
|
|
ares_gethostbyname(channel_, "www.google.com.", AF_INET, HostCallback, &result);
|
|
|
|
Process();
|
Dynamic Server List (#594)
This PR makes the server list a dynamic sorted list of servers. The sort order is [ consecutive failures, system config index ]. The server list can be updated via ares_set_servers_*(). Any queries currently directed to servers that are no longer in the list will be automatically re-queued to a different server.
Also, any time a failure occurs on the server, the sort order of the servers will be updated so that the one with the fewest consecutive failures is chosen for the next query that goes on the wire, this way bad or non-responsive servers are automatically isolated.
Since the server list is now dynamic, the tracking of query failures per server has been removed and instead is relying on the server sort order as previously described. This simplifies the logic while also reducing the amount of memory required per query. However, because of this dynamic nature, it may not be easy to determine the server attempt order for enqueued queries if there have been any failures.
If using the ARES_OPT_ROTATE, this is now implemented to be a random selection of the configured servers. Since the server list is dynamic, its not possible to go to the next server as configuration could have changed between queries or attempts for the same query.
Finally, this PR moved some existing functions into new files to logically separate them.
This should address issues #550 and #440, while also setting the framework to implement #301. #301 needs a little more effort since it configures things other than the servers themselves (domains, search, sortlist, lookups), which need to make sure they can be safely updated.
Fix By: Brad House (@bradh352)
1 year ago
|
|
|
|
|
|
|
EXPECT_TRUE(result.done_);
|
|
|
|
EXPECT_NE((size_t)0, count);
|
|
|
|
}
|
|
|
|
|
|
|
|
{
|
|
|
|
count = 0;
|
`ares_channel` -> `ares_channel_t *`: don't bury the pointer (#595)
`ares_channel` is defined as `typedef struct ares_channeldata *ares_channel;`. The problem with this, is it embeds the pointer into the typedef, which means an `ares_channel` can never be declared as `const` as if you write `const ares_channel channel`, that expands to `struct ares_channeldata * const ares_channel` and not `const struct ares_channeldata *channel`.
We will now typedef `ares_channel_t` as `typedef struct ares_channeldata ares_channel_t;`, so if you write `const ares_channel_t *channel`, it properly expands to `const struct ares_channeldata *channel`.
We are maintaining the old typedef for API compatibility with existing integrations, and due to typedef expansion this should not even cause any compiler warnings for existing code. There are no ABI implications with this change. I could be convinced to keep existing public functions as `ares_channel` if a sufficient argument exists, but internally we really need make this change for modern best practices.
This change will allow us to internally use `const ares_channel_t *` where appropriate. Whether or not we decide to change any public interfaces to use `const` may require further discussion on if there might be ABI implications (I don't think so, but I'm also not 100% sure what a compiler internally does with `const` when emitting machine code ... I think more likely ABI implications would occur going the opposite direction).
FYI, This PR was done via a combination of sed and clang-format, the only manual code change was the addition of the new typedef, and a couple doc fixes :)
Fix By: Brad House (@bradh352)
1 year ago
|
|
|
ares_channel_t *copy;
|
|
|
|
EXPECT_EQ(ARES_SUCCESS, ares_dup(©, channel_));
|
|
|
|
|
|
|
|
HostResult result;
|
|
|
|
ares_gethostbyname(copy, "www.google.com.", AF_INET, HostCallback, &result);
|
Dynamic Server List (#594)
This PR makes the server list a dynamic sorted list of servers. The sort order is [ consecutive failures, system config index ]. The server list can be updated via ares_set_servers_*(). Any queries currently directed to servers that are no longer in the list will be automatically re-queued to a different server.
Also, any time a failure occurs on the server, the sort order of the servers will be updated so that the one with the fewest consecutive failures is chosen for the next query that goes on the wire, this way bad or non-responsive servers are automatically isolated.
Since the server list is now dynamic, the tracking of query failures per server has been removed and instead is relying on the server sort order as previously described. This simplifies the logic while also reducing the amount of memory required per query. However, because of this dynamic nature, it may not be easy to determine the server attempt order for enqueued queries if there have been any failures.
If using the ARES_OPT_ROTATE, this is now implemented to be a random selection of the configured servers. Since the server list is dynamic, its not possible to go to the next server as configuration could have changed between queries or attempts for the same query.
Finally, this PR moved some existing functions into new files to logically separate them.
This should address issues #550 and #440, while also setting the framework to implement #301. #301 needs a little more effort since it configures things other than the servers themselves (domains, search, sortlist, lookups), which need to make sure they can be safely updated.
Fix By: Brad House (@bradh352)
1 year ago
|
|
|
|
|
|
|
ProcessWork(copy, NoExtraFDs, nullptr);
|
Dynamic Server List (#594)
This PR makes the server list a dynamic sorted list of servers. The sort order is [ consecutive failures, system config index ]. The server list can be updated via ares_set_servers_*(). Any queries currently directed to servers that are no longer in the list will be automatically re-queued to a different server.
Also, any time a failure occurs on the server, the sort order of the servers will be updated so that the one with the fewest consecutive failures is chosen for the next query that goes on the wire, this way bad or non-responsive servers are automatically isolated.
Since the server list is now dynamic, the tracking of query failures per server has been removed and instead is relying on the server sort order as previously described. This simplifies the logic while also reducing the amount of memory required per query. However, because of this dynamic nature, it may not be easy to determine the server attempt order for enqueued queries if there have been any failures.
If using the ARES_OPT_ROTATE, this is now implemented to be a random selection of the configured servers. Since the server list is dynamic, its not possible to go to the next server as configuration could have changed between queries or attempts for the same query.
Finally, this PR moved some existing functions into new files to logically separate them.
This should address issues #550 and #440, while also setting the framework to implement #301. #301 needs a little more effort since it configures things other than the servers themselves (domains, search, sortlist, lookups), which need to make sure they can be safely updated.
Fix By: Brad House (@bradh352)
1 year ago
|
|
|
|
|
|
|
EXPECT_TRUE(result.done_);
|
|
|
|
ares_destroy(copy);
|
|
|
|
EXPECT_NE((size_t)0, count);
|
|
|
|
}
|
|
|
|
|
|
|
|
}
|
|
|
|
|
|
|
|
TEST_F(DefaultChannelTest, LiveSetServers) {
|
|
|
|
struct ares_addr_node server1;
|
|
|
|
struct ares_addr_node server2;
|
|
|
|
server1.next = &server2;
|
|
|
|
server1.family = AF_INET;
|
|
|
|
server1.addr.addr4.s_addr = htonl(0x01020304);
|
|
|
|
server2.next = nullptr;
|
|
|
|
server2.family = AF_INET;
|
|
|
|
server2.addr.addr4.s_addr = htonl(0x02030405);
|
|
|
|
|
|
|
|
HostResult result;
|
|
|
|
ares_gethostbyname(channel_, "www.google.com.", AF_INET, HostCallback, &result);
|
Dynamic Server List (#594)
This PR makes the server list a dynamic sorted list of servers. The sort order is [ consecutive failures, system config index ]. The server list can be updated via ares_set_servers_*(). Any queries currently directed to servers that are no longer in the list will be automatically re-queued to a different server.
Also, any time a failure occurs on the server, the sort order of the servers will be updated so that the one with the fewest consecutive failures is chosen for the next query that goes on the wire, this way bad or non-responsive servers are automatically isolated.
Since the server list is now dynamic, the tracking of query failures per server has been removed and instead is relying on the server sort order as previously described. This simplifies the logic while also reducing the amount of memory required per query. However, because of this dynamic nature, it may not be easy to determine the server attempt order for enqueued queries if there have been any failures.
If using the ARES_OPT_ROTATE, this is now implemented to be a random selection of the configured servers. Since the server list is dynamic, its not possible to go to the next server as configuration could have changed between queries or attempts for the same query.
Finally, this PR moved some existing functions into new files to logically separate them.
This should address issues #550 and #440, while also setting the framework to implement #301. #301 needs a little more effort since it configures things other than the servers themselves (domains, search, sortlist, lookups), which need to make sure they can be safely updated.
Fix By: Brad House (@bradh352)
1 year ago
|
|
|
EXPECT_EQ(ARES_SUCCESS, ares_set_servers(channel_, &server1));
|
|
|
|
ares_cancel(channel_);
|
|
|
|
}
|
|
|
|
|
|
|
|
TEST_F(DefaultChannelTest, LiveSetServersPorts) {
|
|
|
|
struct ares_addr_port_node server1;
|
|
|
|
struct ares_addr_port_node server2;
|
|
|
|
server1.next = &server2;
|
|
|
|
server1.family = AF_INET;
|
|
|
|
server1.addr.addr4.s_addr = htonl(0x01020304);
|
|
|
|
server1.udp_port = 111;
|
|
|
|
server1.tcp_port = 111;
|
|
|
|
server2.next = nullptr;
|
|
|
|
server2.family = AF_INET;
|
|
|
|
server2.addr.addr4.s_addr = htonl(0x02030405);
|
|
|
|
server2.udp_port = 0;
|
|
|
|
server2.tcp_port = 0;
|
|
|
|
EXPECT_EQ(ARES_ENODATA, ares_set_servers_ports(nullptr, &server1));
|
|
|
|
|
Dynamic Server List (#594)
This PR makes the server list a dynamic sorted list of servers. The sort order is [ consecutive failures, system config index ]. The server list can be updated via ares_set_servers_*(). Any queries currently directed to servers that are no longer in the list will be automatically re-queued to a different server.
Also, any time a failure occurs on the server, the sort order of the servers will be updated so that the one with the fewest consecutive failures is chosen for the next query that goes on the wire, this way bad or non-responsive servers are automatically isolated.
Since the server list is now dynamic, the tracking of query failures per server has been removed and instead is relying on the server sort order as previously described. This simplifies the logic while also reducing the amount of memory required per query. However, because of this dynamic nature, it may not be easy to determine the server attempt order for enqueued queries if there have been any failures.
If using the ARES_OPT_ROTATE, this is now implemented to be a random selection of the configured servers. Since the server list is dynamic, its not possible to go to the next server as configuration could have changed between queries or attempts for the same query.
Finally, this PR moved some existing functions into new files to logically separate them.
This should address issues #550 and #440, while also setting the framework to implement #301. #301 needs a little more effort since it configures things other than the servers themselves (domains, search, sortlist, lookups), which need to make sure they can be safely updated.
Fix By: Brad House (@bradh352)
1 year ago
|
|
|
// Change while pending will requeue any requests to new servers
|
|
|
|
HostResult result;
|
|
|
|
ares_gethostbyname(channel_, "www.google.com.", AF_INET, HostCallback, &result);
|
Dynamic Server List (#594)
This PR makes the server list a dynamic sorted list of servers. The sort order is [ consecutive failures, system config index ]. The server list can be updated via ares_set_servers_*(). Any queries currently directed to servers that are no longer in the list will be automatically re-queued to a different server.
Also, any time a failure occurs on the server, the sort order of the servers will be updated so that the one with the fewest consecutive failures is chosen for the next query that goes on the wire, this way bad or non-responsive servers are automatically isolated.
Since the server list is now dynamic, the tracking of query failures per server has been removed and instead is relying on the server sort order as previously described. This simplifies the logic while also reducing the amount of memory required per query. However, because of this dynamic nature, it may not be easy to determine the server attempt order for enqueued queries if there have been any failures.
If using the ARES_OPT_ROTATE, this is now implemented to be a random selection of the configured servers. Since the server list is dynamic, its not possible to go to the next server as configuration could have changed between queries or attempts for the same query.
Finally, this PR moved some existing functions into new files to logically separate them.
This should address issues #550 and #440, while also setting the framework to implement #301. #301 needs a little more effort since it configures things other than the servers themselves (domains, search, sortlist, lookups), which need to make sure they can be safely updated.
Fix By: Brad House (@bradh352)
1 year ago
|
|
|
EXPECT_EQ(ARES_SUCCESS, ares_set_servers_ports(channel_, &server1));
|
|
|
|
ares_cancel(channel_);
|
|
|
|
}
|
|
|
|
|
|
|
|
TEST_F(DefaultChannelTest, LiveSetServersCSV) {
|
|
|
|
HostResult result;
|
|
|
|
ares_gethostbyname(channel_, "www.google.com.", AF_INET, HostCallback, &result);
|
Dynamic Server List (#594)
This PR makes the server list a dynamic sorted list of servers. The sort order is [ consecutive failures, system config index ]. The server list can be updated via ares_set_servers_*(). Any queries currently directed to servers that are no longer in the list will be automatically re-queued to a different server.
Also, any time a failure occurs on the server, the sort order of the servers will be updated so that the one with the fewest consecutive failures is chosen for the next query that goes on the wire, this way bad or non-responsive servers are automatically isolated.
Since the server list is now dynamic, the tracking of query failures per server has been removed and instead is relying on the server sort order as previously described. This simplifies the logic while also reducing the amount of memory required per query. However, because of this dynamic nature, it may not be easy to determine the server attempt order for enqueued queries if there have been any failures.
If using the ARES_OPT_ROTATE, this is now implemented to be a random selection of the configured servers. Since the server list is dynamic, its not possible to go to the next server as configuration could have changed between queries or attempts for the same query.
Finally, this PR moved some existing functions into new files to logically separate them.
This should address issues #550 and #440, while also setting the framework to implement #301. #301 needs a little more effort since it configures things other than the servers themselves (domains, search, sortlist, lookups), which need to make sure they can be safely updated.
Fix By: Brad House (@bradh352)
1 year ago
|
|
|
// Change while pending will requeue any requests to new servers
|
|
|
|
EXPECT_EQ(ARES_SUCCESS, ares_set_servers_csv(channel_, "1.2.3.4,2.3.4.5"));
|
|
|
|
EXPECT_EQ(ARES_SUCCESS, ares_set_servers_ports_csv(channel_, "1.2.3.4:56,2.3.4.5:67"));
|
|
|
|
ares_cancel(channel_);
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
} // namespace test
|
|
|
|
} // namespace ares
|