|
|
|
/*
|
|
|
|
* Copyright (C) The c-ares project
|
|
|
|
*
|
|
|
|
* Permission to use, copy, modify, and distribute this
|
|
|
|
* software and its documentation for any purpose and without
|
|
|
|
* fee is hereby granted, provided that the above copyright
|
|
|
|
* notice appear in all copies and that both that copyright
|
|
|
|
* notice and this permission notice appear in supporting
|
|
|
|
* documentation, and that the name of M.I.T. not be used in
|
|
|
|
* advertising or publicity pertaining to distribution of the
|
|
|
|
* software without specific, written prior permission.
|
|
|
|
* M.I.T. makes no representations about the suitability of
|
|
|
|
* this software for any purpose. It is provided "as is"
|
|
|
|
* without express or implied warranty.
|
|
|
|
*
|
|
|
|
* SPDX-License-Identifier: MIT
|
|
|
|
*/
|
|
|
|
// -*- mode: c++ -*-
|
|
|
|
#ifndef ARES_TEST_H
|
|
|
|
#define ARES_TEST_H
|
|
|
|
|
|
|
|
#include "ares_setup.h"
|
Autotools: rework to simplify and fix recent issues (#674)
Completely rework the autotools build system, issues have cropped up due to the complexity and could cause issues on even semi-modern Linux systems (Ubuntu 20.04 for example).
Changes include:
Remove all curl/xc/cares m4 helper files, they go overboard on detections of functions and datatypes. Go back to more plain autoconf macros as they've come a long way over the years.
Use known systems and heuristics to determine datatypes for functions like send() and recv(), rather than the error prone detection which required thousands of permutations and might still get it wrong.
Remove unneeded configure arguments like --enable-debug or --enable-optimize, its more common for people to simply pass their own CFLAGS on the command line.
Only require CARES_STATICLIB definition on Windows static builds, its not necessary ever for other systems, even when hiding non-public symbols.
Remove some function and definition detections that were never used in c-ares
The test framework is now embedded into the toplevel configure system, there was no need to chain build the test system as it is never built externally to c-ares.
As a side-effect of the changes, a configure run completes in about 25% of the original time.
This has been tested on various Linux distributions (of varying age), FreeBSD, MacOS, Windows (via MSYS2 with Mingw), and Solaris10/11 (by @dfandrich), AIX 7.3 (by @dfandrich). It is not unlikely that this may have broken more esoteric or legacy systems, and we'll likely need to be ready to accept bug reports and patches, but it has removed over 10k lines of build system code. It is very likely any issues that crop up will add far fewer lines of code to fix such systems.
Fixes Bug: #670
Fix By: Brad House (@bradh352)
11 months ago
|
|
|
#ifdef HAVE_CONFIG_H
|
|
|
|
#include "ares_config.h"
|
|
|
|
#endif
|
|
|
|
|
|
|
|
#include "dns-proto.h"
|
|
|
|
// Include ares internal file for DNS protocol constants
|
|
|
|
#include "ares_nameser.h"
|
|
|
|
|
|
|
|
#include "gtest/gtest.h"
|
|
|
|
#include "gmock/gmock.h"
|
|
|
|
|
|
|
|
#if defined(HAVE_USER_NAMESPACE) && defined(HAVE_UTS_NAMESPACE)
|
|
|
|
# define HAVE_CONTAINER
|
|
|
|
#endif
|
|
|
|
|
|
|
|
#include <functional>
|
|
|
|
#include <list>
|
|
|
|
#include <map>
|
|
|
|
#include <memory>
|
|
|
|
#include <set>
|
|
|
|
#include <string>
|
|
|
|
#include <utility>
|
|
|
|
#include <vector>
|
|
|
|
|
|
|
|
namespace ares {
|
|
|
|
|
|
|
|
typedef unsigned char byte;
|
|
|
|
|
|
|
|
namespace test {
|
|
|
|
|
|
|
|
extern bool verbose;
|
|
|
|
extern unsigned short mock_port;
|
|
|
|
extern const std::vector<int> both_families;
|
|
|
|
extern const std::vector<int> ipv4_family;
|
|
|
|
extern const std::vector<int> ipv6_family;
|
|
|
|
|
|
|
|
extern const std::vector<std::pair<int, bool>> both_families_both_modes;
|
|
|
|
extern const std::vector<std::pair<int, bool>> ipv4_family_both_modes;
|
|
|
|
extern const std::vector<std::pair<int, bool>> ipv6_family_both_modes;
|
|
|
|
|
|
|
|
// Which parameters to use in tests
|
|
|
|
extern std::vector<int> families;
|
|
|
|
extern std::vector<std::pair<int, bool>> families_modes;
|
|
|
|
|
|
|
|
// Process all pending work on ares-owned file descriptors, plus
|
|
|
|
// optionally the given set-of-FDs + work function.
|
|
|
|
void ProcessWork(ares_channel_t *channel,
|
|
|
|
std::function<std::set<ares_socket_t>()> get_extrafds,
|
|
|
|
std::function<void(ares_socket_t)> process_extra,
|
|
|
|
unsigned int cancel_ms = 0);
|
|
|
|
std::set<ares_socket_t> NoExtraFDs();
|
|
|
|
|
|
|
|
// Test fixture that ensures library initialization, and allows
|
|
|
|
// memory allocations to be failed.
|
|
|
|
class LibraryTest : public ::testing::Test {
|
|
|
|
public:
|
|
|
|
LibraryTest()
|
|
|
|
{
|
|
|
|
EXPECT_EQ(ARES_SUCCESS, ares_library_init_mem(
|
|
|
|
ARES_LIB_INIT_ALL, &LibraryTest::amalloc,
|
|
|
|
&LibraryTest::afree, &LibraryTest::arealloc));
|
|
|
|
}
|
|
|
|
|
|
|
|
~LibraryTest()
|
|
|
|
{
|
|
|
|
ares_library_cleanup();
|
|
|
|
ClearFails();
|
|
|
|
}
|
|
|
|
|
|
|
|
// Set the n-th malloc call (of any size) from the library to fail.
|
|
|
|
// (nth == 1 means the next call)
|
|
|
|
static void SetAllocFail(int nth);
|
|
|
|
// Set the next malloc call for the given size to fail.
|
|
|
|
static void SetAllocSizeFail(size_t size);
|
|
|
|
// Remove any pending alloc failures.
|
|
|
|
static void ClearFails();
|
|
|
|
|
|
|
|
static void *amalloc(size_t size);
|
|
|
|
static void *arealloc(void *ptr, size_t size);
|
|
|
|
static void afree(void *ptr);
|
|
|
|
|
|
|
|
private:
|
|
|
|
static bool ShouldAllocFail(size_t size);
|
|
|
|
static unsigned long long fails_;
|
|
|
|
static std::map<size_t, int> size_fails_;
|
|
|
|
};
|
|
|
|
|
|
|
|
// Test fixture that uses a default channel.
|
|
|
|
class DefaultChannelTest : public LibraryTest {
|
|
|
|
public:
|
|
|
|
DefaultChannelTest() : channel_(nullptr)
|
|
|
|
{
|
Query Cache support (#625)
This PR implements a query cache at the lowest possible level, the actual dns request and response messages. Only successful and `NXDOMAIN` responses are cached. The lowest TTL in the response message determines the cache validity period for the response, and is capped at the configuration value for `qcache_max_ttl`. For `NXDOMAIN` responses, the SOA record is evaluated.
For a query to match the cache, the opcode, flags, and each question's class, type, and name are all evaluated. This is to prevent matching a cached entry for a subtly different query (such as if the RD flag is set on one request and not another).
For things like ares_getaddrinfo() or ares_search() that may spawn multiple queries, each individual message received is cached rather than the overarching response. This makes it possible for one query in the sequence to be purged from the cache while others still return cached results which means there is no chance of ever returning stale data.
We have had a lot of user requests to return TTLs on all the various parsers like `ares_parse_caa_reply()`, and likely this is because they want to implement caching mechanisms of their own, thus this PR should solve those issues as well.
Due to the internal data structures we have these days, this PR is less than 500 lines of new code.
Fixes #608
Fix By: Brad House (@bradh352)
1 year ago
|
|
|
/* Enable query cache for live tests */
|
|
|
|
struct ares_options opts;
|
|
|
|
memset(&opts, 0, sizeof(opts));
|
|
|
|
opts.qcache_max_ttl = 300;
|
|
|
|
int optmask = ARES_OPT_QUERY_CACHE;
|
Query Cache support (#625)
This PR implements a query cache at the lowest possible level, the actual dns request and response messages. Only successful and `NXDOMAIN` responses are cached. The lowest TTL in the response message determines the cache validity period for the response, and is capped at the configuration value for `qcache_max_ttl`. For `NXDOMAIN` responses, the SOA record is evaluated.
For a query to match the cache, the opcode, flags, and each question's class, type, and name are all evaluated. This is to prevent matching a cached entry for a subtly different query (such as if the RD flag is set on one request and not another).
For things like ares_getaddrinfo() or ares_search() that may spawn multiple queries, each individual message received is cached rather than the overarching response. This makes it possible for one query in the sequence to be purged from the cache while others still return cached results which means there is no chance of ever returning stale data.
We have had a lot of user requests to return TTLs on all the various parsers like `ares_parse_caa_reply()`, and likely this is because they want to implement caching mechanisms of their own, thus this PR should solve those issues as well.
Due to the internal data structures we have these days, this PR is less than 500 lines of new code.
Fixes #608
Fix By: Brad House (@bradh352)
1 year ago
|
|
|
EXPECT_EQ(ARES_SUCCESS, ares_init_options(&channel_, &opts, optmask));
|
|
|
|
EXPECT_NE(nullptr, channel_);
|
|
|
|
}
|
|
|
|
|
|
|
|
~DefaultChannelTest()
|
|
|
|
{
|
|
|
|
ares_destroy(channel_);
|
|
|
|
channel_ = nullptr;
|
|
|
|
}
|
|
|
|
|
|
|
|
// Process all pending work on ares-owned file descriptors.
|
|
|
|
void Process(unsigned int cancel_ms = 0);
|
|
|
|
|
|
|
|
protected:
|
`ares_channel` -> `ares_channel_t *`: don't bury the pointer (#595)
`ares_channel` is defined as `typedef struct ares_channeldata *ares_channel;`. The problem with this, is it embeds the pointer into the typedef, which means an `ares_channel` can never be declared as `const` as if you write `const ares_channel channel`, that expands to `struct ares_channeldata * const ares_channel` and not `const struct ares_channeldata *channel`.
We will now typedef `ares_channel_t` as `typedef struct ares_channeldata ares_channel_t;`, so if you write `const ares_channel_t *channel`, it properly expands to `const struct ares_channeldata *channel`.
We are maintaining the old typedef for API compatibility with existing integrations, and due to typedef expansion this should not even cause any compiler warnings for existing code. There are no ABI implications with this change. I could be convinced to keep existing public functions as `ares_channel` if a sufficient argument exists, but internally we really need make this change for modern best practices.
This change will allow us to internally use `const ares_channel_t *` where appropriate. Whether or not we decide to change any public interfaces to use `const` may require further discussion on if there might be ABI implications (I don't think so, but I'm also not 100% sure what a compiler internally does with `const` when emitting machine code ... I think more likely ABI implications would occur going the opposite direction).
FYI, This PR was done via a combination of sed and clang-format, the only manual code change was the addition of the new typedef, and a couple doc fixes :)
Fix By: Brad House (@bradh352)
1 year ago
|
|
|
ares_channel_t *channel_;
|
|
|
|
};
|
|
|
|
|
Replace hosts parser, add caching capabilities (#591)
HOSTS FILE PROCESSING OVERVIEW
==============================
The hosts file on the system contains static entries to be processed locally
rather than querying the nameserver. Each row is an IP address followed by
a list of space delimited hostnames that match the ip address. This is used
for both forward and reverse lookups.
We are caching the entire parsed hosts file for performance reasons. Some
files may be quite sizable and as per Issue #458 can approach 1/2MB in size,
and the parse overhead on a rapid succession of queries can be quite large.
The entries are stored in forwards and backwards hashtables so we can get
O(1) performance on lookup. The file is cached until the file modification
timestamp changes (or 60s if there is no implemented stat() capability).
The hosts file processing is quite unique. It has to merge all related hosts
and ips into a single entry due to file formatting requirements. For
instance take the below:
```
127.0.0.1 localhost.localdomain localhost
::1 localhost.localdomain localhost
192.168.1.1 host.example.com host
192.168.1.5 host.example.com host
2620:1234::1 host.example.com host6.example.com host6 host
```
This will yield 2 entries.
1) ips: `127.0.0.1,::1`
hosts: `localhost.localdomain,localhost`
2) ips: `192.168.1.1,192.168.1.5,2620:1234::1`
hosts: `host.example.com,host,host6.example.com,host6`
It could be argued that if searching for `192.168.1.1` that the `host6`
hostnames should not be returned, but this implementation will return them
since they are related (both ips have the fqdn of host.example.com). It is
unlikely this will matter in the real world.
Fix By: Brad House (@bradh352)
1 year ago
|
|
|
// Test fixture that uses a file-only channel.
|
|
|
|
class FileChannelTest : public LibraryTest {
|
|
|
|
public:
|
|
|
|
FileChannelTest() : channel_(nullptr)
|
|
|
|
{
|
|
|
|
struct ares_options opts;
|
|
|
|
memset(&opts, 0, sizeof(opts));
|
|
|
|
opts.lookups = strdup("f");
|
|
|
|
int optmask = ARES_OPT_LOOKUPS;
|
Replace hosts parser, add caching capabilities (#591)
HOSTS FILE PROCESSING OVERVIEW
==============================
The hosts file on the system contains static entries to be processed locally
rather than querying the nameserver. Each row is an IP address followed by
a list of space delimited hostnames that match the ip address. This is used
for both forward and reverse lookups.
We are caching the entire parsed hosts file for performance reasons. Some
files may be quite sizable and as per Issue #458 can approach 1/2MB in size,
and the parse overhead on a rapid succession of queries can be quite large.
The entries are stored in forwards and backwards hashtables so we can get
O(1) performance on lookup. The file is cached until the file modification
timestamp changes (or 60s if there is no implemented stat() capability).
The hosts file processing is quite unique. It has to merge all related hosts
and ips into a single entry due to file formatting requirements. For
instance take the below:
```
127.0.0.1 localhost.localdomain localhost
::1 localhost.localdomain localhost
192.168.1.1 host.example.com host
192.168.1.5 host.example.com host
2620:1234::1 host.example.com host6.example.com host6 host
```
This will yield 2 entries.
1) ips: `127.0.0.1,::1`
hosts: `localhost.localdomain,localhost`
2) ips: `192.168.1.1,192.168.1.5,2620:1234::1`
hosts: `host.example.com,host,host6.example.com,host6`
It could be argued that if searching for `192.168.1.1` that the `host6`
hostnames should not be returned, but this implementation will return them
since they are related (both ips have the fqdn of host.example.com). It is
unlikely this will matter in the real world.
Fix By: Brad House (@bradh352)
1 year ago
|
|
|
EXPECT_EQ(ARES_SUCCESS, ares_init_options(&channel_, &opts, optmask));
|
|
|
|
EXPECT_NE(nullptr, channel_);
|
|
|
|
free(opts.lookups);
|
|
|
|
}
|
|
|
|
|
|
|
|
~FileChannelTest()
|
|
|
|
{
|
|
|
|
ares_destroy(channel_);
|
|
|
|
channel_ = nullptr;
|
|
|
|
}
|
|
|
|
|
|
|
|
// Process all pending work on ares-owned file descriptors.
|
|
|
|
void Process(unsigned int cancel_ms = 0);
|
Replace hosts parser, add caching capabilities (#591)
HOSTS FILE PROCESSING OVERVIEW
==============================
The hosts file on the system contains static entries to be processed locally
rather than querying the nameserver. Each row is an IP address followed by
a list of space delimited hostnames that match the ip address. This is used
for both forward and reverse lookups.
We are caching the entire parsed hosts file for performance reasons. Some
files may be quite sizable and as per Issue #458 can approach 1/2MB in size,
and the parse overhead on a rapid succession of queries can be quite large.
The entries are stored in forwards and backwards hashtables so we can get
O(1) performance on lookup. The file is cached until the file modification
timestamp changes (or 60s if there is no implemented stat() capability).
The hosts file processing is quite unique. It has to merge all related hosts
and ips into a single entry due to file formatting requirements. For
instance take the below:
```
127.0.0.1 localhost.localdomain localhost
::1 localhost.localdomain localhost
192.168.1.1 host.example.com host
192.168.1.5 host.example.com host
2620:1234::1 host.example.com host6.example.com host6 host
```
This will yield 2 entries.
1) ips: `127.0.0.1,::1`
hosts: `localhost.localdomain,localhost`
2) ips: `192.168.1.1,192.168.1.5,2620:1234::1`
hosts: `host.example.com,host,host6.example.com,host6`
It could be argued that if searching for `192.168.1.1` that the `host6`
hostnames should not be returned, but this implementation will return them
since they are related (both ips have the fqdn of host.example.com). It is
unlikely this will matter in the real world.
Fix By: Brad House (@bradh352)
1 year ago
|
|
|
|
|
|
|
protected:
|
`ares_channel` -> `ares_channel_t *`: don't bury the pointer (#595)
`ares_channel` is defined as `typedef struct ares_channeldata *ares_channel;`. The problem with this, is it embeds the pointer into the typedef, which means an `ares_channel` can never be declared as `const` as if you write `const ares_channel channel`, that expands to `struct ares_channeldata * const ares_channel` and not `const struct ares_channeldata *channel`.
We will now typedef `ares_channel_t` as `typedef struct ares_channeldata ares_channel_t;`, so if you write `const ares_channel_t *channel`, it properly expands to `const struct ares_channeldata *channel`.
We are maintaining the old typedef for API compatibility with existing integrations, and due to typedef expansion this should not even cause any compiler warnings for existing code. There are no ABI implications with this change. I could be convinced to keep existing public functions as `ares_channel` if a sufficient argument exists, but internally we really need make this change for modern best practices.
This change will allow us to internally use `const ares_channel_t *` where appropriate. Whether or not we decide to change any public interfaces to use `const` may require further discussion on if there might be ABI implications (I don't think so, but I'm also not 100% sure what a compiler internally does with `const` when emitting machine code ... I think more likely ABI implications would occur going the opposite direction).
FYI, This PR was done via a combination of sed and clang-format, the only manual code change was the addition of the new typedef, and a couple doc fixes :)
Fix By: Brad House (@bradh352)
1 year ago
|
|
|
ares_channel_t *channel_;
|
Replace hosts parser, add caching capabilities (#591)
HOSTS FILE PROCESSING OVERVIEW
==============================
The hosts file on the system contains static entries to be processed locally
rather than querying the nameserver. Each row is an IP address followed by
a list of space delimited hostnames that match the ip address. This is used
for both forward and reverse lookups.
We are caching the entire parsed hosts file for performance reasons. Some
files may be quite sizable and as per Issue #458 can approach 1/2MB in size,
and the parse overhead on a rapid succession of queries can be quite large.
The entries are stored in forwards and backwards hashtables so we can get
O(1) performance on lookup. The file is cached until the file modification
timestamp changes (or 60s if there is no implemented stat() capability).
The hosts file processing is quite unique. It has to merge all related hosts
and ips into a single entry due to file formatting requirements. For
instance take the below:
```
127.0.0.1 localhost.localdomain localhost
::1 localhost.localdomain localhost
192.168.1.1 host.example.com host
192.168.1.5 host.example.com host
2620:1234::1 host.example.com host6.example.com host6 host
```
This will yield 2 entries.
1) ips: `127.0.0.1,::1`
hosts: `localhost.localdomain,localhost`
2) ips: `192.168.1.1,192.168.1.5,2620:1234::1`
hosts: `host.example.com,host,host6.example.com,host6`
It could be argued that if searching for `192.168.1.1` that the `host6`
hostnames should not be returned, but this implementation will return them
since they are related (both ips have the fqdn of host.example.com). It is
unlikely this will matter in the real world.
Fix By: Brad House (@bradh352)
1 year ago
|
|
|
};
|
|
|
|
|
|
|
|
// Test fixture that uses a default channel with the specified lookup mode.
|
|
|
|
class DefaultChannelModeTest
|
|
|
|
: public LibraryTest,
|
|
|
|
public ::testing::WithParamInterface<std::string> {
|
|
|
|
public:
|
|
|
|
DefaultChannelModeTest() : channel_(nullptr)
|
|
|
|
{
|
|
|
|
struct ares_options opts;
|
|
|
|
memset(&opts, 0, sizeof(opts));
|
|
|
|
opts.lookups = strdup(GetParam().c_str());
|
|
|
|
int optmask = ARES_OPT_LOOKUPS;
|
|
|
|
EXPECT_EQ(ARES_SUCCESS, ares_init_options(&channel_, &opts, optmask));
|
|
|
|
EXPECT_NE(nullptr, channel_);
|
|
|
|
free(opts.lookups);
|
|
|
|
}
|
|
|
|
|
|
|
|
~DefaultChannelModeTest()
|
|
|
|
{
|
|
|
|
ares_destroy(channel_);
|
|
|
|
channel_ = nullptr;
|
|
|
|
}
|
|
|
|
|
|
|
|
// Process all pending work on ares-owned file descriptors.
|
|
|
|
void Process(unsigned int cancel_ms = 0);
|
|
|
|
|
|
|
|
protected:
|
`ares_channel` -> `ares_channel_t *`: don't bury the pointer (#595)
`ares_channel` is defined as `typedef struct ares_channeldata *ares_channel;`. The problem with this, is it embeds the pointer into the typedef, which means an `ares_channel` can never be declared as `const` as if you write `const ares_channel channel`, that expands to `struct ares_channeldata * const ares_channel` and not `const struct ares_channeldata *channel`.
We will now typedef `ares_channel_t` as `typedef struct ares_channeldata ares_channel_t;`, so if you write `const ares_channel_t *channel`, it properly expands to `const struct ares_channeldata *channel`.
We are maintaining the old typedef for API compatibility with existing integrations, and due to typedef expansion this should not even cause any compiler warnings for existing code. There are no ABI implications with this change. I could be convinced to keep existing public functions as `ares_channel` if a sufficient argument exists, but internally we really need make this change for modern best practices.
This change will allow us to internally use `const ares_channel_t *` where appropriate. Whether or not we decide to change any public interfaces to use `const` may require further discussion on if there might be ABI implications (I don't think so, but I'm also not 100% sure what a compiler internally does with `const` when emitting machine code ... I think more likely ABI implications would occur going the opposite direction).
FYI, This PR was done via a combination of sed and clang-format, the only manual code change was the addition of the new typedef, and a couple doc fixes :)
Fix By: Brad House (@bradh352)
1 year ago
|
|
|
ares_channel_t *channel_;
|
|
|
|
};
|
|
|
|
|
|
|
|
// Mock DNS server to allow responses to be scripted by tests.
|
|
|
|
class MockServer {
|
|
|
|
public:
|
|
|
|
MockServer(int family, unsigned short port);
|
|
|
|
~MockServer();
|
|
|
|
|
|
|
|
// Mock method indicating the processing of a particular <name, RRtype>
|
|
|
|
// request.
|
|
|
|
MOCK_METHOD2(OnRequest, void(const std::string &name, int rrtype));
|
|
|
|
|
|
|
|
// Set the reply to be sent next; the query ID field will be overwritten
|
|
|
|
// with the value from the request.
|
|
|
|
void SetReplyData(const std::vector<byte> &reply)
|
|
|
|
{
|
|
|
|
reply_ = reply;
|
|
|
|
}
|
|
|
|
|
|
|
|
void SetReply(const DNSPacket *reply)
|
|
|
|
{
|
|
|
|
SetReplyData(reply->data());
|
|
|
|
}
|
|
|
|
|
|
|
|
void SetReplyQID(int qid)
|
|
|
|
{
|
|
|
|
qid_ = qid;
|
|
|
|
}
|
|
|
|
|
|
|
|
void Disconnect()
|
|
|
|
{
|
|
|
|
for (ares_socket_t fd : connfds_) {
|
|
|
|
sclose(fd);
|
|
|
|
}
|
|
|
|
connfds_.clear();
|
|
|
|
free(tcp_data_);
|
|
|
|
tcp_data_ = NULL;
|
|
|
|
tcp_data_len_ = 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
// The set of file descriptors that the server handles.
|
|
|
|
std::set<ares_socket_t> fds() const;
|
|
|
|
|
|
|
|
// Process activity on a file descriptor.
|
|
|
|
void ProcessFD(ares_socket_t fd);
|
|
|
|
|
|
|
|
// Ports the server is responding to
|
|
|
|
unsigned short udpport() const
|
|
|
|
{
|
|
|
|
return udpport_;
|
|
|
|
}
|
|
|
|
|
|
|
|
unsigned short tcpport() const
|
|
|
|
{
|
|
|
|
return tcpport_;
|
|
|
|
}
|
|
|
|
|
|
|
|
private:
|
|
|
|
void ProcessRequest(ares_socket_t fd, struct sockaddr_storage *addr,
|
|
|
|
ares_socklen_t addrlen, int qid, const std::string &name,
|
|
|
|
int rrtype);
|
|
|
|
void ProcessPacket(ares_socket_t fd, struct sockaddr_storage *addr,
|
|
|
|
ares_socklen_t addrlen, byte *data, int len);
|
|
|
|
unsigned short udpport_;
|
|
|
|
unsigned short tcpport_;
|
|
|
|
ares_socket_t udpfd_;
|
|
|
|
ares_socket_t tcpfd_;
|
|
|
|
std::set<ares_socket_t> connfds_;
|
|
|
|
std::vector<byte> reply_;
|
|
|
|
int qid_;
|
|
|
|
unsigned char *tcp_data_;
|
|
|
|
size_t tcp_data_len_;
|
|
|
|
};
|
|
|
|
|
|
|
|
// Test fixture that uses a mock DNS server.
|
|
|
|
class MockChannelOptsTest : public LibraryTest {
|
|
|
|
public:
|
|
|
|
MockChannelOptsTest(int count, int family, bool force_tcp,
|
|
|
|
struct ares_options *givenopts, int optmask);
|
|
|
|
~MockChannelOptsTest();
|
|
|
|
|
|
|
|
// Process all pending work on ares-owned and mock-server-owned file
|
|
|
|
// descriptors.
|
|
|
|
void Process(unsigned int cancel_ms = 0);
|
|
|
|
|
|
|
|
protected:
|
|
|
|
// NiceMockServer doesn't complain about uninteresting calls.
|
|
|
|
typedef testing::NiceMock<MockServer> NiceMockServer;
|
|
|
|
typedef std::vector<std::unique_ptr<NiceMockServer>> NiceMockServers;
|
|
|
|
|
|
|
|
std::set<ares_socket_t> fds() const;
|
|
|
|
void ProcessFD(ares_socket_t fd);
|
|
|
|
|
|
|
|
static NiceMockServers BuildServers(int count, int family,
|
|
|
|
unsigned short base_port);
|
|
|
|
|
|
|
|
NiceMockServers servers_;
|
|
|
|
// Convenience reference to first server.
|
|
|
|
NiceMockServer &server_;
|
|
|
|
ares_channel_t *channel_;
|
|
|
|
};
|
|
|
|
|
|
|
|
class MockChannelTest
|
|
|
|
: public MockChannelOptsTest,
|
|
|
|
public ::testing::WithParamInterface<std::pair<int, bool>> {
|
|
|
|
public:
|
|
|
|
MockChannelTest()
|
|
|
|
: MockChannelOptsTest(1, GetParam().first, GetParam().second, nullptr, 0)
|
|
|
|
{
|
|
|
|
}
|
|
|
|
};
|
|
|
|
|
|
|
|
class MockUDPChannelTest : public MockChannelOptsTest,
|
|
|
|
public ::testing::WithParamInterface<int> {
|
|
|
|
public:
|
|
|
|
MockUDPChannelTest() : MockChannelOptsTest(1, GetParam(), false, nullptr, 0)
|
|
|
|
{
|
|
|
|
}
|
|
|
|
};
|
|
|
|
|
|
|
|
class MockTCPChannelTest : public MockChannelOptsTest,
|
|
|
|
public ::testing::WithParamInterface<int> {
|
|
|
|
public:
|
|
|
|
MockTCPChannelTest() : MockChannelOptsTest(1, GetParam(), true, nullptr, 0)
|
|
|
|
{
|
|
|
|
}
|
|
|
|
};
|
|
|
|
|
|
|
|
// gMock action to set the reply for a mock server.
|
|
|
|
ACTION_P2(SetReplyData, mockserver, data)
|
|
|
|
{
|
|
|
|
mockserver->SetReplyData(data);
|
|
|
|
}
|
|
|
|
|
|
|
|
ACTION_P2(SetReply, mockserver, reply)
|
|
|
|
{
|
|
|
|
mockserver->SetReply(reply);
|
|
|
|
}
|
|
|
|
|
|
|
|
ACTION_P2(SetReplyQID, mockserver, qid)
|
|
|
|
{
|
|
|
|
mockserver->SetReplyQID(qid);
|
|
|
|
}
|
|
|
|
|
|
|
|
// gMock action to cancel a channel.
|
|
|
|
ACTION_P2(CancelChannel, mockserver, channel)
|
|
|
|
{
|
|
|
|
ares_cancel(channel);
|
|
|
|
}
|
|
|
|
|
|
|
|
// gMock action to disconnect all connections.
|
|
|
|
ACTION_P(Disconnect, mockserver)
|
|
|
|
{
|
|
|
|
mockserver->Disconnect();
|
|
|
|
}
|
|
|
|
|
|
|
|
// C++ wrapper for struct hostent.
|
|
|
|
struct HostEnt {
|
|
|
|
HostEnt() : addrtype_(-1)
|
|
|
|
{
|
|
|
|
}
|
|
|
|
|
|
|
|
HostEnt(const struct hostent *hostent);
|
|
|
|
std::string name_;
|
|
|
|
std::vector<std::string> aliases_;
|
|
|
|
int addrtype_; // AF_INET or AF_INET6
|
|
|
|
std::vector<std::string> addrs_;
|
|
|
|
};
|
|
|
|
|
|
|
|
std::ostream &operator<<(std::ostream &os, const HostEnt &result);
|
|
|
|
|
|
|
|
// Structure that describes the result of an ares_host_callback invocation.
|
|
|
|
struct HostResult {
|
|
|
|
HostResult() : done_(false), status_(0), timeouts_(0)
|
|
|
|
{
|
|
|
|
}
|
|
|
|
|
|
|
|
// Whether the callback has been invoked.
|
|
|
|
bool done_;
|
|
|
|
// Explicitly provided result information.
|
|
|
|
int status_;
|
|
|
|
int timeouts_;
|
|
|
|
// Contents of the hostent structure, if provided.
|
|
|
|
HostEnt host_;
|
|
|
|
};
|
|
|
|
|
|
|
|
std::ostream &operator<<(std::ostream &os, const HostResult &result);
|
|
|
|
|
|
|
|
// Structure that describes the result of an ares_callback invocation.
|
|
|
|
struct SearchResult {
|
|
|
|
// Whether the callback has been invoked.
|
|
|
|
bool done_;
|
|
|
|
// Explicitly provided result information.
|
|
|
|
int status_;
|
|
|
|
int timeouts_;
|
|
|
|
std::vector<byte> data_;
|
|
|
|
};
|
|
|
|
|
|
|
|
std::ostream &operator<<(std::ostream &os, const SearchResult &result);
|
|
|
|
|
|
|
|
// Structure that describes the result of an ares_nameinfo_callback invocation.
|
|
|
|
struct NameInfoResult {
|
|
|
|
// Whether the callback has been invoked.
|
|
|
|
bool done_;
|
|
|
|
// Explicitly provided result information.
|
|
|
|
int status_;
|
|
|
|
int timeouts_;
|
|
|
|
std::string node_;
|
|
|
|
std::string service_;
|
|
|
|
};
|
|
|
|
|
|
|
|
std::ostream &operator<<(std::ostream &os, const NameInfoResult &result);
|
|
|
|
|
|
|
|
struct AddrInfoDeleter {
|
|
|
|
void operator()(ares_addrinfo *ptr)
|
|
|
|
{
|
|
|
|
if (ptr) {
|
|
|
|
ares_freeaddrinfo(ptr);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
};
|
|
|
|
|
|
|
|
// C++ wrapper for struct ares_addrinfo.
|
|
|
|
using AddrInfo = std::unique_ptr<ares_addrinfo, AddrInfoDeleter>;
|
|
|
|
|
|
|
|
std::ostream &operator<<(std::ostream &os, const AddrInfo &result);
|
|
|
|
|
|
|
|
// Structure that describes the result of an ares_addrinfo_callback invocation.
|
|
|
|
struct AddrInfoResult {
|
|
|
|
AddrInfoResult() : done_(false), status_(-1), timeouts_(0)
|
|
|
|
{
|
|
|
|
}
|
|
|
|
|
|
|
|
// Whether the callback has been invoked.
|
|
|
|
bool done_;
|
|
|
|
// Explicitly provided result information.
|
|
|
|
int status_;
|
|
|
|
int timeouts_;
|
|
|
|
// Contents of the ares_addrinfo structure, if provided.
|
|
|
|
AddrInfo ai_;
|
|
|
|
};
|
|
|
|
|
|
|
|
std::ostream &operator<<(std::ostream &os, const AddrInfoResult &result);
|
|
|
|
|
|
|
|
// Standard implementation of ares callbacks that fill out the corresponding
|
|
|
|
// structures.
|
|
|
|
void HostCallback(void *data, int status, int timeouts,
|
|
|
|
struct hostent *hostent);
|
|
|
|
void SearchCallback(void *data, int status, int timeouts, unsigned char *abuf,
|
|
|
|
int alen);
|
|
|
|
void NameInfoCallback(void *data, int status, int timeouts, char *node,
|
|
|
|
char *service);
|
|
|
|
void AddrInfoCallback(void *data, int status, int timeouts,
|
|
|
|
struct ares_addrinfo *res);
|
|
|
|
|
|
|
|
// Retrieve the name servers used by a channel.
|
|
|
|
std::string GetNameServers(ares_channel_t *channel);
|
|
|
|
|
|
|
|
// RAII class to temporarily create a directory of a given name.
|
|
|
|
class TransientDir {
|
|
|
|
public:
|
|
|
|
TransientDir(const std::string &dirname);
|
|
|
|
~TransientDir();
|
|
|
|
|
|
|
|
private:
|
|
|
|
std::string dirname_;
|
|
|
|
};
|
|
|
|
|
|
|
|
// C++ wrapper around tempnam()
|
|
|
|
std::string TempNam(const char *dir, const char *prefix);
|
|
|
|
|
|
|
|
// RAII class to temporarily create file of a given name and contents.
|
|
|
|
class TransientFile {
|
|
|
|
public:
|
|
|
|
TransientFile(const std::string &filename, const std::string &contents);
|
|
|
|
~TransientFile();
|
|
|
|
|
|
|
|
protected:
|
|
|
|
std::string filename_;
|
|
|
|
};
|
|
|
|
|
|
|
|
// RAII class for a temporary file with the given contents.
|
|
|
|
class TempFile : public TransientFile {
|
|
|
|
public:
|
|
|
|
TempFile(const std::string &contents);
|
|
|
|
|
|
|
|
const char *filename() const
|
|
|
|
{
|
|
|
|
return filename_.c_str();
|
|
|
|
}
|
|
|
|
};
|
|
|
|
|
|
|
|
#ifdef _WIN32
|
|
|
|
extern "C" {
|
|
|
|
|
|
|
|
static int setenv(const char *name, const char *value, int overwrite)
|
|
|
|
{
|
|
|
|
char *buffer;
|
|
|
|
size_t buf_size;
|
|
|
|
|
|
|
|
if (name == NULL) {
|
|
|
|
return -1;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (value == NULL) {
|
|
|
|
value = ""; /* For unset */
|
|
|
|
}
|
|
|
|
|
|
|
|
if (!overwrite && getenv(name) != NULL) {
|
|
|
|
return -1;
|
|
|
|
}
|
|
|
|
|
|
|
|
buf_size = strlen(name) + strlen(value) + 1 /* = */ + 1 /* NULL */;
|
|
|
|
buffer = (char *)malloc(buf_size);
|
|
|
|
_snprintf(buffer, buf_size, "%s=%s", name, value);
|
|
|
|
_putenv(buffer);
|
|
|
|
free(buffer);
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
static int unsetenv(const char *name)
|
|
|
|
{
|
|
|
|
return setenv(name, NULL, 1);
|
|
|
|
}
|
|
|
|
|
|
|
|
} /* extern "C" */
|
|
|
|
#endif
|
|
|
|
|
|
|
|
// RAII class for a temporary environment variable value.
|
|
|
|
class EnvValue {
|
|
|
|
public:
|
|
|
|
EnvValue(const char *name, const char *value) : name_(name), restore_(false)
|
|
|
|
{
|
|
|
|
char *original = getenv(name);
|
|
|
|
if (original) {
|
|
|
|
restore_ = true;
|
|
|
|
original_ = original;
|
|
|
|
}
|
|
|
|
setenv(name_.c_str(), value, 1);
|
|
|
|
}
|
|
|
|
|
|
|
|
~EnvValue()
|
|
|
|
{
|
|
|
|
if (restore_) {
|
|
|
|
setenv(name_.c_str(), original_.c_str(), 1);
|
|
|
|
} else {
|
|
|
|
unsetenv(name_.c_str());
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
private:
|
|
|
|
std::string name_;
|
|
|
|
bool restore_;
|
|
|
|
std::string original_;
|
|
|
|
};
|
|
|
|
|
|
|
|
|
|
|
|
#ifdef HAVE_CONTAINER
|
|
|
|
// Linux-specific functionality for running code in a container, implemented
|
|
|
|
// in ares-test-ns.cc
|
|
|
|
typedef std::function<int(void)> VoidToIntFn;
|
|
|
|
typedef std::vector<std::pair<std::string, std::string>> NameContentList;
|
|
|
|
|
|
|
|
class ContainerFilesystem {
|
|
|
|
public:
|
|
|
|
ContainerFilesystem(NameContentList files, const std::string &mountpt);
|
|
|
|
~ContainerFilesystem();
|
|
|
|
|
|
|
|
std::string root() const
|
|
|
|
{
|
|
|
|
return rootdir_;
|
|
|
|
}
|
|
|
|
|
|
|
|
std::string mountpt() const
|
|
|
|
{
|
|
|
|
return mountpt_;
|
|
|
|
}
|
|
|
|
|
|
|
|
private:
|
|
|
|
void EnsureDirExists(const std::string &dir);
|
|
|
|
std::string rootdir_;
|
|
|
|
std::string mountpt_;
|
|
|
|
std::list<std::string> dirs_;
|
|
|
|
std::vector<std::unique_ptr<TransientFile>> files_;
|
|
|
|
};
|
|
|
|
|
|
|
|
int RunInContainer(ContainerFilesystem *fs, const std::string &hostname,
|
|
|
|
const std::string &domainname, VoidToIntFn fn);
|
|
|
|
|
|
|
|
# define ICLASS_NAME(casename, testname) Contained##casename##_##testname
|
|
|
|
# define CONTAINED_TEST_F(casename, testname, hostname, domainname, files) \
|
|
|
|
class ICLASS_NAME(casename, testname) : public casename { \
|
|
|
|
public: \
|
|
|
|
ICLASS_NAME(casename, testname)() \
|
|
|
|
{ \
|
|
|
|
} \
|
|
|
|
static int InnerTestBody(); \
|
|
|
|
}; \
|
|
|
|
TEST_F(ICLASS_NAME(casename, testname), _) \
|
|
|
|
{ \
|
|
|
|
ContainerFilesystem chroot(files, ".."); \
|
|
|
|
VoidToIntFn fn(ICLASS_NAME(casename, testname)::InnerTestBody); \
|
|
|
|
EXPECT_EQ(0, RunInContainer(&chroot, hostname, domainname, fn)); \
|
|
|
|
} \
|
|
|
|
int ICLASS_NAME(casename, testname)::InnerTestBody()
|
|
|
|
|
|
|
|
#endif
|
|
|
|
|
|
|
|
/* Assigns virtual IO functions to a channel. These functions simply call
|
|
|
|
* the actual system functions.
|
|
|
|
*/
|
|
|
|
class VirtualizeIO {
|
|
|
|
public:
|
|
|
|
VirtualizeIO(ares_channel);
|
|
|
|
~VirtualizeIO();
|
|
|
|
|
|
|
|
static const ares_socket_functions default_functions;
|
|
|
|
|
|
|
|
private:
|
`ares_channel` -> `ares_channel_t *`: don't bury the pointer (#595)
`ares_channel` is defined as `typedef struct ares_channeldata *ares_channel;`. The problem with this, is it embeds the pointer into the typedef, which means an `ares_channel` can never be declared as `const` as if you write `const ares_channel channel`, that expands to `struct ares_channeldata * const ares_channel` and not `const struct ares_channeldata *channel`.
We will now typedef `ares_channel_t` as `typedef struct ares_channeldata ares_channel_t;`, so if you write `const ares_channel_t *channel`, it properly expands to `const struct ares_channeldata *channel`.
We are maintaining the old typedef for API compatibility with existing integrations, and due to typedef expansion this should not even cause any compiler warnings for existing code. There are no ABI implications with this change. I could be convinced to keep existing public functions as `ares_channel` if a sufficient argument exists, but internally we really need make this change for modern best practices.
This change will allow us to internally use `const ares_channel_t *` where appropriate. Whether or not we decide to change any public interfaces to use `const` may require further discussion on if there might be ABI implications (I don't think so, but I'm also not 100% sure what a compiler internally does with `const` when emitting machine code ... I think more likely ABI implications would occur going the opposite direction).
FYI, This PR was done via a combination of sed and clang-format, the only manual code change was the addition of the new typedef, and a couple doc fixes :)
Fix By: Brad House (@bradh352)
1 year ago
|
|
|
ares_channel_t *channel_;
|
|
|
|
};
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Slightly white-box macro to generate two runs for a given test case:
|
|
|
|
* One with no modifications, and one with all IO functions set to use
|
|
|
|
* the virtual io structure.
|
|
|
|
* Since no magic socket setup or anything is done in the latter case
|
|
|
|
* this should probably only be used for test with very vanilla IO
|
|
|
|
* requirements.
|
|
|
|
*/
|
|
|
|
#define VCLASS_NAME(casename, testname) Virt##casename##_##testname
|
|
|
|
#define VIRT_NONVIRT_TEST_F(casename, testname) \
|
|
|
|
class VCLASS_NAME(casename, testname) : public casename { \
|
|
|
|
public: \
|
|
|
|
VCLASS_NAME(casename, testname)() \
|
|
|
|
{ \
|
|
|
|
} \
|
|
|
|
void InnerTestBody(); \
|
|
|
|
}; \
|
|
|
|
GTEST_TEST_(casename, testname, VCLASS_NAME(casename, testname), \
|
|
|
|
::testing::internal::GetTypeId<casename>()) \
|
|
|
|
{ \
|
|
|
|
InnerTestBody(); \
|
|
|
|
} \
|
|
|
|
GTEST_TEST_(casename, testname##_virtualized, \
|
|
|
|
VCLASS_NAME(casename, testname), \
|
|
|
|
::testing::internal::GetTypeId<casename>()) \
|
|
|
|
{ \
|
|
|
|
VirtualizeIO vio(channel_); \
|
|
|
|
InnerTestBody(); \
|
|
|
|
} \
|
|
|
|
void VCLASS_NAME(casename, testname)::InnerTestBody()
|
|
|
|
|
|
|
|
} // namespace test
|
|
|
|
} // namespace ares
|
|
|
|
|
|
|
|
#endif
|