boringssl

Mirror of BoringSSL (grpc依赖) https://boringssl.googlesource.com/boringssl

David Benjamin af0739fc73 Const-correct sk_FOO_cmp_func This is a double-pointer and both layers should be const. This matches OpenSSL 1.1.1, so in addition to being more const-correct, we're more OpenSSL-compatible. Update-Note: Anything that defines a comparison function would need to fix the type signature. I found only one external caller, Envoy, that defines it. https://github.com/envoyproxy/envoy/pull/25051 fixes it. (That we hadn't run into the upstream incompatibility suggests this is just not a feature folks use outside the library much.) Bumping BORINGSSL_API_VERSION, in case I missed any, and there's some caller where we can't just use C++14 generic lambdas to smooth it over. Fixed: 498 Change-Id: I8f07ff42215172aa65ad8819acf69b63d6d8e54c Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/56190 Auto-Submit: David Benjamin <davidben@google.com> Reviewed-by: Bob Beck <bbe@google.com> Commit-Queue: David Benjamin <davidben@google.com>	2 years ago
..
stack.c	Empty stacks are vacuously sorted	2 years ago
stack_test.cc	Const-correct sk_FOO_cmp_func	2 years ago

David Benjamin af0739fc73 Const-correct sk_FOO_cmp_func

This is a double-pointer and both layers should be const. This matches
OpenSSL 1.1.1, so in addition to being more const-correct, we're more
OpenSSL-compatible.

Update-Note: Anything that defines a comparison function would need to
fix the type signature. I found only one external caller, Envoy, that
defines it. https://github.com/envoyproxy/envoy/pull/25051 fixes it.
(That we hadn't run into the upstream incompatibility suggests this is
just not a feature folks use outside the library much.)

Bumping BORINGSSL_API_VERSION, in case I missed any, and there's some
caller where we can't just use C++14 generic lambdas to smooth it over.

Fixed: 498
Change-Id: I8f07ff42215172aa65ad8819acf69b63d6d8e54c
Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/56190
Auto-Submit: David Benjamin <davidben@google.com>
Reviewed-by: Bob Beck <bbe@google.com>
Commit-Queue: David Benjamin <davidben@google.com>

2 years ago

stack.c

Empty stacks are vacuously sorted

2 years ago

stack_test.cc

Const-correct sk_FOO_cmp_func

2 years ago