Add a note about the list in target.h

We get this question a fair amount so it's probably worth putting a
notice in the file.

Change-Id: If14ae76878e5b4085d1fbe2f946d0b1b8060e606
Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/63647
Auto-Submit: Adam Langley <agl@google.com>
Commit-Queue: Adam Langley <agl@google.com>
Reviewed-by: David Benjamin <davidben@google.com>
chromium-stable
Adam Langley 1 year ago committed by Boringssl LUCI CQ
parent 672813c21e
commit ec87e1a767
  1. 20
      include/openssl/target.h

@ -55,10 +55,22 @@
#elif defined(__myriad2__) #elif defined(__myriad2__)
#define OPENSSL_32_BIT #define OPENSSL_32_BIT
#else #else
// Note BoringSSL only supports standard 32-bit and 64-bit two's-complement, // The list above enumerates the platforms that BoringSSL supports. For these
// little-endian architectures. Functions will not produce the correct answer // platforms we keep a reasonable bar of not breaking them: automated test
// on other systems. Run the crypto_test binary, notably // coverage, for one, but also we need access to these types for machines for
// crypto/compiler_test.cc, before adding a new architecture. // fixing them.
//
// However, we know that anything that seems to work will soon be expected
// to work and, quickly, the implicit expectation is that every machine will
// always work. So this list serves to mark the boundary of what we guarantee.
// Of course, you can run the code any many more machines, but then you're
// taking on the burden of fixing it and, if you're doing that, then you must
// be able to carry local patches. In which case patching this list is trivial.
//
// BoringSSL will only possibly work on standard 32-bit and 64-bit
// two's-complement, little-endian architectures. Functions will not produce
// the correct answer on other systems. Run the crypto_test binary, notably
// crypto/compiler_test.cc, before trying a new architecture.
#error "Unknown target CPU" #error "Unknown target CPU"
#endif #endif

Loading…
Cancel
Save