GCC does not have __has_feature, so writing #if __has_feature(foo), without a guard, will cause GCC to error. This is tripping the gRPC update. Prior to https://boringssl-review.googlesource.com/c/boringssl/+/60765, this worked because the preamble to every assembly file would define the missing __has_feature macro as part of detecting MSan. Now we pick up the logic in <openssl/base.h>, which tries not to stomp over symbols we don't own. This had the side effect of removing the __has_feature polyfill. Though "public", <openssl/asm_base.h> is not really a public header, so we could put the __has_feature polyfill in there. But we already have a pattern for detecting sanitizers in <openssl/target.h>, so just switch to that one. Change-Id: I747b4513f1b2f189d2df629149f22fd0fa490257 Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/61565 Commit-Queue: Adam Langley <agl@google.com> Auto-Submit: David Benjamin <davidben@google.com> Reviewed-by: Adam Langley <agl@google.com>chromium-stable
parent
b98ce18c5b
commit
d43fef7cd5
4 changed files with 6 additions and 3 deletions
Loading…
Reference in new issue