From 43f375699f01873f0804836380a9db4ea31647ae Mon Sep 17 00:00:00 2001 From: David Benjamin Date: Tue, 10 Nov 2020 22:30:44 -0500 Subject: [PATCH] Remove some unnecessary pointer casts. Change-Id: I855e5c3811832eaddac4307fc40ca5bdeca15a98 Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/44050 Reviewed-by: Adam Langley --- crypto/asn1/a_type.c | 3 +-- crypto/x509/x_crl.c | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/crypto/asn1/a_type.c b/crypto/asn1/a_type.c index cf5da204f..f320e498b 100644 --- a/crypto/asn1/a_type.c +++ b/crypto/asn1/a_type.c @@ -145,8 +145,7 @@ int ASN1_TYPE_cmp(const ASN1_TYPE *a, const ASN1_TYPE *b) case V_ASN1_UTF8STRING: case V_ASN1_OTHER: default: - result = ASN1_STRING_cmp((ASN1_STRING *)a->value.ptr, - (ASN1_STRING *)b->value.ptr); + result = ASN1_STRING_cmp(a->value.asn1_string, b->value.asn1_string); break; } diff --git a/crypto/x509/x_crl.c b/crypto/x509/x_crl.c index b1c485aa0..3b9f137ac 100644 --- a/crypto/x509/x_crl.c +++ b/crypto/x509/x_crl.c @@ -393,8 +393,7 @@ IMPLEMENT_ASN1_DUP_FUNCTION(X509_CRL) static int X509_REVOKED_cmp(const X509_REVOKED **a, const X509_REVOKED **b) { - return (ASN1_STRING_cmp((ASN1_STRING *)(*a)->serialNumber, - (ASN1_STRING *)(*b)->serialNumber)); + return ASN1_STRING_cmp((*a)->serialNumber, (*b)->serialNumber); } int X509_CRL_add0_revoked(X509_CRL *crl, X509_REVOKED *rev)