|
|
|
/* v3_info.c */
|
|
|
|
/*
|
|
|
|
* Written by Dr Stephen N Henson (steve@openssl.org) for the OpenSSL project
|
|
|
|
* 1999.
|
|
|
|
*/
|
|
|
|
/* ====================================================================
|
|
|
|
* Copyright (c) 1999 The OpenSSL Project. All rights reserved.
|
|
|
|
*
|
|
|
|
* Redistribution and use in source and binary forms, with or without
|
|
|
|
* modification, are permitted provided that the following conditions
|
|
|
|
* are met:
|
|
|
|
*
|
|
|
|
* 1. Redistributions of source code must retain the above copyright
|
|
|
|
* notice, this list of conditions and the following disclaimer.
|
|
|
|
*
|
|
|
|
* 2. Redistributions in binary form must reproduce the above copyright
|
|
|
|
* notice, this list of conditions and the following disclaimer in
|
|
|
|
* the documentation and/or other materials provided with the
|
|
|
|
* distribution.
|
|
|
|
*
|
|
|
|
* 3. All advertising materials mentioning features or use of this
|
|
|
|
* software must display the following acknowledgment:
|
|
|
|
* "This product includes software developed by the OpenSSL Project
|
|
|
|
* for use in the OpenSSL Toolkit. (http://www.OpenSSL.org/)"
|
|
|
|
*
|
|
|
|
* 4. The names "OpenSSL Toolkit" and "OpenSSL Project" must not be used to
|
|
|
|
* endorse or promote products derived from this software without
|
|
|
|
* prior written permission. For written permission, please contact
|
|
|
|
* licensing@OpenSSL.org.
|
|
|
|
*
|
|
|
|
* 5. Products derived from this software may not be called "OpenSSL"
|
|
|
|
* nor may "OpenSSL" appear in their names without prior written
|
|
|
|
* permission of the OpenSSL Project.
|
|
|
|
*
|
|
|
|
* 6. Redistributions of any form whatsoever must retain the following
|
|
|
|
* acknowledgment:
|
|
|
|
* "This product includes software developed by the OpenSSL Project
|
|
|
|
* for use in the OpenSSL Toolkit (http://www.OpenSSL.org/)"
|
|
|
|
*
|
|
|
|
* THIS SOFTWARE IS PROVIDED BY THE OpenSSL PROJECT ``AS IS'' AND ANY
|
|
|
|
* EXPRESSED OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
|
|
|
|
* IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
|
|
|
|
* PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE OpenSSL PROJECT OR
|
|
|
|
* ITS CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
|
|
|
|
* SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT
|
|
|
|
* NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
|
|
|
|
* LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
|
|
|
|
* HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT,
|
|
|
|
* STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
|
|
|
|
* ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED
|
|
|
|
* OF THE POSSIBILITY OF SUCH DAMAGE.
|
|
|
|
* ====================================================================
|
|
|
|
*
|
|
|
|
* This product includes cryptographic software written by Eric Young
|
|
|
|
* (eay@cryptsoft.com). This product includes software written by Tim
|
|
|
|
* Hudson (tjh@cryptsoft.com).
|
|
|
|
*
|
|
|
|
*/
|
|
|
|
|
|
|
|
#include <stdio.h>
|
|
|
|
#include <string.h>
|
|
|
|
|
|
|
|
#include <openssl/asn1.h>
|
|
|
|
#include <openssl/asn1t.h>
|
|
|
|
#include <openssl/conf.h>
|
|
|
|
#include <openssl/err.h>
|
|
|
|
#include <openssl/mem.h>
|
|
|
|
#include <openssl/obj.h>
|
|
|
|
#include <openssl/x509v3.h>
|
|
|
|
|
Use the correct function types in X509V3_EXT_METHODs.
While C allows function pointer casts, it is UB to call a function with
a different type than its actual type signature. That is, even though
`void f(int *)` and `void g(void *)` have the same ABI, it is UB to
cast `f` to a `void(*)(void *)` and then call it through that pointer.
Clang CFI will try to enforce this rule.
The recent CL to call X509_print in tests revealed that all the i2? and
?2i callbacks in X509V3_EXT_METHODs were implemented with functions of
the wrong type, out of some combination of missing consts and void*
turned into T*.
This CL fixes this. Where the function wasn't exported, or had no
callers, I just fixed the function itself. Where it had extension
callers, I added a wrapper function with a void* type.
I'm not positive whether the wrappers are the right call. On the one
hand, keeping the exported functions as-is is more type-safe and more
OpenSSL-compatible. However, most (but not all) uses of these are in
other code defining X509V3_EXT_METHODs themselves, so the void*
signature is more correct for them too. And the functions have a type
signature meant for X509V3_EXT_METHOD, complete with method pointer.
I've gone with leaving the exported ones as-is for now. Probably the
right answer anyway is to migrate the external callers, of either type
signature.
Change-Id: Ib8f2995cbd890221eaa9ac864a7e553cb6711901
Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/52686
Commit-Queue: Bob Beck <bbe@google.com>
Reviewed-by: Bob Beck <bbe@google.com>
3 years ago
|
|
|
static STACK_OF(CONF_VALUE) *i2v_AUTHORITY_INFO_ACCESS(
|
|
|
|
const X509V3_EXT_METHOD *method, void *ext, STACK_OF(CONF_VALUE) *ret);
|
|
|
|
static void *v2i_AUTHORITY_INFO_ACCESS(const X509V3_EXT_METHOD *method,
|
|
|
|
X509V3_CTX *ctx,
|
|
|
|
STACK_OF(CONF_VALUE) *nval);
|
|
|
|
|
|
|
|
const X509V3_EXT_METHOD v3_info = {
|
|
|
|
NID_info_access,
|
|
|
|
X509V3_EXT_MULTILINE,
|
|
|
|
ASN1_ITEM_ref(AUTHORITY_INFO_ACCESS),
|
|
|
|
0,
|
|
|
|
0,
|
|
|
|
0,
|
|
|
|
0,
|
|
|
|
0,
|
|
|
|
0,
|
Use the correct function types in X509V3_EXT_METHODs.
While C allows function pointer casts, it is UB to call a function with
a different type than its actual type signature. That is, even though
`void f(int *)` and `void g(void *)` have the same ABI, it is UB to
cast `f` to a `void(*)(void *)` and then call it through that pointer.
Clang CFI will try to enforce this rule.
The recent CL to call X509_print in tests revealed that all the i2? and
?2i callbacks in X509V3_EXT_METHODs were implemented with functions of
the wrong type, out of some combination of missing consts and void*
turned into T*.
This CL fixes this. Where the function wasn't exported, or had no
callers, I just fixed the function itself. Where it had extension
callers, I added a wrapper function with a void* type.
I'm not positive whether the wrappers are the right call. On the one
hand, keeping the exported functions as-is is more type-safe and more
OpenSSL-compatible. However, most (but not all) uses of these are in
other code defining X509V3_EXT_METHODs themselves, so the void*
signature is more correct for them too. And the functions have a type
signature meant for X509V3_EXT_METHOD, complete with method pointer.
I've gone with leaving the exported ones as-is for now. Probably the
right answer anyway is to migrate the external callers, of either type
signature.
Change-Id: Ib8f2995cbd890221eaa9ac864a7e553cb6711901
Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/52686
Commit-Queue: Bob Beck <bbe@google.com>
Reviewed-by: Bob Beck <bbe@google.com>
3 years ago
|
|
|
i2v_AUTHORITY_INFO_ACCESS,
|
|
|
|
v2i_AUTHORITY_INFO_ACCESS,
|
|
|
|
0,
|
|
|
|
0,
|
|
|
|
NULL,
|
|
|
|
};
|
|
|
|
|
|
|
|
const X509V3_EXT_METHOD v3_sinfo = {
|
|
|
|
NID_sinfo_access,
|
|
|
|
X509V3_EXT_MULTILINE,
|
|
|
|
ASN1_ITEM_ref(AUTHORITY_INFO_ACCESS),
|
|
|
|
0,
|
|
|
|
0,
|
|
|
|
0,
|
|
|
|
0,
|
|
|
|
0,
|
|
|
|
0,
|
Use the correct function types in X509V3_EXT_METHODs.
While C allows function pointer casts, it is UB to call a function with
a different type than its actual type signature. That is, even though
`void f(int *)` and `void g(void *)` have the same ABI, it is UB to
cast `f` to a `void(*)(void *)` and then call it through that pointer.
Clang CFI will try to enforce this rule.
The recent CL to call X509_print in tests revealed that all the i2? and
?2i callbacks in X509V3_EXT_METHODs were implemented with functions of
the wrong type, out of some combination of missing consts and void*
turned into T*.
This CL fixes this. Where the function wasn't exported, or had no
callers, I just fixed the function itself. Where it had extension
callers, I added a wrapper function with a void* type.
I'm not positive whether the wrappers are the right call. On the one
hand, keeping the exported functions as-is is more type-safe and more
OpenSSL-compatible. However, most (but not all) uses of these are in
other code defining X509V3_EXT_METHODs themselves, so the void*
signature is more correct for them too. And the functions have a type
signature meant for X509V3_EXT_METHOD, complete with method pointer.
I've gone with leaving the exported ones as-is for now. Probably the
right answer anyway is to migrate the external callers, of either type
signature.
Change-Id: Ib8f2995cbd890221eaa9ac864a7e553cb6711901
Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/52686
Commit-Queue: Bob Beck <bbe@google.com>
Reviewed-by: Bob Beck <bbe@google.com>
3 years ago
|
|
|
i2v_AUTHORITY_INFO_ACCESS,
|
|
|
|
v2i_AUTHORITY_INFO_ACCESS,
|
|
|
|
0,
|
|
|
|
0,
|
|
|
|
NULL,
|
|
|
|
};
|
|
|
|
|
|
|
|
ASN1_SEQUENCE(ACCESS_DESCRIPTION) = {
|
|
|
|
ASN1_SIMPLE(ACCESS_DESCRIPTION, method, ASN1_OBJECT),
|
|
|
|
ASN1_SIMPLE(ACCESS_DESCRIPTION, location, GENERAL_NAME),
|
|
|
|
} ASN1_SEQUENCE_END(ACCESS_DESCRIPTION)
|
|
|
|
|
|
|
|
IMPLEMENT_ASN1_FUNCTIONS(ACCESS_DESCRIPTION)
|
|
|
|
|
|
|
|
ASN1_ITEM_TEMPLATE(AUTHORITY_INFO_ACCESS) = ASN1_EX_TEMPLATE_TYPE(
|
|
|
|
ASN1_TFLG_SEQUENCE_OF, 0, GeneralNames, ACCESS_DESCRIPTION)
|
|
|
|
ASN1_ITEM_TEMPLATE_END(AUTHORITY_INFO_ACCESS)
|
|
|
|
|
|
|
|
IMPLEMENT_ASN1_FUNCTIONS(AUTHORITY_INFO_ACCESS)
|
|
|
|
|
|
|
|
static STACK_OF(CONF_VALUE) *i2v_AUTHORITY_INFO_ACCESS(
|
|
|
|
const X509V3_EXT_METHOD *method, void *ext, STACK_OF(CONF_VALUE) *ret) {
|
|
|
|
const AUTHORITY_INFO_ACCESS *ainfo = ext;
|
|
|
|
ACCESS_DESCRIPTION *desc;
|
|
|
|
int nlen;
|
|
|
|
char objtmp[80], *ntmp;
|
|
|
|
CONF_VALUE *vtmp;
|
|
|
|
STACK_OF(CONF_VALUE) *tret = ret;
|
|
|
|
|
|
|
|
for (size_t i = 0; i < sk_ACCESS_DESCRIPTION_num(ainfo); i++) {
|
|
|
|
STACK_OF(CONF_VALUE) *tmp;
|
|
|
|
|
|
|
|
desc = sk_ACCESS_DESCRIPTION_value(ainfo, i);
|
|
|
|
tmp = i2v_GENERAL_NAME(method, desc->location, tret);
|
|
|
|
if (tmp == NULL) {
|
|
|
|
goto err;
|
|
|
|
}
|
|
|
|
tret = tmp;
|
|
|
|
vtmp = sk_CONF_VALUE_value(tret, i);
|
|
|
|
i2t_ASN1_OBJECT(objtmp, sizeof objtmp, desc->method);
|
|
|
|
nlen = strlen(objtmp) + strlen(vtmp->name) + 5;
|
|
|
|
ntmp = OPENSSL_malloc(nlen);
|
|
|
|
if (ntmp == NULL) {
|
|
|
|
goto err;
|
|
|
|
}
|
|
|
|
OPENSSL_strlcpy(ntmp, objtmp, nlen);
|
|
|
|
OPENSSL_strlcat(ntmp, " - ", nlen);
|
|
|
|
OPENSSL_strlcat(ntmp, vtmp->name, nlen);
|
|
|
|
OPENSSL_free(vtmp->name);
|
|
|
|
vtmp->name = ntmp;
|
|
|
|
}
|
|
|
|
if (ret == NULL && tret == NULL) {
|
|
|
|
return sk_CONF_VALUE_new_null();
|
|
|
|
}
|
|
|
|
|
|
|
|
return tret;
|
|
|
|
err:
|
|
|
|
OPENSSL_PUT_ERROR(X509V3, ERR_R_MALLOC_FAILURE);
|
|
|
|
if (ret == NULL && tret != NULL) {
|
|
|
|
sk_CONF_VALUE_pop_free(tret, X509V3_conf_free);
|
|
|
|
}
|
|
|
|
return NULL;
|
|
|
|
}
|
|
|
|
|
Use the correct function types in X509V3_EXT_METHODs.
While C allows function pointer casts, it is UB to call a function with
a different type than its actual type signature. That is, even though
`void f(int *)` and `void g(void *)` have the same ABI, it is UB to
cast `f` to a `void(*)(void *)` and then call it through that pointer.
Clang CFI will try to enforce this rule.
The recent CL to call X509_print in tests revealed that all the i2? and
?2i callbacks in X509V3_EXT_METHODs were implemented with functions of
the wrong type, out of some combination of missing consts and void*
turned into T*.
This CL fixes this. Where the function wasn't exported, or had no
callers, I just fixed the function itself. Where it had extension
callers, I added a wrapper function with a void* type.
I'm not positive whether the wrappers are the right call. On the one
hand, keeping the exported functions as-is is more type-safe and more
OpenSSL-compatible. However, most (but not all) uses of these are in
other code defining X509V3_EXT_METHODs themselves, so the void*
signature is more correct for them too. And the functions have a type
signature meant for X509V3_EXT_METHOD, complete with method pointer.
I've gone with leaving the exported ones as-is for now. Probably the
right answer anyway is to migrate the external callers, of either type
signature.
Change-Id: Ib8f2995cbd890221eaa9ac864a7e553cb6711901
Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/52686
Commit-Queue: Bob Beck <bbe@google.com>
Reviewed-by: Bob Beck <bbe@google.com>
3 years ago
|
|
|
static void *v2i_AUTHORITY_INFO_ACCESS(const X509V3_EXT_METHOD *method,
|
|
|
|
X509V3_CTX *ctx,
|
|
|
|
STACK_OF(CONF_VALUE) *nval) {
|
|
|
|
AUTHORITY_INFO_ACCESS *ainfo = NULL;
|
|
|
|
ACCESS_DESCRIPTION *acc;
|
|
|
|
char *objtmp, *ptmp;
|
|
|
|
if (!(ainfo = sk_ACCESS_DESCRIPTION_new_null())) {
|
|
|
|
OPENSSL_PUT_ERROR(X509V3, ERR_R_MALLOC_FAILURE);
|
|
|
|
return NULL;
|
|
|
|
}
|
|
|
|
for (size_t i = 0; i < sk_CONF_VALUE_num(nval); i++) {
|
|
|
|
CONF_VALUE *cnf = sk_CONF_VALUE_value(nval, i);
|
|
|
|
if (!(acc = ACCESS_DESCRIPTION_new()) ||
|
|
|
|
!sk_ACCESS_DESCRIPTION_push(ainfo, acc)) {
|
|
|
|
OPENSSL_PUT_ERROR(X509V3, ERR_R_MALLOC_FAILURE);
|
|
|
|
goto err;
|
|
|
|
}
|
|
|
|
ptmp = strchr(cnf->name, ';');
|
|
|
|
if (!ptmp) {
|
|
|
|
OPENSSL_PUT_ERROR(X509V3, X509V3_R_INVALID_SYNTAX);
|
|
|
|
goto err;
|
|
|
|
}
|
|
|
|
int objlen = ptmp - cnf->name;
|
|
|
|
CONF_VALUE ctmp;
|
|
|
|
ctmp.name = ptmp + 1;
|
|
|
|
ctmp.value = cnf->value;
|
|
|
|
if (!v2i_GENERAL_NAME_ex(acc->location, method, ctx, &ctmp, 0)) {
|
|
|
|
goto err;
|
|
|
|
}
|
|
|
|
if (!(objtmp = OPENSSL_malloc(objlen + 1))) {
|
|
|
|
OPENSSL_PUT_ERROR(X509V3, ERR_R_MALLOC_FAILURE);
|
|
|
|
goto err;
|
|
|
|
}
|
|
|
|
OPENSSL_strlcpy(objtmp, cnf->name, objlen + 1);
|
|
|
|
acc->method = OBJ_txt2obj(objtmp, 0);
|
|
|
|
if (!acc->method) {
|
|
|
|
OPENSSL_PUT_ERROR(X509V3, X509V3_R_BAD_OBJECT);
|
|
|
|
ERR_add_error_data(2, "value=", objtmp);
|
|
|
|
OPENSSL_free(objtmp);
|
|
|
|
goto err;
|
|
|
|
}
|
|
|
|
OPENSSL_free(objtmp);
|
|
|
|
}
|
|
|
|
return ainfo;
|
|
|
|
err:
|
|
|
|
sk_ACCESS_DESCRIPTION_pop_free(ainfo, ACCESS_DESCRIPTION_free);
|
|
|
|
return NULL;
|
|
|
|
}
|
|
|
|
|
|
|
|
int i2a_ACCESS_DESCRIPTION(BIO *bp, const ACCESS_DESCRIPTION *a) {
|
|
|
|
i2a_ASN1_OBJECT(bp, a->method);
|
|
|
|
return 2;
|
|
|
|
}
|