Chiebot-Mirror
/
boringssl
8
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
Mirror of BoringSSL (grpc依赖) https://boringssl.googlesource.com/boringssl
You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
621 Commits
61 Branches
23 Tags
511 MiB
Tag: Branch: Tree: a50f24c854
Branches Tags
${ item.name }
Create tag ${ searchTerm }
Create branch ${ searchTerm }
from 'a50f24c854'
${ noResults }
boringssl/crypto/asn1/internal.h

189 lines
8.1 KiB
Raw Normal View History Unescape

acvp: add CMAC-AES support. Change by Dan Janni. Change-Id: I3f059e7b1a822c6f97128ca92a693499a3f7fa8f Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/41984 Commit-Queue: Adam Langley <agl@google.com> Reviewed-by: David Benjamin <davidben@google.com>
5 years ago
/*
* Written by Dr Stephen N Henson (steve@openssl.org) for the OpenSSL project
* 2006.
*/
/* ====================================================================
* Copyright (c) 2006 The OpenSSL Project. All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions
* are met:
*
* 1. Redistributions of source code must retain the above copyright
* notice, this list of conditions and the following disclaimer.
*
* 2. Redistributions in binary form must reproduce the above copyright
* notice, this list of conditions and the following disclaimer in
* the documentation and/or other materials provided with the
* distribution.
*
* 3. All advertising materials mentioning features or use of this
* software must display the following acknowledgment:
* "This product includes software developed by the OpenSSL Project
* for use in the OpenSSL Toolkit. (http://www.OpenSSL.org/)"
*
* 4. The names "OpenSSL Toolkit" and "OpenSSL Project" must not be used to
* endorse or promote products derived from this software without
* prior written permission. For written permission, please contact
* licensing@OpenSSL.org.
*
* 5. Products derived from this software may not be called "OpenSSL"
* nor may "OpenSSL" appear in their names without prior written
* permission of the OpenSSL Project.
*
* 6. Redistributions of any form whatsoever must retain the following
* acknowledgment:
* "This product includes software developed by the OpenSSL Project
* for use in the OpenSSL Toolkit (http://www.OpenSSL.org/)"
*
* THIS SOFTWARE IS PROVIDED BY THE OpenSSL PROJECT ``AS IS'' AND ANY
* EXPRESSED OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
* IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
* PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE OpenSSL PROJECT OR
* ITS CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
* SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT
* NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
* LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
* HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT,
* STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
* ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED
* OF THE POSSIBILITY OF SUCH DAMAGE.
* ====================================================================
*
* This product includes cryptographic software written by Eric Young
* (eay@cryptsoft.com). This product includes software written by Tim
* Hudson (tjh@cryptsoft.com).
*
*/
#ifndef OPENSSL_HEADER_ASN1_ASN1_LOCL_H
#define OPENSSL_HEADER_ASN1_ASN1_LOCL_H
#include <time.h>
#include <openssl/asn1.h>
#if defined(__cplusplus)
extern "C" {
#endif
/* Wrapper functions for time functions. */
/* OPENSSL_gmtime wraps |gmtime_r|. See the manual page for that function. */
struct tm *OPENSSL_gmtime(const time_t *time, struct tm *result);
/* OPENSSL_gmtime_adj updates |tm| by adding |offset_day| days and |offset_sec|
* seconds. */
int OPENSSL_gmtime_adj(struct tm *tm, int offset_day, long offset_sec);
/* OPENSSL_gmtime_diff calculates the difference between |from| and |to| and
* outputs the difference as a number of days and seconds in |*out_days| and
* |*out_secs|. */
int OPENSSL_gmtime_diff(int *out_days, int *out_secs, const struct tm *from,
const struct tm *to);
/* Internal ASN1 structures and functions: not for application use */
Make ASN1_OBJECT opaque. This cleans up the story with https://boringssl-review.googlesource.com/c/boringssl/+/46164. None of our exported functions mutate ASN1_OBJECTS, with the exception of ASN1_OBJECT_free, the object reuse mode of c2i_ASN1_OBJECT, and their callers. Those functions check flags to correctly handle static ASN1_OBJECTs. For now, I've kept the struct definition in crypto/asn1 even though ASN1_OBJECT is partially in crypto/obj. Since we prefer to cut dependencies to crypto/asn1, we probably should rearrange this later. I've also, for now, kept crypto/asn1/internal.h at C-style comments, though our style story here is weird. (Maybe it's time to clang-format crypto/asn1 and crypto/x509? Patches from upstream rarely directly apply anyway, since we're a mix of 1.0.2 and 1.1.1 in crypto/x509.) Update-Note: ASN1_OBJECT is now opaque. Callers should use accessors. Change-Id: I655e6bd8afda98a2d1e676c3abeb873aa8de6691 Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/48326 Reviewed-by: Adam Langley <agl@google.com>
4 years ago
/* These are used internally in the ASN1_OBJECT to keep track of
* whether the names and data need to be free()ed */
#define ASN1_OBJECT_FLAG_DYNAMIC 0x01 /* internal use */
#define ASN1_OBJECT_FLAG_DYNAMIC_STRINGS 0x04 /* internal use */
#define ASN1_OBJECT_FLAG_DYNAMIC_DATA 0x08 /* internal use */
/* An asn1_object_st (aka |ASN1_OBJECT|) represents an ASN.1 OBJECT IDENTIFIER.
* Note: Mutating an |ASN1_OBJECT| is only permitted when initializing it. The
* library maintains a table of static |ASN1_OBJECT|s, which may be referenced
* by non-const |ASN1_OBJECT| pointers. Code which receives an |ASN1_OBJECT|
* pointer externally must assume it is immutable, even if the pointer is not
* const. */
struct asn1_object_st {
const char *sn, *ln;
int nid;
int length;
const unsigned char *data; /* data remains const after init */
int flags; /* Should we free this one */
};
acvp: add CMAC-AES support. Change by Dan Janni. Change-Id: I3f059e7b1a822c6f97128ca92a693499a3f7fa8f Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/41984 Commit-Queue: Adam Langley <agl@google.com> Reviewed-by: David Benjamin <davidben@google.com>
5 years ago
int asn1_utctime_to_tm(struct tm *tm, const ASN1_UTCTIME *d);
int asn1_generalizedtime_to_tm(struct tm *tm, const ASN1_GENERALIZEDTIME *d);
void asn1_item_combine_free(ASN1_VALUE **pval, const ASN1_ITEM *it,
int combine);
int UTF8_getc(const unsigned char *str, int len, uint32_t *val);
int UTF8_putc(unsigned char *str, int len, uint32_t value);
Unexport internal crypto/asn1 functions. A few can be made static. Move the rest of asn1_locl.h. Update-Note: Code search says these are unused. If someone's using them, we can reexport them. Change-Id: Ib41fd15792b59e7a1a41fa6b7ef5297dc19f3021 Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/43893 Reviewed-by: Adam Langley <agl@google.com>
5 years ago
int ASN1_item_ex_new(ASN1_VALUE **pval, const ASN1_ITEM *it);
void ASN1_item_ex_free(ASN1_VALUE **pval, const ASN1_ITEM *it);
void ASN1_template_free(ASN1_VALUE **pval, const ASN1_TEMPLATE *tt);
int ASN1_item_ex_d2i(ASN1_VALUE **pval, const unsigned char **in, long len,
const ASN1_ITEM *it, int tag, int aclass, char opt,
ASN1_TLC *ctx);
Correctly propagate errors in i2d functions. tasn_enc.c was missing lots of error checks and mixed up 0 and -1 returns. Document all the internal calling conventions, as best as I can tell, and fix things up. There are also error cases it forgets to check (it generally does not notice missing non-OPTIONAL fields). This CL only addresses errors it already tries to report. Subsequent CLs will add in the missing error cases. And then if it all sticks, I'm hoping we can rewrite this with CBB. Rewriting tsan_dec.c to CBS would also be good, but that will be more difficult as we need to clear out BER first. Update-Note: Some error cases which were silently misinterpreted as missing OPTIONAL elements will now cause encoding to fail. Bug: 429 Change-Id: Ibbb3eba08eb8f8f878930c9456edc8c74479aade Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/49345 Commit-Queue: David Benjamin <davidben@google.com> Reviewed-by: Adam Langley <agl@google.com>
4 years ago
/* ASN1_item_ex_i2d encodes |*pval| as a value of type |it| to |out| under the
Reject missing required fields in i2d functions. See also 006906cddda37e24a66443199444ef4476697477 from OpenSSL, though this CL uses a different strategy from upstream. Upstream makes ASN1_item_ex_i2d continue to allow optionals and checks afterwards at every non-optional call site. This CL pushes down an optional parameter and says functions cannot omit items unless explicitly allowed. I think this is a better default, though it is a larger change. Fields are only optional when they come from an ASN1_TEMPLATE with the OPTIONAL flag. Upstream's strategy misses top-level calls. This CL additionally adds checks for optional ASN1_TEMPLATEs in contexts where it doesn't make sense. Only fields of SEQUENCEs and SETs may be OPTIONAL, but the ASN1_ITEM/ASN1_TEMPLATE split doesn't quite match ASN.1 itself. ASN1_TEMPLATE is additionally responsible for explicit/implicit tagging, and SEQUENCE/SET OF. That means CHOICE arms and the occasional top-level type (ASN1_ITEM_TEMPLATE) use ASN1_TEMPLATE but will get confused if marked optional. As part of this, i2d_FOO(NULL) now returns -1 rather than "successfully" writing 0 bytes. If we want to allow NULL at the top-level, that's not too hard to arrange, but our CBB-based i2d functions do not. Update-Note: Structures with missing mandatory fields can no longer be encoded. Note that, apart from the cases already handled by preceding CLs, tasn_new.c will fill in non-NULL empty objects everywhere. The main downstream impact I've seen of this particular change is in combination with other bugs. Consider a caller that does: GENERAL_NAME *name = GENERAL_NAME_new(); name->type = GEN_DNS; name->d.dNSName = DoSomethingComplicated(...); Suppose DoSomethingComplicated() was actually fallible and returned NULL, but the caller forgot to check. They'd now construct a GENERAL_NAME with a missing field. Previously, this would silently serialize some garbage (omitted field) or empty string. Now we fail to encode, but the true error was the uncaught DoSomethingComplicated() failure. (Which likely was itself a bug.) Bug: 429 Change-Id: I37fe618761be64a619be9fdc8d416f24ecbb8c46 Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/49350 Commit-Queue: David Benjamin <davidben@google.com> Reviewed-by: Adam Langley <agl@google.com>
4 years ago
* i2d output convention. It returns a non-zero length on success and -1 on
* error. If |tag| is -1. the tag and class come from |it|. Otherwise, the tag
Unwind remnants of ASN1_TFLG_NDEF. The i2d functions internally take a tag/class pair of parameters. If tag is not -1, we override the tag with (tag, class). Otherwise, class is ignored. (class is inconsistently called aclass or iclass.) Historically, the remaning bits of class were repurposed to pass extra flags down the structure. These had to be preserved in all recursive calls, so the functions take apart and reassemble the two halves of aclass/iclass. The only such flag was ASN1_TFLG_NDEF, which on certain types, caused OpenSSL to encode indefinite-length encoding. We removed this in https://boringssl-review.googlesource.com/c/boringssl/+/43889. Due to these flags, if tag == -1, class should default to zero. However, X509_NAME's callbacks pass -1, -1, instead of -1, 0, effectively setting all flags. This wasn't noticed because none of the types below X509_NAME pay attention to ASN1_TFLG_NDEF. This CL does two things: First, it unwinds the remainder of the flags machinery. If we ever need flags, we should pass it as a distinct argument. Second, it fixes the X509_NAME calls and asserts that -1 is always paired with 0. Change-Id: I285a73a06ad16980617fe23d5ea7f260fc5dbf16 Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/49385 Commit-Queue: David Benjamin <davidben@google.com> Reviewed-by: Adam Langley <agl@google.com>
4 years ago
* number is |tag| and the class is |aclass|. This is used for implicit tagging.
* This function treats a missing value as an error, not an optional field. */
Unexport internal crypto/asn1 functions. A few can be made static. Move the rest of asn1_locl.h. Update-Note: Code search says these are unused. If someone's using them, we can reexport them. Change-Id: Ib41fd15792b59e7a1a41fa6b7ef5297dc19f3021 Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/43893 Reviewed-by: Adam Langley <agl@google.com>
5 years ago
int ASN1_item_ex_i2d(ASN1_VALUE **pval, unsigned char **out,
const ASN1_ITEM *it, int tag, int aclass);
Correctly propagate errors in i2d functions. tasn_enc.c was missing lots of error checks and mixed up 0 and -1 returns. Document all the internal calling conventions, as best as I can tell, and fix things up. There are also error cases it forgets to check (it generally does not notice missing non-OPTIONAL fields). This CL only addresses errors it already tries to report. Subsequent CLs will add in the missing error cases. And then if it all sticks, I'm hoping we can rewrite this with CBB. Rewriting tsan_dec.c to CBS would also be good, but that will be more difficult as we need to clear out BER first. Update-Note: Some error cases which were silently misinterpreted as missing OPTIONAL elements will now cause encoding to fail. Bug: 429 Change-Id: Ibbb3eba08eb8f8f878930c9456edc8c74479aade Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/49345 Commit-Queue: David Benjamin <davidben@google.com> Reviewed-by: Adam Langley <agl@google.com>
4 years ago
Unexport internal crypto/asn1 functions. A few can be made static. Move the rest of asn1_locl.h. Update-Note: Code search says these are unused. If someone's using them, we can reexport them. Change-Id: Ib41fd15792b59e7a1a41fa6b7ef5297dc19f3021 Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/43893 Reviewed-by: Adam Langley <agl@google.com>
5 years ago
void ASN1_primitive_free(ASN1_VALUE **pval, const ASN1_ITEM *it);
Correctly propagate errors in i2d functions. tasn_enc.c was missing lots of error checks and mixed up 0 and -1 returns. Document all the internal calling conventions, as best as I can tell, and fix things up. There are also error cases it forgets to check (it generally does not notice missing non-OPTIONAL fields). This CL only addresses errors it already tries to report. Subsequent CLs will add in the missing error cases. And then if it all sticks, I'm hoping we can rewrite this with CBB. Rewriting tsan_dec.c to CBS would also be good, but that will be more difficult as we need to clear out BER first. Update-Note: Some error cases which were silently misinterpreted as missing OPTIONAL elements will now cause encoding to fail. Bug: 429 Change-Id: Ibbb3eba08eb8f8f878930c9456edc8c74479aade Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/49345 Commit-Queue: David Benjamin <davidben@google.com> Reviewed-by: Adam Langley <agl@google.com>
4 years ago
/* asn1_get_choice_selector returns the CHOICE selector value for |*pval|, which
* must of type |it|. */
Unexport internal crypto/asn1 functions. A few can be made static. Move the rest of asn1_locl.h. Update-Note: Code search says these are unused. If someone's using them, we can reexport them. Change-Id: Ib41fd15792b59e7a1a41fa6b7ef5297dc19f3021 Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/43893 Reviewed-by: Adam Langley <agl@google.com>
5 years ago
int asn1_get_choice_selector(ASN1_VALUE **pval, const ASN1_ITEM *it);
Correctly propagate errors in i2d functions. tasn_enc.c was missing lots of error checks and mixed up 0 and -1 returns. Document all the internal calling conventions, as best as I can tell, and fix things up. There are also error cases it forgets to check (it generally does not notice missing non-OPTIONAL fields). This CL only addresses errors it already tries to report. Subsequent CLs will add in the missing error cases. And then if it all sticks, I'm hoping we can rewrite this with CBB. Rewriting tsan_dec.c to CBS would also be good, but that will be more difficult as we need to clear out BER first. Update-Note: Some error cases which were silently misinterpreted as missing OPTIONAL elements will now cause encoding to fail. Bug: 429 Change-Id: Ibbb3eba08eb8f8f878930c9456edc8c74479aade Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/49345 Commit-Queue: David Benjamin <davidben@google.com> Reviewed-by: Adam Langley <agl@google.com>
4 years ago
Unexport internal crypto/asn1 functions. A few can be made static. Move the rest of asn1_locl.h. Update-Note: Code search says these are unused. If someone's using them, we can reexport them. Change-Id: Ib41fd15792b59e7a1a41fa6b7ef5297dc19f3021 Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/43893 Reviewed-by: Adam Langley <agl@google.com>
5 years ago
int asn1_set_choice_selector(ASN1_VALUE **pval, int value, const ASN1_ITEM *it);
Correctly propagate errors in i2d functions. tasn_enc.c was missing lots of error checks and mixed up 0 and -1 returns. Document all the internal calling conventions, as best as I can tell, and fix things up. There are also error cases it forgets to check (it generally does not notice missing non-OPTIONAL fields). This CL only addresses errors it already tries to report. Subsequent CLs will add in the missing error cases. And then if it all sticks, I'm hoping we can rewrite this with CBB. Rewriting tsan_dec.c to CBS would also be good, but that will be more difficult as we need to clear out BER first. Update-Note: Some error cases which were silently misinterpreted as missing OPTIONAL elements will now cause encoding to fail. Bug: 429 Change-Id: Ibbb3eba08eb8f8f878930c9456edc8c74479aade Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/49345 Commit-Queue: David Benjamin <davidben@google.com> Reviewed-by: Adam Langley <agl@google.com>
4 years ago
/* asn1_get_field_ptr returns a pointer to the field in |*pval| corresponding to
* |tt|. */
Unexport internal crypto/asn1 functions. A few can be made static. Move the rest of asn1_locl.h. Update-Note: Code search says these are unused. If someone's using them, we can reexport them. Change-Id: Ib41fd15792b59e7a1a41fa6b7ef5297dc19f3021 Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/43893 Reviewed-by: Adam Langley <agl@google.com>
5 years ago
ASN1_VALUE **asn1_get_field_ptr(ASN1_VALUE **pval, const ASN1_TEMPLATE *tt);
Correctly propagate errors in i2d functions. tasn_enc.c was missing lots of error checks and mixed up 0 and -1 returns. Document all the internal calling conventions, as best as I can tell, and fix things up. There are also error cases it forgets to check (it generally does not notice missing non-OPTIONAL fields). This CL only addresses errors it already tries to report. Subsequent CLs will add in the missing error cases. And then if it all sticks, I'm hoping we can rewrite this with CBB. Rewriting tsan_dec.c to CBS would also be good, but that will be more difficult as we need to clear out BER first. Update-Note: Some error cases which were silently misinterpreted as missing OPTIONAL elements will now cause encoding to fail. Bug: 429 Change-Id: Ibbb3eba08eb8f8f878930c9456edc8c74479aade Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/49345 Commit-Queue: David Benjamin <davidben@google.com> Reviewed-by: Adam Langley <agl@google.com>
4 years ago
/* asn1_do_adb returns the |ASN1_TEMPLATE| for the ANY DEFINED BY field |tt|,
* based on the selector INTEGER or OID in |*pval|. If |tt| is not an ADB field,
* it returns |tt|. If the selector does not match any value, it returns NULL.
* If |nullerr| is non-zero, it will additionally push an error to the error
* queue when there is no match. */
Unexport internal crypto/asn1 functions. A few can be made static. Move the rest of asn1_locl.h. Update-Note: Code search says these are unused. If someone's using them, we can reexport them. Change-Id: Ib41fd15792b59e7a1a41fa6b7ef5297dc19f3021 Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/43893 Reviewed-by: Adam Langley <agl@google.com>
5 years ago
const ASN1_TEMPLATE *asn1_do_adb(ASN1_VALUE **pval, const ASN1_TEMPLATE *tt,
int nullerr);
void asn1_refcount_set_one(ASN1_VALUE **pval, const ASN1_ITEM *it);
int asn1_refcount_dec_and_test_zero(ASN1_VALUE **pval, const ASN1_ITEM *it);
void asn1_enc_init(ASN1_VALUE **pval, const ASN1_ITEM *it);
void asn1_enc_free(ASN1_VALUE **pval, const ASN1_ITEM *it);
Correctly propagate errors in i2d functions. tasn_enc.c was missing lots of error checks and mixed up 0 and -1 returns. Document all the internal calling conventions, as best as I can tell, and fix things up. There are also error cases it forgets to check (it generally does not notice missing non-OPTIONAL fields). This CL only addresses errors it already tries to report. Subsequent CLs will add in the missing error cases. And then if it all sticks, I'm hoping we can rewrite this with CBB. Rewriting tsan_dec.c to CBS would also be good, but that will be more difficult as we need to clear out BER first. Update-Note: Some error cases which were silently misinterpreted as missing OPTIONAL elements will now cause encoding to fail. Bug: 429 Change-Id: Ibbb3eba08eb8f8f878930c9456edc8c74479aade Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/49345 Commit-Queue: David Benjamin <davidben@google.com> Reviewed-by: Adam Langley <agl@google.com>
4 years ago
/* asn1_enc_restore, if |*pval| has a saved encoding, writes it to |out| under
* the i2d output convention, sets |*len| to the length, and returns one. If it
* has no saved encoding, it returns zero. */
Unexport internal crypto/asn1 functions. A few can be made static. Move the rest of asn1_locl.h. Update-Note: Code search says these are unused. If someone's using them, we can reexport them. Change-Id: Ib41fd15792b59e7a1a41fa6b7ef5297dc19f3021 Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/43893 Reviewed-by: Adam Langley <agl@google.com>
5 years ago
int asn1_enc_restore(int *len, unsigned char **out, ASN1_VALUE **pval,
const ASN1_ITEM *it);
Correctly propagate errors in i2d functions. tasn_enc.c was missing lots of error checks and mixed up 0 and -1 returns. Document all the internal calling conventions, as best as I can tell, and fix things up. There are also error cases it forgets to check (it generally does not notice missing non-OPTIONAL fields). This CL only addresses errors it already tries to report. Subsequent CLs will add in the missing error cases. And then if it all sticks, I'm hoping we can rewrite this with CBB. Rewriting tsan_dec.c to CBS would also be good, but that will be more difficult as we need to clear out BER first. Update-Note: Some error cases which were silently misinterpreted as missing OPTIONAL elements will now cause encoding to fail. Bug: 429 Change-Id: Ibbb3eba08eb8f8f878930c9456edc8c74479aade Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/49345 Commit-Queue: David Benjamin <davidben@google.com> Reviewed-by: Adam Langley <agl@google.com>
4 years ago
Unexport internal crypto/asn1 functions. A few can be made static. Move the rest of asn1_locl.h. Update-Note: Code search says these are unused. If someone's using them, we can reexport them. Change-Id: Ib41fd15792b59e7a1a41fa6b7ef5297dc19f3021 Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/43893 Reviewed-by: Adam Langley <agl@google.com>
5 years ago
int asn1_enc_save(ASN1_VALUE **pval, const unsigned char *in, int inlen,
const ASN1_ITEM *it);
Do not access value.ptr with V_ASN1_BOOLEAN. This fixes a bug in ASN1_TYPE_get. Partly imported from upstream's 261ec72d58af64327214a78ca1c54b169ad93c28, though I don't believe ASN1_TYPE_set was broken per se. There's also a lot more than in that commit. I've added a test to ensure we maintain the unused bits invariant anyway, in case external code relies on it. (The invariant comes from the pointer being NULL-initialized and from ASN1_primitive_free zeroing *pval on free.) Change-Id: I4c0c57519a7628041d81c26cd850317e01409556 Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/46324 Commit-Queue: David Benjamin <davidben@google.com> Reviewed-by: Adam Langley <agl@google.com>
4 years ago
/* asn1_type_value_as_pointer returns |a|'s value in pointer form. This is
* usually the value object but, for BOOLEAN values, is 0 or 0xff cast to
* a pointer. */
const void *asn1_type_value_as_pointer(const ASN1_TYPE *a);
Rewrite ASN1_PRINTABLE_type and add tests. The old loop read one byte past the length. It also stopped the loop too early on interior NUL. See also upstream's https://github.com/openssl/openssl/pull/16433, though I've opted to rewrite the function entirely rather than use their fix. Also deduplicate the PrintableString check. Change-Id: Ia8bd282047c2a2ed1d5e71a68a3947c7c108df95 Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/49066 Commit-Queue: David Benjamin <davidben@google.com> Reviewed-by: Adam Langley <agl@google.com>
4 years ago
/* asn1_is_printable returns one if |value| is a valid Unicode codepoint for an
* ASN.1 PrintableString, and zero otherwise. */
int asn1_is_printable(uint32_t value);
Test that built-in ASN1_STRING_TABLEs are sorted. There's a test in the file under ifdef, but that is not wired up into the build. Change-Id: Iec09277c7ce948c33303d12c325207de2188d908 Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/49766 Reviewed-by: Adam Langley <agl@google.com>
3 years ago
/* asn1_get_string_table_for_testing sets |*out_ptr| and |*out_len| to the table
* of built-in |ASN1_STRING_TABLE| values. It is exported for testing. */
OPENSSL_EXPORT void asn1_get_string_table_for_testing(
const ASN1_STRING_TABLE **out_ptr, size_t *out_len);
acvp: add CMAC-AES support. Change by Dan Janni. Change-Id: I3f059e7b1a822c6f97128ca92a693499a3f7fa8f Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/41984 Commit-Queue: Adam Langley <agl@google.com> Reviewed-by: David Benjamin <davidben@google.com>
5 years ago
#if defined(__cplusplus)
} /* extern C */
#endif
#endif /* OPENSSL_HEADER_ASN1_ASN1_LOCL_H */