From f753eb27d03c9900aa65c4568c0420334cd28aab Mon Sep 17 00:00:00 2001 From: Abseil Team Date: Wed, 7 Sep 2022 13:11:27 -0700 Subject: [PATCH] Add a missing dependency on :raw_logging_internal internal/stacktrace_x86-inl.inc includes internal/raw_logging.h and therefore needs a direct dependency to satisfy Bazel layering_check (Clang -fmodules-strict-decluse). Clang before https://reviews.llvm.org/D132779 does not report the issue becasue: * internal/stacktrace_x86-inl.inc is an .inc file and is not checked as a main file * internal/stacktrace_x86-inl.inc is a textual header and older Clang incorrectly considers there is no requesting module and suppresses the error. PiperOrigin-RevId: 472795469 Change-Id: Ia4ad667ea80b2590cef1adfd22af025c8df826ac --- absl/debugging/BUILD.bazel | 1 + absl/debugging/CMakeLists.txt | 1 + 2 files changed, 2 insertions(+) diff --git a/absl/debugging/BUILD.bazel b/absl/debugging/BUILD.bazel index 51262058..a40285c8 100644 --- a/absl/debugging/BUILD.bazel +++ b/absl/debugging/BUILD.bazel @@ -49,6 +49,7 @@ cc_library( ":debugging_internal", "//absl/base:config", "//absl/base:core_headers", + "//absl/base:raw_logging_internal", ], ) diff --git a/absl/debugging/CMakeLists.txt b/absl/debugging/CMakeLists.txt index d8207d6a..051e7017 100644 --- a/absl/debugging/CMakeLists.txt +++ b/absl/debugging/CMakeLists.txt @@ -41,6 +41,7 @@ absl_cc_library( absl::debugging_internal absl::config absl::core_headers + absl::raw_logging_internal PUBLIC )