Minor clang-tidy cleanups

using decl 'Pointee' is unused
missing #include <utility> for 'std::move'
missing #include <memory> for 'std::unique_ptr'

PiperOrigin-RevId: 460980847
Change-Id: I5ebfca39d6b93ef396b32d1b91a5d8748d43e018
pull/1223/head
Abseil Team 2 years ago committed by Copybara-Service
parent 305a0088ce
commit ef68bd3d31
  1. 16
      absl/utility/utility_test.cc

@ -1,4 +1,4 @@
// Copyright 2017 The Abseil Authors. // Copyright 2022 The Abseil Authors.
// //
// Licensed under the Apache License, Version 2.0 (the "License"); // Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License. // you may not use this file except in compliance with the License.
@ -14,10 +14,12 @@
#include "absl/utility/utility.h" #include "absl/utility/utility.h"
#include <memory>
#include <sstream> #include <sstream>
#include <string> #include <string>
#include <tuple> #include <tuple>
#include <type_traits> #include <type_traits>
#include <utility>
#include <vector> #include <vector>
#include "gmock/gmock.h" #include "gmock/gmock.h"
@ -35,10 +37,10 @@ namespace {
// Both the unused variables and the name length warnings are due to calls // Both the unused variables and the name length warnings are due to calls
// to absl::make_index_sequence with very large values, creating very long type // to absl::make_index_sequence with very large values, creating very long type
// names. The resulting warnings are so long they make build output unreadable. // names. The resulting warnings are so long they make build output unreadable.
#pragma warning( push ) #pragma warning(push)
#pragma warning( disable : 4503 ) // decorated name length exceeded #pragma warning(disable : 4503) // decorated name length exceeded
#pragma warning( disable : 4101 ) // unreferenced local variable #pragma warning(disable : 4101) // unreferenced local variable
#endif // _MSC_VER #endif // _MSC_VER
using ::testing::ElementsAre; using ::testing::ElementsAre;
using ::testing::Pointee; using ::testing::Pointee;
@ -227,8 +229,7 @@ TEST(ApplyTest, NonCopyableArgument) {
} }
TEST(ApplyTest, NonCopyableResult) { TEST(ApplyTest, NonCopyableResult) {
EXPECT_THAT(absl::apply(Factory, std::make_tuple(42)), EXPECT_THAT(absl::apply(Factory, std::make_tuple(42)), Pointee(42));
::testing::Pointee(42));
} }
TEST(ApplyTest, VoidResult) { absl::apply(NoOp, std::tuple<>()); } TEST(ApplyTest, VoidResult) { absl::apply(NoOp, std::tuple<>()); }
@ -373,4 +374,3 @@ TEST(MakeFromTupleTest, Pair) {
} }
} // namespace } // namespace

Loading…
Cancel
Save