Tweak the signature of status_internal::MakeCheckFailString as part of an upcoming change

PiperOrigin-RevId: 454251164
Change-Id: I256b7a662478f9317a4133ec209fa5488a942886

absl/status/internal/status_internal.h

@@ -15,6 +15,7 @@
 #define ABSL_STATUS_INTERNAL_STATUS_INTERNAL_H_
 
 #include <string>
+#include <utility>
 
 #include "absl/base/attributes.h"
 #include "absl/container/inlined_vector.h"
@@ -70,12 +71,11 @@ struct StatusRep {
 
 absl::StatusCode MapToLocalCode(int value);
 
-// If `status` is not OK, returns a pointer to a newly-allocated string with the
+// Returns a pointer to a newly-allocated string with the given `prefix`,
-// given `prefix`, suitable for output as an error message in assertion/CHECK()
+// suitable for output as an error message in assertion/`CHECK()` failures.
-// failures. Otherwise returns nullptr.
 //
 // This is an internal implementation detail for Abseil logging.
-std::string* MakeCheckFailString(const absl::Status& status,
+std::string* MakeCheckFailString(const absl::Status* status,
                                  const char* prefix);
 
 }  // namespace status_internal

absl/status/status.cc

@@ -603,12 +603,11 @@ Status ErrnoToStatus(int error_number, absl::string_view message) {
 
 namespace status_internal {
 
-std::string* MakeCheckFailString(const absl::Status& status,
+std::string* MakeCheckFailString(const absl::Status* status,
                                  const char* prefix) {
-  if (status.ok()) { return nullptr; }
   return new std::string(
       absl::StrCat(prefix, " (",
-                   status.ToString(StatusToStringMode::kWithEverything), ")"));
+                   status->ToString(StatusToStringMode::kWithEverything), ")"));
 }
 
 }  // namespace status_internal