Fix MSVC version checking in lifetime_test.cc

pull/1307/head
Arkady Shapkin 2 years ago committed by GitHub
parent 1649c037c5
commit d36d20c051
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
  1. 5
      absl/synchronization/lifetime_test.cc

@ -123,10 +123,9 @@ class OnDestruction {
};
// These tests require that the compiler correctly supports C++11 constant
// initialization... but MSVC has a known regression since v19.10:
// initialization... but MSVC has a known regression since v19.10 till v19.25:
// https://developercommunity.visualstudio.com/content/problem/336946/class-with-constexpr-constructor-not-using-static.html
// TODO(epastor): Limit the affected range once MSVC fixes this bug.
#if defined(__clang__) || !(defined(_MSC_VER) && _MSC_VER > 1900)
#if defined(__clang__) || !(defined(_MSC_VER) && _MSC_VER > 1900 && _MSC_VER < 1925)
// kConstInit
// Test early usage. (Declaration comes first; definitions must appear after
// the test runner.)

Loading…
Cancel
Save