From 530cd52f585c9d31b2b28cea7e53915af7a878e3 Mon Sep 17 00:00:00 2001 From: Greg Falcon Date: Tue, 13 Sep 2022 11:44:56 -0700 Subject: [PATCH] Add `-llog` to linker options when building log_sink_set in logging internals. In Android builds this library calls __android_log_write directly, and so needs this linker dep. PiperOrigin-RevId: 474080654 Change-Id: I19f6ac4f78e635541ccad08ec9e553adfe609b3f --- absl/log/CMakeLists.txt | 1 + absl/log/internal/BUILD.bazel | 5 ++++- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/absl/log/CMakeLists.txt b/absl/log/CMakeLists.txt index a96e5195..a803ca8f 100644 --- a/absl/log/CMakeLists.txt +++ b/absl/log/CMakeLists.txt @@ -173,6 +173,7 @@ absl_cc_library( ${ABSL_DEFAULT_COPTS} LINKOPTS ${ABSL_DEFAULT_LINKOPTS} + $<$:-llog> DEPS absl::base absl::cleanup diff --git a/absl/log/internal/BUILD.bazel b/absl/log/internal/BUILD.bazel index 54b221bb..19243a58 100644 --- a/absl/log/internal/BUILD.bazel +++ b/absl/log/internal/BUILD.bazel @@ -163,7 +163,10 @@ cc_library( srcs = ["log_sink_set.cc"], hdrs = ["log_sink_set.h"], copts = ABSL_DEFAULT_COPTS, - linkopts = ABSL_DEFAULT_LINKOPTS, + linkopts = ABSL_DEFAULT_LINKOPTS + select({ + "//conditions:default": [], + "@platforms//os:android": ["-llog"], + }), deps = [ ":config", ":globals",