Removed "warning treated as error" flag from MSVC (#153)

* Removed "warning treated as error" flag from MSVC

Setting the "warning treated as error" flag in public projects is problematic, because it can lead to compilation errors for users, when the compiler adds new warnings. This however, does not mean that the project has a bug, only that it emits a new warning. Nevertheless it still fails to compile.
pull/163/head
vocaviking 6 years ago committed by Derek Mauro
parent 083d04dd4a
commit 29ff6d4860
  1. 2
      CMakeLists.txt
  2. 1
      absl/copts.bzl

@ -32,7 +32,7 @@ if (MSVC)
# /wd4244 conversion from 'type1' to 'type2'
# /wd4267 conversion from 'size_t' to 'type2'
# /wd4800 force value to bool 'true' or 'false' (performance warning)
add_compile_options(/W3 /WX /wd4005 /wd4068 /wd4244 /wd4267 /wd4800)
add_compile_options(/W3 /wd4005 /wd4068 /wd4244 /wd4267 /wd4800)
add_definitions(/DNOMINMAX /DWIN32_LEAN_AND_MEAN=1 /D_CRT_SECURE_NO_WARNINGS /D_SCL_SECURE_NO_WARNINGS)
else()
set(ABSL_STD_CXX_FLAG "-std=c++11" CACHE STRING "c++ std flag (default: c++11)")

@ -116,7 +116,6 @@ LLVM_TEST_FLAGS = [
MSVC_FLAGS = [
"/W3",
"/WX",
"/wd4005", # macro-redefinition
"/wd4068", # unknown pragma
"/wd4244", # conversion from 'type1' to 'type2', possible loss of data

Loading…
Cancel
Save