Export of internal Abseil changes

--
3358c3cca1c3770fb5d50e743ac56547af813561 by Dino Radakovic <dinor@google.com>:

Add ABSL_SKIP_TIME_TESTS_BROKEN_ON_MSVC_OPT guard to TEST(Duration, Multiplication)

PiperOrigin-RevId: 432350431
Change-Id: I28a26a12665e3e9a9ebdf50d0249eafa8336c585

--
af631611681a298c305578d5049757ec8ced03ab by Dino Radakovic <dinor@google.com>:

Add config macro for optional skipping absl/time:time_test cases that fail on MSVC optimized builds

PiperOrigin-RevId: 432252533
Change-Id: Ic3879ccdd8e30945a1a2e980e9ae246bcef8d7bd
GitOrigin-RevId: 3358c3cca1c3770fb5d50e743ac56547af813561
pull/1119/head
Abseil Team 3 years ago committed by dinord
parent ec33f404bb
commit 04bde89e5c
  1. 35
      absl/time/duration_test.cc
  2. 10
      absl/time/time_test.cc

@ -349,6 +349,11 @@ TEST(Duration, ToChrono) {
}
TEST(Duration, FactoryOverloads) {
#if defined(ABSL_SKIP_TIME_TESTS_BROKEN_ON_MSVC_OPT) && \
ABSL_SKIP_TIME_TESTS_BROKEN_ON_MSVC_OPT
GTEST_SKIP();
#endif
enum E { kOne = 1 };
#define TEST_FACTORY_OVERLOADS(NAME) \
EXPECT_EQ(1, NAME(kOne) / NAME(kOne)); \
@ -879,6 +884,11 @@ TEST(Duration, RelationalOperators) {
}
TEST(Duration, Addition) {
#if defined(ABSL_SKIP_TIME_TESTS_BROKEN_ON_MSVC_OPT) && \
ABSL_SKIP_TIME_TESTS_BROKEN_ON_MSVC_OPT
GTEST_SKIP();
#endif
#define TEST_ADD_OPS(UNIT) \
do { \
EXPECT_EQ(UNIT(2), UNIT(1) + UNIT(1)); \
@ -972,6 +982,11 @@ TEST(Duration, Negation) {
}
TEST(Duration, AbsoluteValue) {
#if defined(ABSL_SKIP_TIME_TESTS_BROKEN_ON_MSVC_OPT) && \
ABSL_SKIP_TIME_TESTS_BROKEN_ON_MSVC_OPT
GTEST_SKIP();
#endif
EXPECT_EQ(absl::ZeroDuration(), AbsDuration(absl::ZeroDuration()));
EXPECT_EQ(absl::Seconds(1), AbsDuration(absl::Seconds(1)));
EXPECT_EQ(absl::Seconds(1), AbsDuration(absl::Seconds(-1)));
@ -989,6 +1004,11 @@ TEST(Duration, AbsoluteValue) {
}
TEST(Duration, Multiplication) {
#if defined(ABSL_SKIP_TIME_TESTS_BROKEN_ON_MSVC_OPT) && \
ABSL_SKIP_TIME_TESTS_BROKEN_ON_MSVC_OPT
GTEST_SKIP();
#endif
#define TEST_MUL_OPS(UNIT) \
do { \
EXPECT_EQ(UNIT(5), UNIT(2) * 2.5); \
@ -1241,6 +1261,11 @@ TEST(Duration, RoundTripUnits) {
}
TEST(Duration, TruncConversions) {
#if defined(ABSL_SKIP_TIME_TESTS_BROKEN_ON_MSVC_OPT) && \
ABSL_SKIP_TIME_TESTS_BROKEN_ON_MSVC_OPT
GTEST_SKIP();
#endif
// Tests ToTimespec()/DurationFromTimespec()
const struct {
absl::Duration d;
@ -1537,6 +1562,11 @@ TEST(Duration, ConversionSaturation) {
}
TEST(Duration, FormatDuration) {
#if defined(ABSL_SKIP_TIME_TESTS_BROKEN_ON_MSVC_OPT) && \
ABSL_SKIP_TIME_TESTS_BROKEN_ON_MSVC_OPT
GTEST_SKIP();
#endif
// Example from Go's docs.
EXPECT_EQ("72h3m0.5s",
absl::FormatDuration(absl::Hours(72) + absl::Minutes(3) +
@ -1671,6 +1701,11 @@ TEST(Duration, FormatDuration) {
}
TEST(Duration, ParseDuration) {
#if defined(ABSL_SKIP_TIME_TESTS_BROKEN_ON_MSVC_OPT) && \
ABSL_SKIP_TIME_TESTS_BROKEN_ON_MSVC_OPT
GTEST_SKIP();
#endif
absl::Duration d;
// No specified unit. Should only work for zero and infinity.

@ -377,6 +377,11 @@ TEST(Time, FloorConversion) {
}
TEST(Time, RoundtripConversion) {
#if defined(ABSL_SKIP_TIME_TESTS_BROKEN_ON_MSVC_OPT) && \
ABSL_SKIP_TIME_TESTS_BROKEN_ON_MSVC_OPT
GTEST_SKIP();
#endif
#define TEST_CONVERSION_ROUND_TRIP(SOURCE, FROM, TO, MATCHER) \
EXPECT_THAT(TO(FROM(SOURCE)), MATCHER(SOURCE))
@ -558,6 +563,11 @@ TEST(Time, FromChrono) {
}
TEST(Time, ToChronoTime) {
#if defined(ABSL_SKIP_TIME_TESTS_BROKEN_ON_MSVC_OPT) && \
ABSL_SKIP_TIME_TESTS_BROKEN_ON_MSVC_OPT
GTEST_SKIP();
#endif
EXPECT_EQ(std::chrono::system_clock::from_time_t(-1),
absl::ToChronoTime(absl::FromTimeT(-1)));
EXPECT_EQ(std::chrono::system_clock::from_time_t(0),

Loading…
Cancel
Save