|
|
|
// Copyright 2019 The Abseil Authors.
|
|
|
|
//
|
|
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
|
|
// you may not use this file except in compliance with the License.
|
|
|
|
// You may obtain a copy of the License at
|
|
|
|
//
|
|
|
|
// https://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
//
|
|
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
|
|
// See the License for the specific language governing permissions and
|
|
|
|
// limitations under the License.
|
|
|
|
//
|
|
|
|
#ifndef ABSL_RANDOM_INTERNAL_UNIFORM_HELPER_H_
|
|
|
|
#define ABSL_RANDOM_INTERNAL_UNIFORM_HELPER_H_
|
|
|
|
|
|
|
|
#include <cmath>
|
|
|
|
#include <limits>
|
|
|
|
#include <type_traits>
|
|
|
|
|
Export of internal Abseil changes
--
7d0468a6610ed85586d5c87fd65de8dac5118923 by Derek Mauro <dmauro@google.com>:
Import of CCTZ from GitHub.
PiperOrigin-RevId: 313226473
--
1131ef6d116f5ce7d46537a82f300ea06dcaaa53 by Gennadiy Rozental <rogeeff@google.com>:
Migrate internal interface to use mutable references.
PiperOrigin-RevId: 312931131
--
96225212a9f5fbd0b38c71fe65539164992c7c3b by Laramie Leavitt <lar@google.com>:
Remove random/internal/distributions.h
This file was something of an historical artifact. All of the related
code has either been removed or migraged, and so the only remaining type
belongs with uniform_helper.h, as it is used to infer the return type
of the absl::Uniform method in a few cases.
PiperOrigin-RevId: 312878173
--
6dcbd5be58ad425e08740ff64088373ee7fe4a72 by Mark Barolak <mbar@google.com>:
Release the StrFormat test case for Cords to open source.
PiperOrigin-RevId: 312707974
--
34484d18dfb63a0a7ad6e2aaeb570e33592968be by Abseil Team <absl-team@google.com>:
Let Cord::Cord(string&&), Cord::operator=(string&&),
Cord::Append(string&&), and Cord::Prepend(string&&) steal string data
and embed it into the Cord as a single external chunk, instead of
copying it into flat chunks (at most 4083-byte each).
Stealing string data is faster, but it creates a long chunk, which leads
to a higher more memory usage if its subcords are created and outlive
the whole Cord.
These functions revert to copying the data if any of the following
conditions holds:
- string size is at most kMaxBytesToCopy (511), to avoid the overhead
of an external chunk for short strings;
- less than half of string capacity is used, to avoid pinning to much
unused memory.
PiperOrigin-RevId: 312683785
GitOrigin-RevId: 7d0468a6610ed85586d5c87fd65de8dac5118923
Change-Id: If79b5a1dfe6d53a8ddddbc7da84338f11fc4cfa3
5 years ago
|
|
|
#include "absl/base/config.h"
|
|
|
|
#include "absl/meta/type_traits.h"
|
Export of internal Abseil changes
--
7d0468a6610ed85586d5c87fd65de8dac5118923 by Derek Mauro <dmauro@google.com>:
Import of CCTZ from GitHub.
PiperOrigin-RevId: 313226473
--
1131ef6d116f5ce7d46537a82f300ea06dcaaa53 by Gennadiy Rozental <rogeeff@google.com>:
Migrate internal interface to use mutable references.
PiperOrigin-RevId: 312931131
--
96225212a9f5fbd0b38c71fe65539164992c7c3b by Laramie Leavitt <lar@google.com>:
Remove random/internal/distributions.h
This file was something of an historical artifact. All of the related
code has either been removed or migraged, and so the only remaining type
belongs with uniform_helper.h, as it is used to infer the return type
of the absl::Uniform method in a few cases.
PiperOrigin-RevId: 312878173
--
6dcbd5be58ad425e08740ff64088373ee7fe4a72 by Mark Barolak <mbar@google.com>:
Release the StrFormat test case for Cords to open source.
PiperOrigin-RevId: 312707974
--
34484d18dfb63a0a7ad6e2aaeb570e33592968be by Abseil Team <absl-team@google.com>:
Let Cord::Cord(string&&), Cord::operator=(string&&),
Cord::Append(string&&), and Cord::Prepend(string&&) steal string data
and embed it into the Cord as a single external chunk, instead of
copying it into flat chunks (at most 4083-byte each).
Stealing string data is faster, but it creates a long chunk, which leads
to a higher more memory usage if its subcords are created and outlive
the whole Cord.
These functions revert to copying the data if any of the following
conditions holds:
- string size is at most kMaxBytesToCopy (511), to avoid the overhead
of an external chunk for short strings;
- less than half of string capacity is used, to avoid pinning to much
unused memory.
PiperOrigin-RevId: 312683785
GitOrigin-RevId: 7d0468a6610ed85586d5c87fd65de8dac5118923
Change-Id: If79b5a1dfe6d53a8ddddbc7da84338f11fc4cfa3
5 years ago
|
|
|
#include "absl/random/internal/traits.h"
|
|
|
|
|
|
|
|
namespace absl {
|
|
|
|
ABSL_NAMESPACE_BEGIN
|
Export of internal Abseil changes
--
7d0468a6610ed85586d5c87fd65de8dac5118923 by Derek Mauro <dmauro@google.com>:
Import of CCTZ from GitHub.
PiperOrigin-RevId: 313226473
--
1131ef6d116f5ce7d46537a82f300ea06dcaaa53 by Gennadiy Rozental <rogeeff@google.com>:
Migrate internal interface to use mutable references.
PiperOrigin-RevId: 312931131
--
96225212a9f5fbd0b38c71fe65539164992c7c3b by Laramie Leavitt <lar@google.com>:
Remove random/internal/distributions.h
This file was something of an historical artifact. All of the related
code has either been removed or migraged, and so the only remaining type
belongs with uniform_helper.h, as it is used to infer the return type
of the absl::Uniform method in a few cases.
PiperOrigin-RevId: 312878173
--
6dcbd5be58ad425e08740ff64088373ee7fe4a72 by Mark Barolak <mbar@google.com>:
Release the StrFormat test case for Cords to open source.
PiperOrigin-RevId: 312707974
--
34484d18dfb63a0a7ad6e2aaeb570e33592968be by Abseil Team <absl-team@google.com>:
Let Cord::Cord(string&&), Cord::operator=(string&&),
Cord::Append(string&&), and Cord::Prepend(string&&) steal string data
and embed it into the Cord as a single external chunk, instead of
copying it into flat chunks (at most 4083-byte each).
Stealing string data is faster, but it creates a long chunk, which leads
to a higher more memory usage if its subcords are created and outlive
the whole Cord.
These functions revert to copying the data if any of the following
conditions holds:
- string size is at most kMaxBytesToCopy (511), to avoid the overhead
of an external chunk for short strings;
- less than half of string capacity is used, to avoid pinning to much
unused memory.
PiperOrigin-RevId: 312683785
GitOrigin-RevId: 7d0468a6610ed85586d5c87fd65de8dac5118923
Change-Id: If79b5a1dfe6d53a8ddddbc7da84338f11fc4cfa3
5 years ago
|
|
|
|
|
|
|
template <typename IntType>
|
|
|
|
class uniform_int_distribution;
|
|
|
|
|
|
|
|
template <typename RealType>
|
|
|
|
class uniform_real_distribution;
|
|
|
|
|
|
|
|
// Interval tag types which specify whether the interval is open or closed
|
|
|
|
// on either boundary.
|
|
|
|
|
|
|
|
namespace random_internal {
|
|
|
|
template <typename T>
|
|
|
|
struct TagTypeCompare {};
|
|
|
|
|
|
|
|
template <typename T>
|
|
|
|
constexpr bool operator==(TagTypeCompare<T>, TagTypeCompare<T>) {
|
|
|
|
// Tags are mono-states. They always compare equal.
|
|
|
|
return true;
|
|
|
|
}
|
|
|
|
template <typename T>
|
|
|
|
constexpr bool operator!=(TagTypeCompare<T>, TagTypeCompare<T>) {
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
|
|
|
} // namespace random_internal
|
|
|
|
|
|
|
|
struct IntervalClosedClosedTag
|
|
|
|
: public random_internal::TagTypeCompare<IntervalClosedClosedTag> {};
|
|
|
|
struct IntervalClosedOpenTag
|
|
|
|
: public random_internal::TagTypeCompare<IntervalClosedOpenTag> {};
|
|
|
|
struct IntervalOpenClosedTag
|
|
|
|
: public random_internal::TagTypeCompare<IntervalOpenClosedTag> {};
|
|
|
|
struct IntervalOpenOpenTag
|
|
|
|
: public random_internal::TagTypeCompare<IntervalOpenOpenTag> {};
|
|
|
|
|
|
|
|
namespace random_internal {
|
Export of internal Abseil changes
--
7d0468a6610ed85586d5c87fd65de8dac5118923 by Derek Mauro <dmauro@google.com>:
Import of CCTZ from GitHub.
PiperOrigin-RevId: 313226473
--
1131ef6d116f5ce7d46537a82f300ea06dcaaa53 by Gennadiy Rozental <rogeeff@google.com>:
Migrate internal interface to use mutable references.
PiperOrigin-RevId: 312931131
--
96225212a9f5fbd0b38c71fe65539164992c7c3b by Laramie Leavitt <lar@google.com>:
Remove random/internal/distributions.h
This file was something of an historical artifact. All of the related
code has either been removed or migraged, and so the only remaining type
belongs with uniform_helper.h, as it is used to infer the return type
of the absl::Uniform method in a few cases.
PiperOrigin-RevId: 312878173
--
6dcbd5be58ad425e08740ff64088373ee7fe4a72 by Mark Barolak <mbar@google.com>:
Release the StrFormat test case for Cords to open source.
PiperOrigin-RevId: 312707974
--
34484d18dfb63a0a7ad6e2aaeb570e33592968be by Abseil Team <absl-team@google.com>:
Let Cord::Cord(string&&), Cord::operator=(string&&),
Cord::Append(string&&), and Cord::Prepend(string&&) steal string data
and embed it into the Cord as a single external chunk, instead of
copying it into flat chunks (at most 4083-byte each).
Stealing string data is faster, but it creates a long chunk, which leads
to a higher more memory usage if its subcords are created and outlive
the whole Cord.
These functions revert to copying the data if any of the following
conditions holds:
- string size is at most kMaxBytesToCopy (511), to avoid the overhead
of an external chunk for short strings;
- less than half of string capacity is used, to avoid pinning to much
unused memory.
PiperOrigin-RevId: 312683785
GitOrigin-RevId: 7d0468a6610ed85586d5c87fd65de8dac5118923
Change-Id: If79b5a1dfe6d53a8ddddbc7da84338f11fc4cfa3
5 years ago
|
|
|
|
|
|
|
// In the absence of an explicitly provided return-type, the template
|
|
|
|
// "uniform_inferred_return_t<A, B>" is used to derive a suitable type, based on
|
|
|
|
// the data-types of the endpoint-arguments {A lo, B hi}.
|
|
|
|
//
|
|
|
|
// Given endpoints {A lo, B hi}, one of {A, B} will be chosen as the
|
|
|
|
// return-type, if one type can be implicitly converted into the other, in a
|
|
|
|
// lossless way. The template "is_widening_convertible" implements the
|
|
|
|
// compile-time logic for deciding if such a conversion is possible.
|
|
|
|
//
|
|
|
|
// If no such conversion between {A, B} exists, then the overload for
|
|
|
|
// absl::Uniform() will be discarded, and the call will be ill-formed.
|
|
|
|
// Return-type for absl::Uniform() when the return-type is inferred.
|
|
|
|
template <typename A, typename B>
|
|
|
|
using uniform_inferred_return_t =
|
|
|
|
absl::enable_if_t<absl::disjunction<is_widening_convertible<A, B>,
|
|
|
|
is_widening_convertible<B, A>>::value,
|
|
|
|
typename std::conditional<
|
|
|
|
is_widening_convertible<A, B>::value, B, A>::type>;
|
|
|
|
|
|
|
|
// The functions
|
|
|
|
// uniform_lower_bound(tag, a, b)
|
|
|
|
// and
|
|
|
|
// uniform_upper_bound(tag, a, b)
|
|
|
|
// are used as implementation-details for absl::Uniform().
|
|
|
|
//
|
|
|
|
// Conceptually,
|
|
|
|
// [a, b] == [uniform_lower_bound(IntervalClosedClosed, a, b),
|
|
|
|
// uniform_upper_bound(IntervalClosedClosed, a, b)]
|
|
|
|
// (a, b) == [uniform_lower_bound(IntervalOpenOpen, a, b),
|
|
|
|
// uniform_upper_bound(IntervalOpenOpen, a, b)]
|
|
|
|
// [a, b) == [uniform_lower_bound(IntervalClosedOpen, a, b),
|
|
|
|
// uniform_upper_bound(IntervalClosedOpen, a, b)]
|
|
|
|
// (a, b] == [uniform_lower_bound(IntervalOpenClosed, a, b),
|
|
|
|
// uniform_upper_bound(IntervalOpenClosed, a, b)]
|
|
|
|
//
|
|
|
|
template <typename IntType, typename Tag>
|
|
|
|
typename absl::enable_if_t<
|
|
|
|
absl::conjunction<
|
|
|
|
std::is_integral<IntType>,
|
|
|
|
absl::disjunction<std::is_same<Tag, IntervalOpenClosedTag>,
|
|
|
|
std::is_same<Tag, IntervalOpenOpenTag>>>::value,
|
|
|
|
IntType>
|
|
|
|
uniform_lower_bound(Tag, IntType a, IntType) {
|
Export of internal Abseil changes
--
790f9061df340cd900e8da70e66c363f7af3c2eb by Abseil Team <absl-team@google.com>:
Add support for rvalue reference to function types.
PiperOrigin-RevId: 324508531
--
51fe201dbb41a3ebc3d49ff65250b5f464279d43 by Abseil Team <absl-team@google.com>:
Cleaning up function comment style; no substantive change.
PiperOrigin-RevId: 324497401
--
da8595d5266577d0c170528d12f6de17b8affcc2 by Abseil Team <absl-team@google.com>:
Add support for demangling GNU vector types.
PiperOrigin-RevId: 324494559
--
0cb0acf88c1750f6963c9cb85249f9b4f0bd5104 by Abseil Team <absl-team@google.com>:
Add support for thread-local types.
PiperOrigin-RevId: 324491183
--
c676bc8380560599cd26f7f231e04e6be532e904 by Abseil Team <absl-team@google.com>:
Add support for demangling "Du" (char8_t).
PiperOrigin-RevId: 324441607
--
b218bf6467bc62b327214782c881e8224ad91509 by Abseil Team <absl-team@google.com>:
Update doc comments in header of `any.h` to reflect that `absl::variant` has been released.
PiperOrigin-RevId: 324431690
--
e5b579f3f1aa598c1f62e71dba7103b98811de59 by Laramie Leavitt <lar@google.com>:
Bugfix: Fix bounds in absl::Uniform where one of the bounds is min/max.
When absl::Uniform(rng, tag, a, b) is called, the tag is used in conjunction with the type to determine whether or not to manipulate the bounds to make them inclusive or exclusive through the uniform_*_bound functions. Unfortunately, at limits of the interval the function was not well behaved.
The previous implementation used wrapping arithmetic. This causes incorrect bounds computation at the extremes (numeric_limits::min / numeric_limits::max) the bound would wrap.
Improve this situation by:
1/ Changing the uniform_*_bound functions to use saturating arithmetic instead of wrapping, thus in the unsigned case, the upper_bound of IntervalOpenOpen for 0 is now 0, rather than numeric_limits::max, likewise for the lower bound.
2/ Adjusting the hi/lo checks in the distributions. When the interval is empty, such as for absl::Uniform(absl::IntervalOpenOpen, gen, 1, 0), the return value is somewhat nonsensical. Now absl::Uniform more consistently returns the low input rather than any adjusted input. In the above case, that means that 1 is returned rather than 2.
NOTE: Calls to absl::Uniform where the resolved upper bound is < the lower bound are still ill-formed and should be avoided.
3/ Adding better tests.
The underlying uniform_*_distribution classes are not affected.
PiperOrigin-RevId: 324240873
GitOrigin-RevId: 790f9061df340cd900e8da70e66c363f7af3c2eb
Change-Id: I2a2208650ea3135c575e200b868ce1d275069fc8
4 years ago
|
|
|
return a < (std::numeric_limits<IntType>::max)() ? (a + 1) : a;
|
|
|
|
}
|
|
|
|
|
|
|
|
template <typename FloatType, typename Tag>
|
|
|
|
typename absl::enable_if_t<
|
|
|
|
absl::conjunction<
|
|
|
|
std::is_floating_point<FloatType>,
|
|
|
|
absl::disjunction<std::is_same<Tag, IntervalOpenClosedTag>,
|
|
|
|
std::is_same<Tag, IntervalOpenOpenTag>>>::value,
|
|
|
|
FloatType>
|
|
|
|
uniform_lower_bound(Tag, FloatType a, FloatType b) {
|
|
|
|
return std::nextafter(a, b);
|
|
|
|
}
|
|
|
|
|
|
|
|
template <typename NumType, typename Tag>
|
|
|
|
typename absl::enable_if_t<
|
|
|
|
absl::disjunction<std::is_same<Tag, IntervalClosedClosedTag>,
|
|
|
|
std::is_same<Tag, IntervalClosedOpenTag>>::value,
|
|
|
|
NumType>
|
|
|
|
uniform_lower_bound(Tag, NumType a, NumType) {
|
|
|
|
return a;
|
|
|
|
}
|
|
|
|
|
|
|
|
template <typename IntType, typename Tag>
|
|
|
|
typename absl::enable_if_t<
|
|
|
|
absl::conjunction<
|
|
|
|
std::is_integral<IntType>,
|
|
|
|
absl::disjunction<std::is_same<Tag, IntervalClosedOpenTag>,
|
|
|
|
std::is_same<Tag, IntervalOpenOpenTag>>>::value,
|
|
|
|
IntType>
|
|
|
|
uniform_upper_bound(Tag, IntType, IntType b) {
|
Export of internal Abseil changes
--
790f9061df340cd900e8da70e66c363f7af3c2eb by Abseil Team <absl-team@google.com>:
Add support for rvalue reference to function types.
PiperOrigin-RevId: 324508531
--
51fe201dbb41a3ebc3d49ff65250b5f464279d43 by Abseil Team <absl-team@google.com>:
Cleaning up function comment style; no substantive change.
PiperOrigin-RevId: 324497401
--
da8595d5266577d0c170528d12f6de17b8affcc2 by Abseil Team <absl-team@google.com>:
Add support for demangling GNU vector types.
PiperOrigin-RevId: 324494559
--
0cb0acf88c1750f6963c9cb85249f9b4f0bd5104 by Abseil Team <absl-team@google.com>:
Add support for thread-local types.
PiperOrigin-RevId: 324491183
--
c676bc8380560599cd26f7f231e04e6be532e904 by Abseil Team <absl-team@google.com>:
Add support for demangling "Du" (char8_t).
PiperOrigin-RevId: 324441607
--
b218bf6467bc62b327214782c881e8224ad91509 by Abseil Team <absl-team@google.com>:
Update doc comments in header of `any.h` to reflect that `absl::variant` has been released.
PiperOrigin-RevId: 324431690
--
e5b579f3f1aa598c1f62e71dba7103b98811de59 by Laramie Leavitt <lar@google.com>:
Bugfix: Fix bounds in absl::Uniform where one of the bounds is min/max.
When absl::Uniform(rng, tag, a, b) is called, the tag is used in conjunction with the type to determine whether or not to manipulate the bounds to make them inclusive or exclusive through the uniform_*_bound functions. Unfortunately, at limits of the interval the function was not well behaved.
The previous implementation used wrapping arithmetic. This causes incorrect bounds computation at the extremes (numeric_limits::min / numeric_limits::max) the bound would wrap.
Improve this situation by:
1/ Changing the uniform_*_bound functions to use saturating arithmetic instead of wrapping, thus in the unsigned case, the upper_bound of IntervalOpenOpen for 0 is now 0, rather than numeric_limits::max, likewise for the lower bound.
2/ Adjusting the hi/lo checks in the distributions. When the interval is empty, such as for absl::Uniform(absl::IntervalOpenOpen, gen, 1, 0), the return value is somewhat nonsensical. Now absl::Uniform more consistently returns the low input rather than any adjusted input. In the above case, that means that 1 is returned rather than 2.
NOTE: Calls to absl::Uniform where the resolved upper bound is < the lower bound are still ill-formed and should be avoided.
3/ Adding better tests.
The underlying uniform_*_distribution classes are not affected.
PiperOrigin-RevId: 324240873
GitOrigin-RevId: 790f9061df340cd900e8da70e66c363f7af3c2eb
Change-Id: I2a2208650ea3135c575e200b868ce1d275069fc8
4 years ago
|
|
|
return b > (std::numeric_limits<IntType>::min)() ? (b - 1) : b;
|
|
|
|
}
|
|
|
|
|
|
|
|
template <typename FloatType, typename Tag>
|
|
|
|
typename absl::enable_if_t<
|
|
|
|
absl::conjunction<
|
|
|
|
std::is_floating_point<FloatType>,
|
|
|
|
absl::disjunction<std::is_same<Tag, IntervalClosedOpenTag>,
|
|
|
|
std::is_same<Tag, IntervalOpenOpenTag>>>::value,
|
|
|
|
FloatType>
|
|
|
|
uniform_upper_bound(Tag, FloatType, FloatType b) {
|
|
|
|
return b;
|
|
|
|
}
|
|
|
|
|
|
|
|
template <typename IntType, typename Tag>
|
|
|
|
typename absl::enable_if_t<
|
|
|
|
absl::conjunction<
|
|
|
|
std::is_integral<IntType>,
|
|
|
|
absl::disjunction<std::is_same<Tag, IntervalClosedClosedTag>,
|
|
|
|
std::is_same<Tag, IntervalOpenClosedTag>>>::value,
|
|
|
|
IntType>
|
|
|
|
uniform_upper_bound(Tag, IntType, IntType b) {
|
|
|
|
return b;
|
|
|
|
}
|
|
|
|
|
|
|
|
template <typename FloatType, typename Tag>
|
|
|
|
typename absl::enable_if_t<
|
|
|
|
absl::conjunction<
|
|
|
|
std::is_floating_point<FloatType>,
|
|
|
|
absl::disjunction<std::is_same<Tag, IntervalClosedClosedTag>,
|
|
|
|
std::is_same<Tag, IntervalOpenClosedTag>>>::value,
|
|
|
|
FloatType>
|
|
|
|
uniform_upper_bound(Tag, FloatType, FloatType b) {
|
|
|
|
return std::nextafter(b, (std::numeric_limits<FloatType>::max)());
|
|
|
|
}
|
|
|
|
|
Export of internal Abseil changes
--
790f9061df340cd900e8da70e66c363f7af3c2eb by Abseil Team <absl-team@google.com>:
Add support for rvalue reference to function types.
PiperOrigin-RevId: 324508531
--
51fe201dbb41a3ebc3d49ff65250b5f464279d43 by Abseil Team <absl-team@google.com>:
Cleaning up function comment style; no substantive change.
PiperOrigin-RevId: 324497401
--
da8595d5266577d0c170528d12f6de17b8affcc2 by Abseil Team <absl-team@google.com>:
Add support for demangling GNU vector types.
PiperOrigin-RevId: 324494559
--
0cb0acf88c1750f6963c9cb85249f9b4f0bd5104 by Abseil Team <absl-team@google.com>:
Add support for thread-local types.
PiperOrigin-RevId: 324491183
--
c676bc8380560599cd26f7f231e04e6be532e904 by Abseil Team <absl-team@google.com>:
Add support for demangling "Du" (char8_t).
PiperOrigin-RevId: 324441607
--
b218bf6467bc62b327214782c881e8224ad91509 by Abseil Team <absl-team@google.com>:
Update doc comments in header of `any.h` to reflect that `absl::variant` has been released.
PiperOrigin-RevId: 324431690
--
e5b579f3f1aa598c1f62e71dba7103b98811de59 by Laramie Leavitt <lar@google.com>:
Bugfix: Fix bounds in absl::Uniform where one of the bounds is min/max.
When absl::Uniform(rng, tag, a, b) is called, the tag is used in conjunction with the type to determine whether or not to manipulate the bounds to make them inclusive or exclusive through the uniform_*_bound functions. Unfortunately, at limits of the interval the function was not well behaved.
The previous implementation used wrapping arithmetic. This causes incorrect bounds computation at the extremes (numeric_limits::min / numeric_limits::max) the bound would wrap.
Improve this situation by:
1/ Changing the uniform_*_bound functions to use saturating arithmetic instead of wrapping, thus in the unsigned case, the upper_bound of IntervalOpenOpen for 0 is now 0, rather than numeric_limits::max, likewise for the lower bound.
2/ Adjusting the hi/lo checks in the distributions. When the interval is empty, such as for absl::Uniform(absl::IntervalOpenOpen, gen, 1, 0), the return value is somewhat nonsensical. Now absl::Uniform more consistently returns the low input rather than any adjusted input. In the above case, that means that 1 is returned rather than 2.
NOTE: Calls to absl::Uniform where the resolved upper bound is < the lower bound are still ill-formed and should be avoided.
3/ Adding better tests.
The underlying uniform_*_distribution classes are not affected.
PiperOrigin-RevId: 324240873
GitOrigin-RevId: 790f9061df340cd900e8da70e66c363f7af3c2eb
Change-Id: I2a2208650ea3135c575e200b868ce1d275069fc8
4 years ago
|
|
|
// Returns whether the bounds are valid for the underlying distribution.
|
|
|
|
// Inputs must have already been resolved via uniform_*_bound calls.
|
|
|
|
//
|
|
|
|
// The c++ standard constraints in [rand.dist.uni.int] are listed as:
|
|
|
|
// requires: lo <= hi.
|
|
|
|
//
|
|
|
|
// In the uniform_int_distrubtion, {lo, hi} are closed, closed. Thus:
|
|
|
|
// [0, 0] is legal.
|
|
|
|
// [0, 0) is not legal, but [0, 1) is, which translates to [0, 0].
|
|
|
|
// (0, 1) is not legal, but (0, 2) is, which translates to [1, 1].
|
|
|
|
// (0, 0] is not legal, but (0, 1] is, which translates to [1, 1].
|
|
|
|
//
|
|
|
|
// The c++ standard constraints in [rand.dist.uni.real] are listed as:
|
|
|
|
// requires: lo <= hi.
|
|
|
|
// requires: (hi - lo) <= numeric_limits<T>::max()
|
|
|
|
//
|
|
|
|
// In the uniform_real_distribution, {lo, hi} are closed, open, Thus:
|
|
|
|
// [0, 0] is legal, which is [0, 0+epsilon).
|
|
|
|
// [0, 0) is legal.
|
|
|
|
// (0, 0) is not legal, but (0-epsilon, 0+epsilon) is.
|
|
|
|
// (0, 0] is not legal, but (0, 0+epsilon] is.
|
|
|
|
//
|
|
|
|
template <typename FloatType>
|
|
|
|
absl::enable_if_t<std::is_floating_point<FloatType>::value, bool>
|
|
|
|
is_uniform_range_valid(FloatType a, FloatType b) {
|
|
|
|
return a <= b && std::isfinite(b - a);
|
|
|
|
}
|
|
|
|
|
|
|
|
template <typename IntType>
|
|
|
|
absl::enable_if_t<std::is_integral<IntType>::value, bool>
|
|
|
|
is_uniform_range_valid(IntType a, IntType b) {
|
|
|
|
return a <= b;
|
|
|
|
}
|
|
|
|
|
Export of internal Abseil changes
--
7d0468a6610ed85586d5c87fd65de8dac5118923 by Derek Mauro <dmauro@google.com>:
Import of CCTZ from GitHub.
PiperOrigin-RevId: 313226473
--
1131ef6d116f5ce7d46537a82f300ea06dcaaa53 by Gennadiy Rozental <rogeeff@google.com>:
Migrate internal interface to use mutable references.
PiperOrigin-RevId: 312931131
--
96225212a9f5fbd0b38c71fe65539164992c7c3b by Laramie Leavitt <lar@google.com>:
Remove random/internal/distributions.h
This file was something of an historical artifact. All of the related
code has either been removed or migraged, and so the only remaining type
belongs with uniform_helper.h, as it is used to infer the return type
of the absl::Uniform method in a few cases.
PiperOrigin-RevId: 312878173
--
6dcbd5be58ad425e08740ff64088373ee7fe4a72 by Mark Barolak <mbar@google.com>:
Release the StrFormat test case for Cords to open source.
PiperOrigin-RevId: 312707974
--
34484d18dfb63a0a7ad6e2aaeb570e33592968be by Abseil Team <absl-team@google.com>:
Let Cord::Cord(string&&), Cord::operator=(string&&),
Cord::Append(string&&), and Cord::Prepend(string&&) steal string data
and embed it into the Cord as a single external chunk, instead of
copying it into flat chunks (at most 4083-byte each).
Stealing string data is faster, but it creates a long chunk, which leads
to a higher more memory usage if its subcords are created and outlive
the whole Cord.
These functions revert to copying the data if any of the following
conditions holds:
- string size is at most kMaxBytesToCopy (511), to avoid the overhead
of an external chunk for short strings;
- less than half of string capacity is used, to avoid pinning to much
unused memory.
PiperOrigin-RevId: 312683785
GitOrigin-RevId: 7d0468a6610ed85586d5c87fd65de8dac5118923
Change-Id: If79b5a1dfe6d53a8ddddbc7da84338f11fc4cfa3
5 years ago
|
|
|
// UniformDistribution selects either absl::uniform_int_distribution
|
|
|
|
// or absl::uniform_real_distribution depending on the NumType parameter.
|
|
|
|
template <typename NumType>
|
|
|
|
using UniformDistribution =
|
|
|
|
typename std::conditional<std::is_integral<NumType>::value,
|
|
|
|
absl::uniform_int_distribution<NumType>,
|
|
|
|
absl::uniform_real_distribution<NumType>>::type;
|
|
|
|
|
Export of internal Abseil changes
--
7d0468a6610ed85586d5c87fd65de8dac5118923 by Derek Mauro <dmauro@google.com>:
Import of CCTZ from GitHub.
PiperOrigin-RevId: 313226473
--
1131ef6d116f5ce7d46537a82f300ea06dcaaa53 by Gennadiy Rozental <rogeeff@google.com>:
Migrate internal interface to use mutable references.
PiperOrigin-RevId: 312931131
--
96225212a9f5fbd0b38c71fe65539164992c7c3b by Laramie Leavitt <lar@google.com>:
Remove random/internal/distributions.h
This file was something of an historical artifact. All of the related
code has either been removed or migraged, and so the only remaining type
belongs with uniform_helper.h, as it is used to infer the return type
of the absl::Uniform method in a few cases.
PiperOrigin-RevId: 312878173
--
6dcbd5be58ad425e08740ff64088373ee7fe4a72 by Mark Barolak <mbar@google.com>:
Release the StrFormat test case for Cords to open source.
PiperOrigin-RevId: 312707974
--
34484d18dfb63a0a7ad6e2aaeb570e33592968be by Abseil Team <absl-team@google.com>:
Let Cord::Cord(string&&), Cord::operator=(string&&),
Cord::Append(string&&), and Cord::Prepend(string&&) steal string data
and embed it into the Cord as a single external chunk, instead of
copying it into flat chunks (at most 4083-byte each).
Stealing string data is faster, but it creates a long chunk, which leads
to a higher more memory usage if its subcords are created and outlive
the whole Cord.
These functions revert to copying the data if any of the following
conditions holds:
- string size is at most kMaxBytesToCopy (511), to avoid the overhead
of an external chunk for short strings;
- less than half of string capacity is used, to avoid pinning to much
unused memory.
PiperOrigin-RevId: 312683785
GitOrigin-RevId: 7d0468a6610ed85586d5c87fd65de8dac5118923
Change-Id: If79b5a1dfe6d53a8ddddbc7da84338f11fc4cfa3
5 years ago
|
|
|
// UniformDistributionWrapper is used as the underlying distribution type
|
|
|
|
// by the absl::Uniform template function. It selects the proper Abseil
|
|
|
|
// uniform distribution and provides constructor overloads that match the
|
|
|
|
// expected parameter order as well as adjusting distribtuion bounds based
|
|
|
|
// on the tag.
|
|
|
|
template <typename NumType>
|
|
|
|
struct UniformDistributionWrapper : public UniformDistribution<NumType> {
|
|
|
|
template <typename TagType>
|
|
|
|
explicit UniformDistributionWrapper(TagType, NumType lo, NumType hi)
|
|
|
|
: UniformDistribution<NumType>(
|
|
|
|
uniform_lower_bound<NumType>(TagType{}, lo, hi),
|
|
|
|
uniform_upper_bound<NumType>(TagType{}, lo, hi)) {}
|
|
|
|
|
|
|
|
explicit UniformDistributionWrapper(NumType lo, NumType hi)
|
|
|
|
: UniformDistribution<NumType>(
|
|
|
|
uniform_lower_bound<NumType>(IntervalClosedOpenTag(), lo, hi),
|
|
|
|
uniform_upper_bound<NumType>(IntervalClosedOpenTag(), lo, hi)) {}
|
|
|
|
|
|
|
|
explicit UniformDistributionWrapper()
|
|
|
|
: UniformDistribution<NumType>(std::numeric_limits<NumType>::lowest(),
|
|
|
|
(std::numeric_limits<NumType>::max)()) {}
|
|
|
|
};
|
|
|
|
|
|
|
|
} // namespace random_internal
|
|
|
|
ABSL_NAMESPACE_END
|
|
|
|
} // namespace absl
|
|
|
|
|
|
|
|
#endif // ABSL_RANDOM_INTERNAL_UNIFORM_HELPER_H_
|