Export of internal Abseil changes.
--
22fa219d17b2281c0695642830c4300711bd65ea by CJ Johnson <johnsoncj@google.com>:
Rearrange the private method declarations in InlinedVector
PiperOrigin-RevId: 224202447
--
eed3c9f488f23b521bee41d3683eb6cc22517ded by Derek Mauro <dmauro@google.com>:
Fix leak_check target (it was always a no-op when LSAN isn't available).
Fixes https://github.com/abseil/abseil-cpp/issues/232
PiperOrigin-RevId: 224201634
--
fc08039e175204b14a9561f618fcfc0234586801 by Greg Falcon <gfalcon@google.com>:
Add parens around more invocations of min() and max() missed in my prior CL.
PiperOrigin-RevId: 224162430
--
0ec5476a8293c7796cd84928a1a558b14f14f222 by Abseil Team <absl-team@google.com>:
Update absl/numeric/CMakeLists.txt to use new functions
i.e. absl_cc_(library|test)
PiperOrigin-RevId: 224139165
--
2b46aa6fabb20c589661f8bbc84030ecf39ce394 by Abseil Team <absl-team@google.com>:
Update absl/meta/CMakeLists.txt to use new functions
i.e. absl_cc_(library|test)
PiperOrigin-RevId: 224117258
--
6c951c798f8c6903bd8793a8a4b5f69244be8aa9 by Abseil Team <absl-team@google.com>:
Fix 2 Unused C++ BUILD Dependencies
PiperOrigin-RevId: 224070093
--
0ee7bd191708708f91fc5209c197fd93f6e4a8b3 by Greg Falcon <gfalcon@google.com>:
Inside Abseil headers, wrap most invocations of methods and functions named `min` and `max` in parentheses, for better interoperability with Windows toolchains.
CCTZ fixes will appear in a follow-up CL.
PiperOrigin-RevId: 224051960
--
f562f56577b84a8bc07e5873775c01d068531bca by Jon Cohen <cohenjon@google.com>:
Generate Abseil compile options. The single source of truth is now absl/copts/copts.py
The way this works goes something like this:
copts.py acts as the configuration file. We use python because unlike JSON it allows comments. It has two maps in it: one from names to external flags, and one from names to internal flags.
generate_copts.py imports the maps and loops through them to write GENERATED_copts.bzl and GENERATED_AbseilCopts.cmake
AbseilConfigureCopts.cmake and configure_copts.bzl import their respective copts args and set the platform-appropriate copts into ABSL_DEFAULT_COPTS, ABSL_TEST_COPTS, ABSL_EXCEPTIONS_FLAG, and ABSL_EXCEPTIONS_LINKOPTS
For Bazel, each BUILD file load()s configure_copts.bzl
For CMake, AbseilHelpers.cmake include()s AbseilConfigureCopts.cmake to get the final copts and both inserts them as needed into legacy target rules and also makes them available to the rest of our CMakeLists.txt file. We may instead want to include() AbseilConfigureCopts.cmake directly into each CMakeLists.txt file for consistency, but I'm not sure what the deal is with cmake and include guards, or if they are even needed. That's also not as idiomatic -- CMake tends to use directory scope where globals set at a higher level CMakeLists.txt file are used in the subdirectory CMakeLists.txt files.
PiperOrigin-RevId: 224039419
--
f7402f6bb65037e668a7355f0a003f5c05a3b6a7 by Abseil Team <absl-team@google.com>:
Import of CCTZ from GitHub.
PiperOrigin-RevId: 224036622
GitOrigin-RevId: 22fa219d17b2281c0695642830c4300711bd65ea
Change-Id: I6b505360539ff2aef8aa30c51a5f7d55db1c75cf
6 years ago
|
|
|
"""Abseil compiler options.
|
|
|
|
|
|
|
|
|
|
This is the source of truth for Abseil compiler options. To modify Abseil
|
|
|
|
|
compilation options:
|
|
|
|
|
|
|
|
|
|
(1) Edit the appropriate list in this file based on the platform the flag is
|
|
|
|
|
needed on.
|
|
|
|
|
(2) Run `<path_to_absl>/copts/generate_copts.py`.
|
Export of internal Abseil changes.
--
22fa219d17b2281c0695642830c4300711bd65ea by CJ Johnson <johnsoncj@google.com>:
Rearrange the private method declarations in InlinedVector
PiperOrigin-RevId: 224202447
--
eed3c9f488f23b521bee41d3683eb6cc22517ded by Derek Mauro <dmauro@google.com>:
Fix leak_check target (it was always a no-op when LSAN isn't available).
Fixes https://github.com/abseil/abseil-cpp/issues/232
PiperOrigin-RevId: 224201634
--
fc08039e175204b14a9561f618fcfc0234586801 by Greg Falcon <gfalcon@google.com>:
Add parens around more invocations of min() and max() missed in my prior CL.
PiperOrigin-RevId: 224162430
--
0ec5476a8293c7796cd84928a1a558b14f14f222 by Abseil Team <absl-team@google.com>:
Update absl/numeric/CMakeLists.txt to use new functions
i.e. absl_cc_(library|test)
PiperOrigin-RevId: 224139165
--
2b46aa6fabb20c589661f8bbc84030ecf39ce394 by Abseil Team <absl-team@google.com>:
Update absl/meta/CMakeLists.txt to use new functions
i.e. absl_cc_(library|test)
PiperOrigin-RevId: 224117258
--
6c951c798f8c6903bd8793a8a4b5f69244be8aa9 by Abseil Team <absl-team@google.com>:
Fix 2 Unused C++ BUILD Dependencies
PiperOrigin-RevId: 224070093
--
0ee7bd191708708f91fc5209c197fd93f6e4a8b3 by Greg Falcon <gfalcon@google.com>:
Inside Abseil headers, wrap most invocations of methods and functions named `min` and `max` in parentheses, for better interoperability with Windows toolchains.
CCTZ fixes will appear in a follow-up CL.
PiperOrigin-RevId: 224051960
--
f562f56577b84a8bc07e5873775c01d068531bca by Jon Cohen <cohenjon@google.com>:
Generate Abseil compile options. The single source of truth is now absl/copts/copts.py
The way this works goes something like this:
copts.py acts as the configuration file. We use python because unlike JSON it allows comments. It has two maps in it: one from names to external flags, and one from names to internal flags.
generate_copts.py imports the maps and loops through them to write GENERATED_copts.bzl and GENERATED_AbseilCopts.cmake
AbseilConfigureCopts.cmake and configure_copts.bzl import their respective copts args and set the platform-appropriate copts into ABSL_DEFAULT_COPTS, ABSL_TEST_COPTS, ABSL_EXCEPTIONS_FLAG, and ABSL_EXCEPTIONS_LINKOPTS
For Bazel, each BUILD file load()s configure_copts.bzl
For CMake, AbseilHelpers.cmake include()s AbseilConfigureCopts.cmake to get the final copts and both inserts them as needed into legacy target rules and also makes them available to the rest of our CMakeLists.txt file. We may instead want to include() AbseilConfigureCopts.cmake directly into each CMakeLists.txt file for consistency, but I'm not sure what the deal is with cmake and include guards, or if they are even needed. That's also not as idiomatic -- CMake tends to use directory scope where globals set at a higher level CMakeLists.txt file are used in the subdirectory CMakeLists.txt files.
PiperOrigin-RevId: 224039419
--
f7402f6bb65037e668a7355f0a003f5c05a3b6a7 by Abseil Team <absl-team@google.com>:
Import of CCTZ from GitHub.
PiperOrigin-RevId: 224036622
GitOrigin-RevId: 22fa219d17b2281c0695642830c4300711bd65ea
Change-Id: I6b505360539ff2aef8aa30c51a5f7d55db1c75cf
6 years ago
|
|
|
|
|
|
|
|
The generated copts are consumed by configure_copts.bzl and
|
|
|
|
|
AbseilConfigureCopts.cmake.
|
|
|
|
|
"""
|
|
|
|
|
COPT_VARS = {
|
|
|
|
|
"GCC_FLAGS": [
|
|
|
|
|
"-Wall",
|
|
|
|
|
"-Wextra",
|
|
|
|
|
"-Wcast-qual",
|
|
|
|
|
"-Wconversion-null",
|
|
|
|
|
"-Wmissing-declarations",
|
|
|
|
|
"-Woverlength-strings",
|
|
|
|
|
"-Wpointer-arith",
|
|
|
|
|
"-Wunused-local-typedefs",
|
|
|
|
|
"-Wunused-result",
|
|
|
|
|
"-Wvarargs",
|
|
|
|
|
"-Wvla", # variable-length array
|
|
|
|
|
"-Wwrite-strings",
|
|
|
|
|
# Google style does not use unsigned integers, though STL containers
|
|
|
|
|
# have unsigned types.
|
|
|
|
|
"-Wno-sign-compare",
|
|
|
|
|
],
|
|
|
|
|
"GCC_TEST_FLAGS": [
|
|
|
|
|
"-Wno-conversion-null",
|
|
|
|
|
"-Wno-missing-declarations",
|
|
|
|
|
"-Wno-sign-compare",
|
|
|
|
|
"-Wno-unused-function",
|
|
|
|
|
"-Wno-unused-parameter",
|
|
|
|
|
"-Wno-unused-private-field",
|
|
|
|
|
],
|
|
|
|
|
"GCC_EXCEPTIONS_FLAGS": ["-fexceptions"],
|
|
|
|
|
|
|
|
|
|
# Docs on single flags is preceded by a comment.
|
|
|
|
|
# Docs on groups of flags is preceded by ###.
|
|
|
|
|
"LLVM_FLAGS": [
|
|
|
|
|
"-Wall",
|
|
|
|
|
"-Wextra",
|
|
|
|
|
"-Weverything",
|
|
|
|
|
# Abseil does not support C++98
|
|
|
|
|
"-Wno-c++98-compat-pedantic",
|
|
|
|
|
# Turns off all implicit conversion warnings. Most are re-enabled below.
|
|
|
|
|
"-Wno-conversion",
|
|
|
|
|
"-Wno-covered-switch-default",
|
|
|
|
|
"-Wno-deprecated",
|
|
|
|
|
"-Wno-disabled-macro-expansion",
|
|
|
|
|
"-Wno-double-promotion",
|
|
|
|
|
###
|
|
|
|
|
# Turned off as they include valid C++ code.
|
|
|
|
|
"-Wno-comma",
|
|
|
|
|
"-Wno-extra-semi",
|
|
|
|
|
"-Wno-extra-semi-stmt",
|
Export of internal Abseil changes.
--
22fa219d17b2281c0695642830c4300711bd65ea by CJ Johnson <johnsoncj@google.com>:
Rearrange the private method declarations in InlinedVector
PiperOrigin-RevId: 224202447
--
eed3c9f488f23b521bee41d3683eb6cc22517ded by Derek Mauro <dmauro@google.com>:
Fix leak_check target (it was always a no-op when LSAN isn't available).
Fixes https://github.com/abseil/abseil-cpp/issues/232
PiperOrigin-RevId: 224201634
--
fc08039e175204b14a9561f618fcfc0234586801 by Greg Falcon <gfalcon@google.com>:
Add parens around more invocations of min() and max() missed in my prior CL.
PiperOrigin-RevId: 224162430
--
0ec5476a8293c7796cd84928a1a558b14f14f222 by Abseil Team <absl-team@google.com>:
Update absl/numeric/CMakeLists.txt to use new functions
i.e. absl_cc_(library|test)
PiperOrigin-RevId: 224139165
--
2b46aa6fabb20c589661f8bbc84030ecf39ce394 by Abseil Team <absl-team@google.com>:
Update absl/meta/CMakeLists.txt to use new functions
i.e. absl_cc_(library|test)
PiperOrigin-RevId: 224117258
--
6c951c798f8c6903bd8793a8a4b5f69244be8aa9 by Abseil Team <absl-team@google.com>:
Fix 2 Unused C++ BUILD Dependencies
PiperOrigin-RevId: 224070093
--
0ee7bd191708708f91fc5209c197fd93f6e4a8b3 by Greg Falcon <gfalcon@google.com>:
Inside Abseil headers, wrap most invocations of methods and functions named `min` and `max` in parentheses, for better interoperability with Windows toolchains.
CCTZ fixes will appear in a follow-up CL.
PiperOrigin-RevId: 224051960
--
f562f56577b84a8bc07e5873775c01d068531bca by Jon Cohen <cohenjon@google.com>:
Generate Abseil compile options. The single source of truth is now absl/copts/copts.py
The way this works goes something like this:
copts.py acts as the configuration file. We use python because unlike JSON it allows comments. It has two maps in it: one from names to external flags, and one from names to internal flags.
generate_copts.py imports the maps and loops through them to write GENERATED_copts.bzl and GENERATED_AbseilCopts.cmake
AbseilConfigureCopts.cmake and configure_copts.bzl import their respective copts args and set the platform-appropriate copts into ABSL_DEFAULT_COPTS, ABSL_TEST_COPTS, ABSL_EXCEPTIONS_FLAG, and ABSL_EXCEPTIONS_LINKOPTS
For Bazel, each BUILD file load()s configure_copts.bzl
For CMake, AbseilHelpers.cmake include()s AbseilConfigureCopts.cmake to get the final copts and both inserts them as needed into legacy target rules and also makes them available to the rest of our CMakeLists.txt file. We may instead want to include() AbseilConfigureCopts.cmake directly into each CMakeLists.txt file for consistency, but I'm not sure what the deal is with cmake and include guards, or if they are even needed. That's also not as idiomatic -- CMake tends to use directory scope where globals set at a higher level CMakeLists.txt file are used in the subdirectory CMakeLists.txt files.
PiperOrigin-RevId: 224039419
--
f7402f6bb65037e668a7355f0a003f5c05a3b6a7 by Abseil Team <absl-team@google.com>:
Import of CCTZ from GitHub.
PiperOrigin-RevId: 224036622
GitOrigin-RevId: 22fa219d17b2281c0695642830c4300711bd65ea
Change-Id: I6b505360539ff2aef8aa30c51a5f7d55db1c75cf
6 years ago
|
|
|
"-Wno-packed",
|
|
|
|
|
"-Wno-padded",
|
|
|
|
|
###
|
|
|
|
|
# Google style does not use unsigned integers, though STL containers
|
|
|
|
|
# have unsigned types.
|
|
|
|
|
"-Wno-sign-compare",
|
|
|
|
|
###
|
|
|
|
|
"-Wno-float-conversion",
|
|
|
|
|
"-Wno-float-equal",
|
|
|
|
|
"-Wno-format-nonliteral",
|
|
|
|
|
# Too aggressive: warns on Clang extensions enclosed in Clang-only
|
|
|
|
|
# compilation paths.
|
|
|
|
|
"-Wno-gcc-compat",
|
|
|
|
|
###
|
|
|
|
|
# Some internal globals are necessary. Don't do this at home.
|
|
|
|
|
"-Wno-global-constructors",
|
|
|
|
|
"-Wno-exit-time-destructors",
|
|
|
|
|
###
|
|
|
|
|
"-Wno-nested-anon-types",
|
|
|
|
|
"-Wno-non-modular-include-in-module",
|
|
|
|
|
"-Wno-old-style-cast",
|
|
|
|
|
# Warns on preferred usage of non-POD types such as string_view
|
|
|
|
|
"-Wno-range-loop-analysis",
|
|
|
|
|
"-Wno-reserved-id-macro",
|
|
|
|
|
"-Wno-shorten-64-to-32",
|
|
|
|
|
"-Wno-switch-enum",
|
|
|
|
|
"-Wno-thread-safety-negative",
|
|
|
|
|
"-Wno-undef",
|
|
|
|
|
"-Wno-unknown-warning-option",
|
|
|
|
|
"-Wno-unreachable-code",
|
|
|
|
|
# Causes warnings on include guards
|
|
|
|
|
"-Wno-unused-macros",
|
|
|
|
|
"-Wno-weak-vtables",
|
|
|
|
|
###
|
|
|
|
|
# Implicit conversion warnings turned off by -Wno-conversion
|
|
|
|
|
# which are re-enabled below.
|
|
|
|
|
"-Wbitfield-enum-conversion",
|
|
|
|
|
"-Wbool-conversion",
|
|
|
|
|
"-Wconstant-conversion",
|
|
|
|
|
"-Wenum-conversion",
|
|
|
|
|
"-Wint-conversion",
|
|
|
|
|
"-Wliteral-conversion",
|
|
|
|
|
"-Wnon-literal-null-conversion",
|
|
|
|
|
"-Wnull-conversion",
|
|
|
|
|
"-Wobjc-literal-conversion",
|
|
|
|
|
"-Wno-sign-conversion",
|
|
|
|
|
"-Wstring-conversion",
|
|
|
|
|
],
|
|
|
|
|
"LLVM_TEST_FLAGS": [
|
|
|
|
|
"-Wno-c99-extensions",
|
|
|
|
|
"-Wno-missing-noreturn",
|
|
|
|
|
"-Wno-missing-prototypes",
|
|
|
|
|
"-Wno-missing-variable-declarations",
|
|
|
|
|
"-Wno-null-conversion",
|
|
|
|
|
"-Wno-shadow",
|
|
|
|
|
"-Wno-shift-sign-overflow",
|
|
|
|
|
"-Wno-sign-compare",
|
|
|
|
|
"-Wno-unused-function",
|
|
|
|
|
"-Wno-unused-member-function",
|
|
|
|
|
"-Wno-unused-parameter",
|
|
|
|
|
"-Wno-unused-private-field",
|
|
|
|
|
"-Wno-unused-template",
|
|
|
|
|
"-Wno-used-but-marked-unused",
|
|
|
|
|
"-Wno-zero-as-null-pointer-constant",
|
|
|
|
|
# gtest depends on this GNU extension being offered.
|
|
|
|
|
"-Wno-gnu-zero-variadic-macro-arguments",
|
|
|
|
|
],
|
|
|
|
|
"LLVM_EXCEPTIONS_FLAGS": ["-fexceptions"],
|
|
|
|
|
# /Wall with msvc includes unhelpful warnings such as C4711, C4710, ...
|
|
|
|
|
"MSVC_FLAGS": [
|
|
|
|
|
"/W3",
|
|
|
|
|
"/wd4005", # macro-redefinition
|
|
|
|
|
"/wd4068", # unknown pragma
|
|
|
|
|
"/wd4180", # qualifier applied to function type has no meaning; ignored
|
|
|
|
|
"/wd4244", # conversion from 'type1' to 'type2', possible loss of data
|
|
|
|
|
"/wd4267", # conversion from 'size_t' to 'type', possible loss of data
|
|
|
|
|
# forcing value to bool 'true' or 'false' (performance warning)
|
|
|
|
|
"/wd4800",
|
|
|
|
|
"/DNOMINMAX", # Don't define min and max macros (windows.h)
|
|
|
|
|
# Don't bloat namespace with incompatible winsock versions.
|
|
|
|
|
"/DWIN32_LEAN_AND_MEAN",
|
|
|
|
|
# Don't warn about usage of insecure C functions.
|
|
|
|
|
"/D_CRT_SECURE_NO_WARNINGS",
|
|
|
|
|
"/D_SCL_SECURE_NO_WARNINGS",
|
|
|
|
|
# Introduced in VS 2017 15.8, allow overaligned types in aligned_storage
|
|
|
|
|
"/D_ENABLE_EXTENDED_ALIGNED_STORAGE",
|
|
|
|
|
],
|
|
|
|
|
"MSVC_TEST_FLAGS": [
|
|
|
|
|
"/wd4018", # signed/unsigned mismatch
|
|
|
|
|
"/wd4101", # unreferenced local variable
|
|
|
|
|
"/wd4503", # decorated name length exceeded, name was truncated
|
|
|
|
|
],
|
|
|
|
|
"MSVC_EXCEPTIONS_FLAGS": [
|
|
|
|
|
"/U_HAS_EXCEPTIONS", "/D_HAS_EXCEPTIONS=1", "/EHsc"
|
|
|
|
|
]
|
|
|
|
|
}
|
