FFmpeg/lavf-fate at ec7f33a38e341807c0ff9530e4dc7e175a86f437 - FFmpeg - Gitea: Git with a cup of tea

Mirror of https://git.ffmpeg.org/ffmpeg.git https://ffmpeg.org/

History

Andreas Rheinhardt dc2f6b54ac avformat/matroskaenc: Avoid allocations for SeekHead Up until `e7ddafd5`, the Matroska muxer wrote two SeekHeads: One at the beginning referencing the main level 1 elements (i.e. not the Clusters) and one at the end, referencing the Clusters. This second SeekHead was useless and has therefore been removed. Yet the SeekHead-related functions and structures are still geared towards this usecase: They are built around an allocated array of variable size that gets reallocated every time an element is added to it although the maximum number of Seek entries is a small compile-time constant, so that one should rather include the array in the SeekHead structure itself; and said structure should be contained in the MatroskaMuxContext instead of being allocated separately. The earlier code reserved space for a SeekHead with 10 entries, although we currently write at most 6. Reducing said number implied that every Matroska/Webm file will be 84 bytes smaller and required to adapt several FATE tests; furthermore, the reserved amount overestimated the amount needed for for the SeekHead's length field and how many bytes need to be reserved to write a EBML Void element, bringing the total reduction to 89 bytes. This also fixes a potential segfault: If !mkv->is_live and if the AVIOContext is initially unseekable when writing the header, the SeekHead is already written when writing the header and this used to free the SeekHead-related structures that have been allocated. But if the AVIOContext happens to be seekable when writing the trailer, it will be attempted to write the SeekHead again which will lead to segfaults because the corresponding structures have already been freed. Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@gmail.com>		5 years ago
..
av1.mkv	avformat/matroskaenc: Avoid allocations for SeekHead	5 years ago
av1.mp4	avformat/movenc: ensure we don't write the major brand as a compatible brand more than once	5 years ago
cram.avi	tests: Convert lavf container tests with samples to non-legacy test scripts	6 years ago
h264.mp4	avformat/movenc: ensure we don't write the major brand as a compatible brand more than once	5 years ago
latm	tests: Convert lavf container tests with samples to non-legacy test scripts	6 years ago
mp3	tests: Convert lavf container tests with samples to non-legacy test scripts	6 years ago
qtrle_mace6.mov	avformat/movenc: ensure we don't write the major brand as a compatible brand more than once	5 years ago
vp3.ogg	tests: Convert lavf container tests with samples to non-legacy test scripts	6 years ago
vp8.ogg	tests: Convert lavf container tests with samples to non-legacy test scripts	6 years ago