Mirror of https://git.ffmpeg.org/ffmpeg.git https://ffmpeg.org/

Go to file

Andreas Rheinhardt 92c8b79b5a avformat/segment: Don't overwrite AVCodecParameters after init The segment muxer copies the user-provided AVCodecParameters to the newly created child streams in its init function before initializing the child muxer; and since commit `8e6478b723`, it does this again before calling avformat_write_header() if that is called from seg_write_header(). The reason for this is complicated: At that time writing the header was delayed, i.e. it was not triggered by avformat_write_header() (unless the AVFMT_FLAG_AUTO_BSF was unset), but instead by writing the very first packet. The rationale behind this was to allow to run bitstream filters on the packets in the interleavement queue in order to generate missing extradata from them before the muxer's write_header function is actually called. The segment muxer went even further: It initialized the child muxer and ran the child muxer's check_bitstream functions on the packets in its own muxing queue and stole any bitstream filters that got inserted. The reason for this is that the segment muxer has an option to write the header to a separate file and for this it is needed to write the child muxer's header without delay, but with correct extradata. Unsetting AVFMT_FLAG_AUTO_BSF for the child muxer accomplished the first goal and stealing the bitstream filters the second; and in order for the child muxer to actually use the updated extradata, the old AVCodecParameters (set before avformat_init_output()) were overwritten with the new ones. Updating the extradata proceeded as follows: The bitstream filter itself simply updated the AVBSFContext's par_out when processing a packet, in violation of the new BSF API (where par_out may only be set in the init function); the muxing code then simply forwarded the updated extradata, overwriting the par_in of the next BSF in the BSF chain with the fresh par_out of the last one and the AVStream's par with the par_out of the last BSF. This was an API violation, too, of course, but it made remuxing ADTS AAC into mp4/matroska work. But this no longer serves a useful purpose since the aac_adtstoasc BSF was updated to propagate new extradata via packet side data in commit f63c3516577d605e51cf16358cbdfa0bc97565d8; the next commit then removed the code in mux.c passing new extradata along the filter chain. This alone justifies removing the code for setting the AVCodecParameters a second time. But there is even another reason to do so: It is harmful. The ogg muxer parses the extradata of Theora and Vorbis in its init function and keeps pointers to parts of it. Said pointers become dangling when the extradata is overwritten by the segment muxer, leading to use-after-frees as has happened in ticket #8881 which this commit fixes. Ticket #8517 is about another issue caused by this: Immediately after having overwritten the old AVCodecParameters the segment muxer checks whether the codec_tag is ok (the codec_tag is set generically when initializing the child muxer based upon muxer-specific lists). The check used is: If the child output format has such a list and if the codec tag of the non-child stream does not match the codec id given the list of codec tags and if there is a match for the codec id in the codec tag list, then set the codec tag to zero (and not to the existing match), otherwise set the codec tag of the child stream to the codec tag of the corresponding stream of the main AVFormatContext (which is btw redundant given that the child AVCodecParameters have just been overwritten with the AVCodecParameters of the corresponding stream of the main AVFormatContext). Reviewed-by: Ridley Combs <rcombs@rcombs.me> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@gmail.com>		4 years ago
compat	compat/cuda/ptx2c: remove shell loop; fix BSD sed compat	5 years ago
doc	avcodec/libopusenc: add option to set inband FEC	4 years ago
ffbuild	ffbuild: Refine MIPS handling	4 years ago
fftools	ffplay: fix autoexit doesn't work in the case of pb->error	4 years ago
libavcodec	avcodec/extract_extradata: Consolidate zeroing extradata padding	4 years ago
libavdevice	avdevice/lavfi: Remove redundant av_packet_unref()	4 years ago
libavfilter	avfilter/avfilter: remove obsolete comment	4 years ago
libavformat	avformat/segment: Don't overwrite AVCodecParameters after init	4 years ago
libavresample	avresample: remove deprecated attribute from the AVAudioResampleContext struct	7 years ago
libavutil	hwcontext_vaapi: Don't require a render node when deriving from DRM	4 years ago
libpostproc	Bump minor versions after branching 4.3	5 years ago
libswresample	swresample/rematrix: handle 22.2 as a 9 channel layout	4 years ago
libswscale	swscale/x86/output: add missing AVX2 support preprocessor wrappers	4 years ago
presets	…
tests	dnn_backend_native_layer_conv2d.c:Add mutithread function	4 years ago
tools	tools/target_dec_fuzzer: Adjust threshold for WMV3IMAGE	4 years ago
.gitattributes	fate: add SCC test	8 years ago
.gitignore	tools/python: add script to convert TensorFlow model (.pb) to native model (.model)	5 years ago
.mailmap	mailmap: add entry for myself	4 years ago
.travis.yml	Merge commit '899ee03088d55152a48830df0899887f055da1de'	6 years ago
CONTRIBUTING.md	Add CONTRIBUTING.md	8 years ago
COPYING.GPLv2	…
COPYING.GPLv3	…
COPYING.LGPLv2.1	…
COPYING.LGPLv3	…
CREDITS	…
Changelog	avcodec: add PhotoCD decoder	4 years ago
INSTALL.md	INSTALL.md: Fix Markdown formatting	6 years ago
LICENSE.md	avfilter/vf_geq: Relicense to LGPL	5 years ago
MAINTAINERS	MAINTAINERS: add myself and gpg fingerprint	4 years ago
Makefile	Makefile: Delete more created files when running "make distclean".	5 years ago
README.md	Remove the ffserver program	7 years ago
RELEASE	RELEASE: We are after the 4.3 branch point, update for that	5 years ago
configure	configure: Add additional glslang libraries to make linking work	4 years ago

README.md

FFmpeg README

FFmpeg is a collection of libraries and tools to process multimedia content such as audio, video, subtitles and related metadata.

Libraries

libavcodec provides implementation of a wider range of codecs.
libavformat implements streaming protocols, container formats and basic I/O access.
libavutil includes hashers, decompressors and miscellaneous utility functions.
libavfilter provides a mean to alter decoded Audio and Video through chain of filters.
libavdevice provides an abstraction to access capture and playback devices.
libswresample implements audio mixing and resampling routines.
libswscale implements color conversion and scaling routines.

Tools

ffmpeg is a command line toolbox to manipulate, convert and stream multimedia content.
ffplay is a minimalistic multimedia player.
ffprobe is a simple analysis tool to inspect multimedia content.
Additional small tools such as aviocat, ismindex and qt-faststart.

Documentation

The offline documentation is available in the doc/ directory.

The online documentation is available in the main website and in the wiki.

Examples

Coding examples are available in the doc/examples directory.

License

FFmpeg codebase is mainly LGPL-licensed with optional components licensed under GPL. Please refer to the LICENSE file for detailed information.

Contributing

Patches should be submitted to the ffmpeg-devel mailing list using git format-patch or git send-email. Github pull requests should be avoided because they are not part of our review process and will be ignored.