FFmpeg

Commit Graph

Author	SHA1	Message	Date
Diego Biurrun	c67b449beb	dsputil: Split bswap*_buf() off into a separate context	11 years ago
Michael Niedermayer	5439959ef0	avcodec/huffyuvdec: do not leave alpha values uninitialized fixes fate failure under valgrind Signed-off-by: Michael Niedermayer <michaelni@gmx.at>	11 years ago
Michael Niedermayer	20c7baf832	avcodec/huffyuvdec: Fix fill value for truncated bitstreams Found-by: Christophe Gisquet <christophe.gisquet@gmail.com> Signed-off-by: Michael Niedermayer <michaelni@gmx.at>	11 years ago
Christophe Gisquet	f6577bd9cf	huffyuvdec: use unsafe bitstream reader The reader reads in chunks of 11 bits at most, and at most 3 times. The unsafe reader therefore may read 6 chunks instead of 1 in worst case, ie 8 bytes, which is within the padding tolerance. The reader ends up being ~10% faster. Cumulative effect of unsafe reading and code block swapping on 3 sequences is for 1 thread, decoding time goes from 23.3s to 19.0s. Signed-off-by: Michael Niedermayer <michaelni@gmx.at>	11 years ago
Christophe Gisquet	29f427c239	huffyuvdec: remove somewhat deprecated code The old code was reserving the 0xFFFF entry to represent an inexisting entry/codeword. These entries are now detected through their length being <= 0. As this entry is often used for the residuals (-1,-1), which should be among the most frequent, it is particularly important to not reserve it. Signed-off-by: Michael Niedermayer <michaelni@gmx.at>	11 years ago
Michael Niedermayer	e9c477059d	avcodec/huffyuvdec: assume vlcs can be 32 instead of 31 bits max This should avoid a division as well Signed-off-by: Michael Niedermayer <michaelni@gmx.at>	11 years ago
Christophe Gisquet	9dc1791977	huffyuvdec: swap code blocks The effect is not really deterministic, as it seems to be a combination on x86_64 of fewer registers used, different jump offsets and, for all archs, of likely branches. Speedup is around 15%. Signed-off-by: Michael Niedermayer <michaelni@gmx.at>	11 years ago
Christophe Gisquet	7eb5b20a87	huffyuvdec: trick for plane decoding <= 14bits Refactor the code to minimize code duplication. Before: 130870 decicycles in g, 1048139 runs, 437 skips 10bits: 9.048 12bits: 10.733 After: 126960 decicycles in g, 1048136 runs, 440 skips 10bits: 8.642 12bits: 9.656 Signed-off-by: Michael Niedermayer <michaelni@gmx.at>	11 years ago
Christophe Gisquet	0d632b35a0	huffyuvdec: remove superfluous check in BGR code Before: 154861 decicycles After: 152912 decicycles Signed-off-by: Michael Niedermayer <michaelni@gmx.at>	11 years ago
Christophe Gisquet	6848325acb	huffyuvdec: remove superfluous check An invalid entry already has the property of having a negative number of bits, so remove the check on the reserved value, and rearrange the code as a consequence. 346800 decicycles in 422, 262079 runs, 65 skips 168197 decicycles in gray, 262077 runs, 67 skips Overall time: 7.878s 319076 decicycles in 422, 262096 runs, 48 skips 159875 decicycles in gray, 262057 runs, 87 skips Overall time: 7.394s Signed-off-by: Michael Niedermayer <michaelni@gmx.at>	11 years ago
Christophe Gisquet	a37020402a	huffyuvdec: trick for plane decoding, 8bits 10496 -> 9105 cycles. Signed-off-by: Michael Niedermayer <michaelni@gmx.at>	11 years ago
Christophe Gisquet	35dae62204	huffyuvdec: clean up macro It's no longer used inside another specific macro, so rename it. Also remove duplicated definition and realign code. Signed-off-by: Michael Niedermayer <michaelni@gmx.at>	11 years ago
Christophe Gisquet	deadcf5e71	huffyuvdec: implement trick for BGR Before: 179436 decicycles in rgb, 32735 runs, 33 skips Stripped object size: 23188 After: 154861 decicycles in rgb, 32738 runs, 30 skips Stripped object size: 22736 Signed-off-by: Michael Niedermayer <michaelni@gmx.at>	11 years ago
Christophe Gisquet	11b4703813	huffyuvdec: implement trick When the joint table does not contain a valid entry, the decoding restarts from scratch. By implementing the trick of jumping to the 2nd level of the individual table (and inlining the whole), a speed improvement of 5-10% is possible. On a 1000-frames YUV4:2:0 video, before: 362851 decicycles in 422, 262094 runs, 50 skips 182488 decicycles in gray, 262087 runs, 57 skips Object size: 23584 Overall time: 8.377 After: 346800 decicycles in 422, 262079 runs, 65 skips 168197 decicycles in gray, 262077 runs, 67 skips Object size: 23188 Overall time: 7.878 Signed-off-by: Michael Niedermayer <michaelni@gmx.at>	11 years ago
Michael Niedermayer	7b4c46050e	rename add_hfyu_left_prediction_int16 to add_hfyu_left_pred_int16 This makes the naming more consistent with the 8bit variant Signed-off-by: Michael Niedermayer <michaelni@gmx.at>	11 years ago
Michael Niedermayer	550ae6c02f	rename add_hfyu_median_prediction_int16 to add_hfyu_median_pred_int16 This makes the naming more consistent with the 8bit variant Signed-off-by: Michael Niedermayer <michaelni@gmx.at>	11 years ago
Christophe Gisquet	25e6310a3e	huffyuv: change left prediction access in BGRA Signed-off-by: Michael Niedermayer <michaelni@gmx.at>	11 years ago
Diego Biurrun	0d439fbede	dsputil: Split off HuffYUV decoding bits into their own context Also shorten HuffYUV context member names to avoid clutter.	11 years ago
Diego Biurrun	2f02bbcca0	build: Let the ffvhuff decoder/encoder depend on the huffyuv decoder/encoder Almost all of the code is shared so there is little point in enabling one decoder/encoder without the other.	11 years ago
Michael Niedermayer	9bb1af8f36	avcodec/huffyuvdec: use RGB0 for 24bit rgb output instead of BGRA Signed-off-by: Michael Niedermayer <michaelni@gmx.at>	11 years ago
Michael Niedermayer	469de4f583	avcodec/huffyuvdec: use the correct height field Fixes Ticket3395 Signed-off-by: Michael Niedermayer <michaelni@gmx.at>	11 years ago
Michael Niedermayer	6369766f01	avcodec/huffyuv: support gbrp9/10/12/14 Signed-off-by: Michael Niedermayer <michaelni@gmx.at>	11 years ago
Michael Niedermayer	7cf8918b0d	avcodec/huffyuv: update years in copyright Signed-off-by: Michael Niedermayer <michaelni@gmx.at>	11 years ago
Michael Niedermayer	e6c0da70fc	avcodec/huffyuvdec: optimize >8bps VLC reading 97479 -> 54891 decicycles Signed-off-by: Michael Niedermayer <michaelni@gmx.at>	11 years ago
Michael Niedermayer	53167ecfdb	avcodec/huffyuv: support AV_PIX_FMT_YUV(A)4XYP16 and GRAY16 Signed-off-by: Michael Niedermayer <michaelni@gmx.at>	11 years ago
Michael Niedermayer	e6d1c66d74	avcodec/x86/lossless_videodsp: disable median optimizations for 16bps They only support upto 15bps Signed-off-by: Michael Niedermayer <michaelni@gmx.at>	11 years ago
Michael Niedermayer	13c33c8e1f	Move add_hfyu_median_prediction_int16() to losslessviddsp Signed-off-by: Michael Niedermayer <michaelni@gmx.at>	11 years ago
Michael Niedermayer	883570e6b7	Move add_hfyu_left_prediction_int16 to losslessviddsp Signed-off-by: Michael Niedermayer <michaelni@gmx.at>	11 years ago
Michael Niedermayer	f70d7eb20c	Move add/diff_int16 to lossless_videodsp Signed-off-by: Michael Niedermayer <michaelni@gmx.at>	11 years ago
Michael Niedermayer	da0684820a	avcodec/dsputil/huffyuv: move diff int16 and add int16 to dsputil This also fixes masking the bits Signed-off-by: Michael Niedermayer <michaelni@gmx.at>	11 years ago
Michael Niedermayer	2fd39642c9	avcodec/huffyuv: fix median prediction for >8bps Signed-off-by: Michael Niedermayer <michaelni@gmx.at>	11 years ago
Michael Niedermayer	3d87927959	avcodec/huffyuv: add YUVA{420,422,444}P{9,10} support Signed-off-by: Michael Niedermayer <michaelni@gmx.at>	11 years ago
Michael Niedermayer	ef0282125c	avcodec/huffyuv: add YUV{420,422,444}P{9,10,12,14} support Signed-off-by: Michael Niedermayer <michaelni@gmx.at>	11 years ago
Michael Niedermayer	b53aab1a58	libavcodec/huffyuv: >8 bit support This adds only yuv420p10, others are trivial to add after this commit and will be added in a subsequent commit. Currently the implementation is not optimized, optimizations will be added later Signed-off-by: Michael Niedermayer <michaelni@gmx.at>	11 years ago
Michael Niedermayer	534a89478d	avcodec/huffyuv: add a field that represents the number of symbols Signed-off-by: Michael Niedermayer <michaelni@gmx.at>	11 years ago
Michael Niedermayer	13f3092b38	avcodec/huffyuv: add YUVA420P, YUVA422P, YUVA444P, GBRAP, GRAY8A Signed-off-by: Michael Niedermayer <michaelni@gmx.at>	11 years ago
Michael Niedermayer	60ab582a4e	avcodec/huffyuv: add GRAY8 support Signed-off-by: Michael Niedermayer <michaelni@gmx.at>	11 years ago
Michael Niedermayer	22f59a8cbe	avcodec/huffyuv: add GBRP support Signed-off-by: Michael Niedermayer <michaelni@gmx.at>	11 years ago
Michael Niedermayer	4816d63fb7	avcodec/huffyuvdec: optimize decode_plane_bitstream(), use joint tables for new yuv formats Reviewed-by: Paul B Mahol <onemda@gmail.com> Signed-off-by: Michael Niedermayer <michaelni@gmx.at>	11 years ago
Michael Niedermayer	27b1e63f32	avcodec/huffyuv: Support more 8bit YUV formats Reviewed-by: Paul B Mahol <onemda@gmail.com> Signed-off-by: Michael Niedermayer <michaelni@gmx.at>	11 years ago
Michael Niedermayer	42b6805cc1	avcodec/huffyuvdec: clear remainder of the array on end of input in decode_422_bitstream() Fixes: msan_uninit-mem_7f909423efcd_9923_yuv_predmed.avi Fixes use of uninitialized memory Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind Signed-off-by: Michael Niedermayer <michaelni@gmx.at>	11 years ago
Diego Biurrun	b2bed9325d	cosmetics: Group .name and .long_name together in codec/format declarations	11 years ago
Clément Bœsch	1ec94b0f06	lavc: factorize ff_{thread_,re,}get_buffer error messages. Coccinelle profile used: @@ expression r, ctx, f, loglevel, str, flags; @@ -if ((r = ff_get_buffer(ctx, f, flags)) < 0) { - av_log(ctx, loglevel, str); - return r; -} +if ((r = ff_get_buffer(ctx, f, flags)) < 0) + return r; @@ expression r, ctx, f, loglevel, str; @@ -if ((r = ff_reget_buffer(ctx, f)) < 0) { - av_log(ctx, loglevel, str); - return r; -} +if ((r = ff_reget_buffer(ctx, f)) < 0) + return r; @@ expression r, ctx, f, loglevel, str, flags; @@ -if ((r = ff_thread_get_buffer(ctx, f, flags)) < 0) { - av_log(ctx, loglevel, str); - return r; -} +if ((r = ff_thread_get_buffer(ctx, f, flags)) < 0) + return r; ...along with some manual patches for the remaining ones.	12 years ago
Anton Khirnov	759001c534	lavc decoders: work with refcounted frames.	12 years ago
Diego Biurrun	c242bbd8b6	Remove unnecessary dsputil.h #includes	12 years ago
Michael Niedermayer	0dfc01c2bb	huffyuvdec: Skip len==0 cases Fixes vlc decoding for hypothetical files that would contain such cases. Signed-off-by: Michael Niedermayer <michaelni@gmx.at>	12 years ago
Michael Niedermayer	4420b41442	huffyuvdec: check for and propagate failures from inside generate_joint_tables() Signed-off-by: Michael Niedermayer <michaelni@gmx.at>	12 years ago
Michael Niedermayer	f67a0d1152	huffyuvdec: Check init_vlc() return codes. Prevents out of array writes Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind Signed-off-by: Michael Niedermayer <michaelni@gmx.at>	12 years ago
Anton Khirnov	2ca5ca2957	huffyuv: split encoder and decoder into separate files.	12 years ago
Paul B Mahol	4d1912ff4d	huffyuv: return meaningful error codes Signed-off-by: Paul B Mahol <onemda@gmail.com>	12 years ago

1 2

57 Commits (f1d6fc779450715fda20e7844ffc6364e50f5a3e)