FFmpeg

Commit Graph

Author	SHA1	Message	Date
Ganesh Ajjanagadde	00c3220149	lavfi/show_palette: fix memory leak Recent commits `6aaac24d72` and `3835554bf8` made progress towards cleaning up usage of the formats API, and in particular fixed possible NULL pointer dereferences. This commit addresses the issue of possible resource leaks when some intermediate call fails. Unfortunately, even leaving aside this subtle intermediate failure aspect, commit `8087632027` was only partially successful in addressing memleaks. Hopefully, this commit fixes the issue completely. Tested with valgrind --leak-check=full --show-leak-kinds=all, and manual simulation of malloc/realloc failures. Fixes: CID 1270818. Reviewed-by: Clément Bœsch <u@pkh.me> Signed-off-by: Ganesh Ajjanagadde <gajjanagadde@gmail.com>	9 years ago
Ganesh Ajjanagadde	cb93df0dcb	avcodec/aacsbr_tablegen: always initialize tables at runtime This gets rid of virtually useless hardcoded tables hackery. The reason it is useless is that a 320 element lut is anyway placed regardless of --enable-hardcoded-tables, from which all necessary tables are trivially derived at runtime at very low cost: sample benchmark (x86-64, Haswell, GNU/Linux, single run is really what is relevant here since looping drastically changes the bench). Fluctuations are on the order of 10% for the single run test: 39400 decicycles in aacsbr_tableinit, 1 runs, 0 skips 25325 decicycles in aacsbr_tableinit, 2 runs, 0 skips 18475 decicycles in aacsbr_tableinit, 4 runs, 0 skips 15008 decicycles in aacsbr_tableinit, 8 runs, 0 skips 13016 decicycles in aacsbr_tableinit, 16 runs, 0 skips 12005 decicycles in aacsbr_tableinit, 32 runs, 0 skips 11546 decicycles in aacsbr_tableinit, 64 runs, 0 skips 11506 decicycles in aacsbr_tableinit, 128 runs, 0 skips 11500 decicycles in aacsbr_tableinit, 256 runs, 0 skips 11183 decicycles in aacsbr_tableinit, 509 runs, 3 skips Tested with FATE with/without --enable-hardcoded-tables. Reviewed-by: Rostislav Pehlivanov <atomnuker@gmail.com> Signed-off-by: Ganesh Ajjanagadde <gajjanagadde@gmail.com>	9 years ago
Jean Delvare	e74f1a121e	avfilter/vf_delogo: round to the closest value When the interpolated value is divided by the sum of weights, no rounding is done, which means the value is truncated. This results in a slight bias towards dark green in the interpolated area. Rounding properly removes the bias. I measured this change to reduce the interpolation error by 1 to 2 % on average on a number of sample input and logo area combinations. Signed-off-by: Jean Delvare <jdelvare@suse.de> Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>	9 years ago
Ganesh Ajjanagadde	c8905e0d67	swscale/utils: replace pow by exp2 exp2 is a faster function. Reviewed-by: Michael Niedermayer <michael@niedermayer.cc> Signed-off-by: Ganesh Ajjanagadde <gajjanagadde@gmail.com>	9 years ago
Ganesh Ajjanagadde	42868ca569	avcodec/jpeg2000: replace naive pow call with smarter exp2fi pow is a very wasteful function for this purpose. A low hanging fruit would be simply to replace with exp2f, and that does yield some speedup. However, there are 2 drawbacks of this: 1. It does not exploit the integer nature of the argument. 2. (minor) Some platforms lack a proper exp2f routine, making benefits available only to non broken libm. 3. exp2f does not solve the same issue that plagues pow, namely terrible worst case performance. This is a fundamental issue known as the "table-maker's dilemma" recognized by Prof. Kahan himself and subsequently elaborated and researched by many others. All this is clear from benchmarks below. This exploits the IEEE-754 format to get very good performance even in the worst case for integer powers of 2. This solves all the issues noted above. Function tested with clang usan over [-1000, 1000] (beyond range of relevance for this, which is [-255, 255]), patch itself with FATE. Benchmarks obtained on x86-64, Haswell, GNU-Linux via 10^5 iterations of the pow call, START/STOP, and command ffplay ~/samples/jpeg2000/chiens_dcinema2K.mxf. Low number of runs also given to prove the point about worst case: pow: 216270 decicycles in pow, 1 runs, 0 skips 110175 decicycles in pow, 2 runs, 0 skips 56085 decicycles in pow, 4 runs, 0 skips 29013 decicycles in pow, 8 runs, 0 skips 15472 decicycles in pow, 16 runs, 0 skips 8689 decicycles in pow, 32 runs, 0 skips 5295 decicycles in pow, 64 runs, 0 skips 3599 decicycles in pow, 128 runs, 0 skips 2748 decicycles in pow, 256 runs, 0 skips 2304 decicycles in pow, 511 runs, 1 skips 2072 decicycles in pow, 1022 runs, 2 skips 1963 decicycles in pow, 2044 runs, 4 skips 1894 decicycles in pow, 4091 runs, 5 skips 1860 decicycles in pow, 8184 runs, 8 skips exp2f: 134140 decicycles in pow, 1 runs, 0 skips 68110 decicycles in pow, 2 runs, 0 skips 34530 decicycles in pow, 4 runs, 0 skips 17677 decicycles in pow, 8 runs, 0 skips 9175 decicycles in pow, 16 runs, 0 skips 4931 decicycles in pow, 32 runs, 0 skips 2808 decicycles in pow, 64 runs, 0 skips 1747 decicycles in pow, 128 runs, 0 skips 1208 decicycles in pow, 256 runs, 0 skips 952 decicycles in pow, 512 runs, 0 skips 822 decicycles in pow, 1024 runs, 0 skips 765 decicycles in pow, 2047 runs, 1 skips 722 decicycles in pow, 4094 runs, 2 skips 693 decicycles in pow, 8190 runs, 2 skips exp2fi: 2740 decicycles in pow, 1 runs, 0 skips 1530 decicycles in pow, 2 runs, 0 skips 955 decicycles in pow, 4 runs, 0 skips 622 decicycles in pow, 8 runs, 0 skips 477 decicycles in pow, 16 runs, 0 skips 368 decicycles in pow, 32 runs, 0 skips 317 decicycles in pow, 64 runs, 0 skips 291 decicycles in pow, 128 runs, 0 skips 277 decicycles in pow, 256 runs, 0 skips 268 decicycles in pow, 512 runs, 0 skips 265 decicycles in pow, 1024 runs, 0 skips 263 decicycles in pow, 2048 runs, 0 skips 263 decicycles in pow, 4095 runs, 1 skips 260 decicycles in pow, 8191 runs, 1 skips Reviewed-by: Michael Niedermayer <michael@niedermayer.cc> Signed-off-by: Ganesh Ajjanagadde <gajjanagadde@gmail.com>	9 years ago
Andreas Cadhalpun	5b0da6999f	aacenc: update max_sfb when num_swb changes This fixes out-of-bounds reads in avoid_clipping. Reviewed-by: Rostislav Pehlivanov <atomnuker@gmail.com> Signed-off-by: Andreas Cadhalpun <Andreas.Cadhalpun@googlemail.com>	9 years ago
Matthieu Bouron	3d09065316	fate/api-jpeg-codec-param: rename to api-mjpeg-codec-param	9 years ago
Sebastian Dröge	9aebea0a4d	avcodec/h264: Set CORRUPT flag on output frames that are not fully recovered In the merge commit `78265fcfee` this behaviour was broken and the CORRUPT flag would never ever be set on a frame. However the flag on the AVCodecContext was taken into account properly, including AV_CODEC_FLAG2_SHOW_ALL. The reason for this was that the recovered field of the next output picture was always set to TRUE whenever one of the two AVCodecContext flags was set, which made it impossible to detect later, before outputting, if the frame was really recovered or not. Now don't set it to TRUE unless the frame is really recovered and check the AVCodecContext flags right before outputting. Signed-off-by: Sebastian Dröge <sebastian@centricular.com> Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>	9 years ago
Clément Bœsch	503d8bf74a	lavu/frame: use AVPALETTE_SIZE instead of 1024	9 years ago
Rostislav Pehlivanov	4c5136a48b	aacenc_ltp: disable LTP with high lambda values Makes no sense to enable for high bitrates, the coder does well enough. Signed-off-by: Rostislav Pehlivanov <atomnuker@gmail.com>	9 years ago
Rostislav Pehlivanov	6e5dbe7267	aacenc_tns: use 4 bits for short windows With only 7 coefficients per short window at most the extra precision makes a difference and seems to reduce crackling and stddev even further. Signed-off-by: Rostislav Pehlivanov <atomnuker@gmail.com>	9 years ago
Hendrik Leppkes	8142daca44	Merge commit '6788baebb3680d447eabdadf3f5743c8470a4611' * commit '6788baebb3680d447eabdadf3f5743c8470a4611': log: Use a do {} while (0) for dlog Merged-by: Hendrik Leppkes <h.leppkes@gmail.com>	9 years ago
Hendrik Leppkes	c9dbff60c6	Merge commit '7d36474d1908d6267d4e11d4d9909f9604bd0c81' * commit '7d36474d1908d6267d4e11d4d9909f9604bd0c81': imgconvert: Re-enable the deprecation warnings Merged-by: Hendrik Leppkes <h.leppkes@gmail.com>	9 years ago
Hendrik Leppkes	68cb0dc8a3	Merge commit 'f7edcac040f73635fc1127489c9bb29ca8b43532' * commit 'f7edcac040f73635fc1127489c9bb29ca8b43532': avpicture: Suppress warning from deprecated code Merged-by: Hendrik Leppkes <h.leppkes@gmail.com>	9 years ago
Hendrik Leppkes	92186f2d10	Merge commit 'b805482b1fba1d82fbe47023a24c9261f18979b6' * commit 'b805482b1fba1d82fbe47023a24c9261f18979b6': aac: Provide more information on the failure message Merged-by: Hendrik Leppkes <h.leppkes@gmail.com>	9 years ago
Hendrik Leppkes	3f9c64831c	Merge commit 'c5eb279e240af6b7228a624cd7193732f2d5adaa' * commit 'c5eb279e240af6b7228a624cd7193732f2d5adaa': g723: Add missing header Merged-by: Hendrik Leppkes <h.leppkes@gmail.com>	9 years ago
Hendrik Leppkes	8076711d4c	Merge commit '1077d8c8455b27688de37cd04f8cc253fb37944d' * commit '1077d8c8455b27688de37cd04f8cc253fb37944d': configure: Add -framework CoreVideo when building the avfoundation indev Merged-by: Hendrik Leppkes <h.leppkes@gmail.com>	9 years ago
Hendrik Leppkes	d1b7cafae1	Merge commit 'bf12a81cc67d62dd45c58e29fa0e9177331cc151' * commit 'bf12a81cc67d62dd45c58e29fa0e9177331cc151': configure: Replace `pr` since it is not provided by busybox Not merged as requested by Timothy Gu. Merged-by: Hendrik Leppkes <h.leppkes@gmail.com>	9 years ago
Hendrik Leppkes	6a6cfeb2e7	Merge commit '5f3a081b42b84404a40a52c80ef7a354cf048c56' * commit '5f3a081b42b84404a40a52c80ef7a354cf048c56': avi: Spin out the logic to position to the next non-interleaved stream Merged-by: Hendrik Leppkes <h.leppkes@gmail.com>	9 years ago
Matthieu Bouron	5aca33c2cf	swscale/arm: add ff_nv{12,21}_to_{argb,rgba,abgr,bgra}_neon_16	9 years ago
Matthieu Bouron	102842d5fb	fate/api-{jpeg,png}-codec-param: add missing codec dependencies	9 years ago
Matthieu Bouron	bd0a9f603d	fate/api-codec-param: fix codec context leak	9 years ago
foo86	ff6dd5851b	avcodec/libdcadec: honor -err_detect option Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>	9 years ago
foo86	de12aa51b6	avcodec/libdcadec: add some useful options Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>	9 years ago
foo86	704b278361	avcodec/libdcadec: implement logging callback Don't print a warning when dcadec_context_filter() returns positive warning code. Most relevant warnings are now output through the callback function. Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>	9 years ago
foo86	704654ea17	avcodec/libdcadec: fix request_channel_layout Take request_channel_layout as a hint and don't force 2.0 downmix by using both the 2CH and 6CH flags together. Remove warnings about missing coefficients because they are no longer relevant. Honor AV_CH_LAYOUT_NATIVE and make it possible for native DTS channel layout to be output. Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>	9 years ago
Marton Balint	97795ba6c3	lavf/mxfdec: fix seeking before the first keyframe Regression since `53f2ef2c4a`. Fixes ticket #5017. Signed-off-by: Marton Balint <cus@passwd.hu>	9 years ago
Clément Bœsch	dd1d9b80c9	lavu/opencl: restore #if HAVE_THREADS Fix regression since `a8bb81a`. Spotted-by: RiCON	9 years ago
Timothy Gu	006d3e97fc	cosmetics: Fix weird indentations	9 years ago
Clément Bœsch	a8bb81a05c	lavc, lavu: use avutil/thread.h instead of redundant conditional includes	9 years ago
James Almer	a0050d9bf9	configure: fix vp9_d3d11va_hwaccel deps Signed-off-by: James Almer <jamrial@gmail.com>	9 years ago
Clément Bœsch	5e0c47d41c	avutil/threadmessage: fix build without HAVE_THREADS, new attempt	9 years ago
Hendrik Leppkes	312c83e057	avcodec/g723_1: fix license header	9 years ago
Hendrik Leppkes	357c62657a	Merge commit 'cb49bb10ca7fcff2e382d9d989232b1a7f28e7da' * commit 'cb49bb10ca7fcff2e382d9d989232b1a7f28e7da': build: Move -Wcast-qual to the extra_warnings Merged-by: Hendrik Leppkes <h.leppkes@gmail.com>	9 years ago
Hendrik Leppkes	8cfa7beffc	Merge commit '0fc61c6ab6912a2f0c40fdd3f3c591bc2a33efd4' * commit '0fc61c6ab6912a2f0c40fdd3f3c591bc2a33efd4': avi: Validate the stream-id for DV as well Merged-by: Hendrik Leppkes <h.leppkes@gmail.com>	9 years ago
Hendrik Leppkes	e92aa34d7b	Merge commit 'd017ed878a45171f2f6c69fb9d76401c3c494110' * commit 'd017ed878a45171f2f6c69fb9d76401c3c494110': avi: Use the correct data type Merged-by: Hendrik Leppkes <h.leppkes@gmail.com>	9 years ago
Hendrik Leppkes	ee367fadf5	Merge commit '7f57ea143c55ce5732ef7e31e4b75ae6c307af13' * commit '7f57ea143c55ce5732ef7e31e4b75ae6c307af13': vsrc_color: Drop unneeded variable Merged-by: Hendrik Leppkes <h.leppkes@gmail.com>	9 years ago
Hendrik Leppkes	d1256272b1	Merge commit 'ca5f386e75c592ce25b8184516fd0d580ccb31bb' * commit 'ca5f386e75c592ce25b8184516fd0d580ccb31bb': lavf: G.723.1 muxer Merged-by: Hendrik Leppkes <h.leppkes@gmail.com>	9 years ago
Hendrik Leppkes	90c93fb129	Merge commit 'f023d57d355ff3b917f1aad9b03db5c293ec4244' * commit 'f023d57d355ff3b917f1aad9b03db5c293ec4244': lavc: G.723.1 encoder Split existing FFmpeg G.723.1 encoder into a new file. Merged-by: Hendrik Leppkes <h.leppkes@gmail.com>	9 years ago
Hendrik Leppkes	6c9cc21bcc	Merge commit '165cc6fb9defcd79fd71c08167f3e8df26b058ff' * commit '165cc6fb9defcd79fd71c08167f3e8df26b058ff': g723_1: Move sharable functions to a separate file Merged-by: Hendrik Leppkes <h.leppkes@gmail.com>	9 years ago
Hendrik Leppkes	9cf74191ed	Merge commit 'aac996cc01042194bf621d845bbe684549b5882e' * commit 'aac996cc01042194bf621d845bbe684549b5882e': g723_1: Rename files to better reflect their purpose Merged-by: Hendrik Leppkes <h.leppkes@gmail.com>	9 years ago
Clément Bœsch	dc97ff8380	fate/api: add w32+os2 support for fate-api-threadmessage	9 years ago
Hendrik Leppkes	2730a2013d	Merge commit 'b74b88f30da2389f333a31815d8326d5576d3331' * commit 'b74b88f30da2389f333a31815d8326d5576d3331': g723_1: Handle values at the ends of the table in lsp2lpc() Merged-by: Hendrik Leppkes <h.leppkes@gmail.com>	9 years ago
Hendrik Leppkes	0ecec7449c	Merge commit 'a0fa6d06b848f26b16ba12f0a9a4a85b93ab8022' * commit 'a0fa6d06b848f26b16ba12f0a9a4a85b93ab8022': matroska: Warn when metadata references a non-existent element Merged-by: Hendrik Leppkes <h.leppkes@gmail.com>	9 years ago
Hendrik Leppkes	255f8966b2	Merge commit 'f7986239f4dbec91c743c4c5eb0a2339bd325bf6' * commit 'f7986239f4dbec91c743c4c5eb0a2339bd325bf6': dvenc: Validate the frame size before copying it Merged-by: Hendrik Leppkes <h.leppkes@gmail.com>	9 years ago
Clément Bœsch	b98305f0ab	fate/api: fix fate-api-threadmessage dependency	9 years ago
Clément Bœsch	d4b1b33e69	avutil/threadmessage: fix build without HAVE_THREADS	9 years ago
Hendrik Leppkes	4a2058bf4e	Merge commit '7139489c452ef8af6a745ec4e62056ee4ea4d6a8' * commit '7139489c452ef8af6a745ec4e62056ee4ea4d6a8': pgssubdec: fix API compability layer Merged-by: Hendrik Leppkes <h.leppkes@gmail.com>	9 years ago
Hendrik Leppkes	4e01566941	Merge commit 'b0e8651a2a84553d08fbb2f7cb9697bd64fb1b55' * commit 'b0e8651a2a84553d08fbb2f7cb9697bd64fb1b55': doc: Amend the MSYS2 Documentation Merged-by: Hendrik Leppkes <h.leppkes@gmail.com>	9 years ago
Hendrik Leppkes	14b5834756	Merge commit '4f979418c723652ad4e43115118c57a44bd46b52' * commit '4f979418c723652ad4e43115118c57a44bd46b52': avfoundation: Simple capture Not merged on request by Thilo Borgmann, original author of the AVFoundation capture in FFmpeg. Merged-by: Hendrik Leppkes <h.leppkes@gmail.com>	9 years ago

... 2 3 4 5 6 ...

77347 Commits (ef8f6464a55db730cab8c48a1a51fa4e6ca12107) All Branches Search

77347 Commits (ef8f6464a55db730cab8c48a1a51fa4e6ca12107)

All Branches