FFmpeg

118012 Commits

37 Branches

400 Tags

484 MiB

Tag: Branch: Tree: bf0a6c4111

Commit Graph

Author	SHA1	Message	Date
Connor Worley	d5aaed9d4c	lavc/dxv: align to 4x4 blocks instead of 16x16 The previous assumption that DXV needs to be aligned to 16x16 was erroneous. 4x4 works just as well, and FATE decoder tests pass for all texture formats. On the encoder side, we should reject input that isn't 4x4 aligned, like the HAP encoder does, and stop aligning to 16x16. This both solves the uninitialized reads causing current FATE tests to fail and produces smaller encoded outputs. With regard to correctness, I've checked the decoding path by encoding a real-world sample with git master, and decoding it with ffmpeg -i dxt1-master.mov -c:v rawvideo -f framecrc - The results are exactly the same between master and this patch. On the encoding side, I've encoded a real-world sample with both master and this patch, and decoded both versions with ffmpeg -i dxt1-{master,patch}.mov -c:v rawvideo -f framecrc - Under this patch, results for both inputs are exactly the same. In other words, the extra padding gained by 16x16 alignment over 4x4 alignment has no impact on decoded video. Signed-off-by: Connor Worley <connorbworley@gmail.com> Signed-off-by: Martin Storsjö <martin@martin.st>	1 year ago
Connor Worley	5fbb6fc636	fate/video: add DXV3 DXT1 encoding test Signed-off-by: Connor Worley <connorbworley@gmail.com>	1 year ago

Author

SHA1

Message

Date

Connor Worley

d5aaed9d4c

lavc/dxv: align to 4x4 blocks instead of 16x16

The previous assumption that DXV needs to be aligned to 16x16 was
erroneous. 4x4 works just as well, and FATE decoder tests pass for all
texture formats.

On the encoder side, we should reject input that isn't 4x4 aligned,
like the HAP encoder does, and stop aligning to 16x16. This both solves
the uninitialized reads causing current FATE tests to fail and produces
smaller encoded outputs.

With regard to correctness, I've checked the decoding path by encoding a
real-world sample with git master, and decoding it with
  ffmpeg -i dxt1-master.mov -c:v rawvideo -f framecrc -
The results are exactly the same between master and this patch.

On the encoding side, I've encoded a real-world sample with both master
and this patch, and decoded both versions with
  ffmpeg -i dxt1-{master,patch}.mov -c:v rawvideo -f framecrc -
Under this patch, results for both inputs are exactly the same.

In other words, the extra padding gained by 16x16 alignment over 4x4
alignment has no impact on decoded video.

Signed-off-by: Connor Worley <connorbworley@gmail.com>
Signed-off-by: Martin Storsjö <martin@martin.st>

1 year ago

Connor Worley

5fbb6fc636

fate/video: add DXV3 DXT1 encoding test

Signed-off-by: Connor Worley <connorbworley@gmail.com>

1 year ago

2 Commits (bf0a6c4111184ffab9f157db7ee7c8a0f59df077)