FFmpeg

Commit Graph

Author	SHA1	Message	Date
Andreas Rheinhardt	0c204ce9f6	avcodec/dxvenc: Use proper alignment, write endian-independent output Fixes the dxv3enc-dxt1 FATE test with UBSan and on big-endian hardware. Reviewed-by: James Almer <jamrial@gmail.com> Tested-by: Sean McGovern <gseanmcg@gmail.com> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>	11 months ago
Connor Worley	1487f6198c	lavc/texturedsp: require explicitly-set frame dimensions This change decouples the frame dimensions from avctx, which is useful for DXV decoding, and fixes incorrect behavior in the existing implementation. Tested with `make fate THREADS=7` and `make fate THREADS=7 THREAD_TYPE=slice`. Signed-off-by: Connor Worley <connorbworley@gmail.com> Signed-off-by: Anton Khirnov <anton@khirnov.net>	12 months ago
Anton Khirnov	1e7d2007c3	all: use designated initializers for AVOption.unit Makes it robust against adding fields before it, which will be useful in following commits. Majority of the patch generated by the following Coccinelle script: @@ typedef AVOption; identifier arr_name; initializer list il; initializer list[8] il1; expression tail; @@ AVOption arr_name[] = { il, { il1, - tail + .unit = tail }, ... }; with some manual changes, as the script: * has trouble with options defined inside macros * sometimes does not handle options under an #else branch * sometimes swallows whitespace	12 months ago
Connor Worley	939bf30d82	lavc/dxv: move tag definitions to common header Signed-off-by: Connor Worley <connorbworley@gmail.com>	12 months ago
Connor Worley	d5aaed9d4c	lavc/dxv: align to 4x4 blocks instead of 16x16 The previous assumption that DXV needs to be aligned to 16x16 was erroneous. 4x4 works just as well, and FATE decoder tests pass for all texture formats. On the encoder side, we should reject input that isn't 4x4 aligned, like the HAP encoder does, and stop aligning to 16x16. This both solves the uninitialized reads causing current FATE tests to fail and produces smaller encoded outputs. With regard to correctness, I've checked the decoding path by encoding a real-world sample with git master, and decoding it with ffmpeg -i dxt1-master.mov -c:v rawvideo -f framecrc - The results are exactly the same between master and this patch. On the encoding side, I've encoded a real-world sample with both master and this patch, and decoded both versions with ffmpeg -i dxt1-{master,patch}.mov -c:v rawvideo -f framecrc - Under this patch, results for both inputs are exactly the same. In other words, the extra padding gained by 16x16 alignment over 4x4 alignment has no impact on decoded video. Signed-off-by: Connor Worley <connorbworley@gmail.com> Signed-off-by: Martin Storsjö <martin@martin.st>	12 months ago
Andreas Rheinhardt	341d0419e1	avcodec/texturedsp: Factor common code out Namely calling avctx->execute2(avctx,...). Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>	1 year ago
Andreas Rheinhardt	a3fc9fb9fb	avcodec/texturedsp: Add separate TextureDSPEncContext ff_texturedspenc_init() doesn't support most of the function types supported for decoding; add a separate context containing only pointers for the actually supported types. Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>	1 year ago
Andreas Rheinhardt	8f791304f2	avcodec/dxvenc, hap(dec\|enc): Move TextureDSPContext to stack Only used during init. Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>	1 year ago
Andreas Rheinhardt	916f016741	avcodec/dxvenc: Fix data races with slice threading The old code set a common struct from each thread; this only "worked" (but is still UB) because the values written are the same for each thread. Fix this by moving the assignments to the main thread. (This also avoids casting const away from a const AVFrame*.) Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>	1 year ago
Andreas Rheinhardt	555879ca7c	avcodec/dxvenc: Don't cast const away Reviewed-by: Connor Worley <connorbworley@gmail.com> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>	1 year ago
Connor Worley	dfbbd11a4b	lavc/dxvenc: add DXV encoder with support for DXT1 texture format Signed-off-by: Vittorio Giovara <vittorio.giovara@gmail.com>	1 year ago

11 Commits (af91b1b366254096552ce514a86377583ae17c72)