Lou Logan
700687ebe0
qt-faststart: Add a note about the -movflags +faststart feature
...
Signed-off-by: Martin Storsjö <martin@martin.st>
11 years ago
Martin Storsjö
ea7f79f937
qt-faststart: Avoid unintentionally sign extending BE_32
...
Without this cast, the BE_32() expression is sign extended when
assigned to an uint64_t, since the uint8_t|uint8_t expression
is promoted to an int.
Also avoid undefined behaviour when left shifting an uint8_t
by 24 by casting it to an uint32_t explicitly before shifting.
Based on a patch by Michael Niedermayer.
Signed-off-by: Martin Storsjö <martin@martin.st>
11 years ago
Michael Niedermayer
bb95334c34
qt-faststart: Check offset_count before reading from the moov_atom buffer
...
CC: libav-stable@libav.org
Signed-off-by: Martin Storsjö <martin@martin.st>
11 years ago
Michael Niedermayer
6384885425
qt-faststart: Check the ftello() return codes
...
This silences a warning in the coverity static analyzer.
Signed-off-by: Martin Storsjö <martin@martin.st>
11 years ago
Michael Niedermayer
03c2a66fcf
qt-faststart: Fix the signedness of variables keeping the ftello return values
...
These variables are assigned the return values of ftello, which
returns an off_t, which is a signed type. On errors, ftello returns
-1, thus make sure this error return value can be stored properly.
Signed-off-by: Martin Storsjö <martin@martin.st>
11 years ago
Michael Niedermayer
5612244351
qt-faststart: Check fseeko() return codes
...
Signed-off-by: Martin Storsjö <martin@martin.st>
11 years ago
Michael Niedermayer
ea15a9a5d8
qt-faststart: Simplify code by using a MIN() macro
...
qt-faststart doesn't use the normal libav headers at all since
it's supposed to be a completely standalone tool, so we implement
the macro locally in this file.
Signed-off-by: Martin Storsjö <martin@martin.st>
11 years ago
Martin Storsjö
3cbc7ef3d6
qt-faststart: Increase the copy buffer size to 64 KB
...
Copying data in chunks of 1 KB is a little wasteful.
64 KB should still easily fit on the stack, so there's no need
to allocate it dynamically.
Signed-off-by: Martin Storsjö <martin@martin.st>
11 years ago
Lou Logan
2574d62d0d
tools/qt-faststart: add -movflags +faststart note
11 years ago
Michael Niedermayer
582f36ca3f
tools/qt-faststart: Fix unintended sign extension of current_offset
...
Fixes: CID733809
Signed-off-by: Michael Niedermayer <michaelni@gmx.at>
12 years ago
Michael Niedermayer
69ce34c796
tools/qt-faststart: Fix unintended sign extension of atom_size
...
Fixes CID733810
Signed-off-by: Michael Niedermayer <michaelni@gmx.at>
12 years ago
Michael Niedermayer
0ea4742341
qt-faststart: Check offset_count
...
Fixes CID733836
Signed-off-by: Michael Niedermayer <michaelni@gmx.at>
12 years ago
Michael Niedermayer
1838961357
qt-faststart: fix signedness of variable used to hold return code
...
Signed-off-by: Michael Niedermayer <michaelni@gmx.at>
12 years ago
Michael Niedermayer
4a2297294f
qt-faststart: check return of ftello()
...
Fixes CID739863
Signed-off-by: Michael Niedermayer <michaelni@gmx.at>
12 years ago
Michael Niedermayer
0de41ead6f
qt-faststart: check fseeko() return codes
...
Fixes CID733725
Signed-off-by: Michael Niedermayer <michaelni@gmx.at>
12 years ago
Michael Niedermayer
92c3173c84
qt-faststart: fix printf argument type
...
Signed-off-by: Michael Niedermayer <michaelni@gmx.at>
12 years ago
Michael Niedermayer
59003fe7c0
qt-faststart: simplify code by using FFMIN
...
Signed-off-by: Michael Niedermayer <michaelni@gmx.at>
12 years ago
Michael Niedermayer
610efb6773
qt-faststart: dont allocate a bigger buffer than needed
...
Signed-off-by: Michael Niedermayer <michaelni@gmx.at>
12 years ago
Jan Ehrhardt
f4d9148fe2
qt-faststart: speedup
...
qt-faststart is terribly slow when the input file and the output file
are on a slow disk like a SD card. By increasing the copy_buffer from
1K to 32M I decreased the processing time on a sample file from
1600 seconds to 4 seconds. The timing difference is during 'copying
rest of file'.
S:\SD_VIDEO\PRG001>e:\utils\qt-faststart 00005.mp4 5.mp4
ftyp 0 32
free 32 8
mdat 40 13744391
moov 13744431 141848
patching stco atom...
patching stco atom...
writing ftyp atom...
writing moov atom...
copying rest of file...
Execution time: 1576.259 s
S:\SD_VIDEO\PRG001>s:\utils\qt-faststart 00005.mp4 5.mp4
ftyp 0 32
free 32 8
mdat 40 13744391
moov 13744431 141848
patching stco atom...
patching stco atom...
writing ftyp atom...
writing moov atom...
copying rest of file...
Execution time: 3.846 s
Signed-off-by: Michael Niedermayer <michaelni@gmx.at>
12 years ago
Martin Storsjö
dd4169ab92
qt-faststart: Use other seek/tell functions on MSVC than on mingw
...
Signed-off-by: Martin Storsjö <martin@martin.st>
12 years ago
Diego Biurrun
4e81b5f517
tools: K&R reformatting cosmetics
13 years ago
Diego Biurrun
cd8d84575b
qt-faststart: K&R reformatting; fix comment typos
13 years ago
Martin Storsjö
cf4afe0be6
qt-faststart: Fix up indentation
...
This restores indentation after 65b875d8fc
.
Signed-off-by: Martin Storsjö <martin@martin.st>
13 years ago
Mans Rullgard
2912e87a6c
Replace FFmpeg with Libav in licence headers
...
Signed-off-by: Mans Rullgard <mans@mansr.com>
14 years ago
Baptiste Coudurier
91a4abd8f5
fail if input and output are the same
...
Originally committed as revision 23672 to svn://svn.ffmpeg.org/ffmpeg/trunk
15 years ago
Martin Storsjö
86e09922a5
qt-faststart: Abort scanning of the input file if a badly sized atom is encountered
...
If the atom size is 0, qt-faststart currently hangs forever while scanning
the file.
Originally committed as revision 23129 to svn://svn.ffmpeg.org/ffmpeg/trunk
15 years ago
Martin Storsjö
2ef9fd8e9b
Cosmetics: Initialize pointers with NULL instead of 0, for consistency
...
Originally committed as revision 23127 to svn://svn.ffmpeg.org/ffmpeg/trunk
15 years ago
Martin Storsjö
e3d7269fc8
Cosmetics: reindent
...
Originally committed as revision 23126 to svn://svn.ffmpeg.org/ffmpeg/trunk
15 years ago
Martin Storsjö
c937454d89
qt-faststart: Use the error_out cleanup code path for all error returns
...
Originally committed as revision 23125 to svn://svn.ffmpeg.org/ffmpeg/trunk
15 years ago
Martin Storsjö
6ad533b7cb
qt-faststart: Avoid leaking memory if encountering a file with double ftyp atoms
...
Originally committed as revision 23065 to svn://svn.ffmpeg.org/ffmpeg/trunk
15 years ago
Martin Storsjö
d296a658cf
qt-faststart: Free ftyp_atom at all exit points
...
Originally committed as revision 23008 to svn://svn.ffmpeg.org/ffmpeg/trunk
15 years ago
Martin Storsjö
331cb6c3e8
Reindent after the previous commit
...
Originally committed as revision 23007 to svn://svn.ffmpeg.org/ffmpeg/trunk
15 years ago
Martin Storsjö
d50fc2d07b
Remove unnecessary checks before calling free
...
Feel free to revert if you can specify a concrete case where this actually
is necessary.
Originally committed as revision 23006 to svn://svn.ffmpeg.org/ffmpeg/trunk
15 years ago
Frank Barchard
65b875d8fc
print atom info during parsing, patch by Frank Barchard, fbarchard at google dot com
...
Originally committed as revision 19435 to svn://svn.ffmpeg.org/ffmpeg/trunk
16 years ago
Frank Barchard
31457d7a2e
Do not fail if 'uuid' atom is encountered before 'moov'.
...
Patch by Frank Barchard, fbarchard at google dot com.
Originally committed as revision 19354 to svn://svn.ffmpeg.org/ffmpeg/trunk
16 years ago
Frank Barchard
06a497afab
Use slightly more appropriate format strings for printing decimal values.
...
patch by Frank Barchard, fbarchard google com
Originally committed as revision 19315 to svn://svn.ffmpeg.org/ffmpeg/trunk
16 years ago
Frank Barchard
cb28f95454
Use more portable 'PRId64' instead of 'llx' as conversion/length specifier.
...
patch by Frank Barchard, fbarchard google com
Originally committed as revision 19309 to svn://svn.ffmpeg.org/ffmpeg/trunk
16 years ago
Mike Melanson
3c16e03dbc
correct build documentation for qt-faststart utility
...
Originally committed as revision 13199 to svn://svn.ffmpeg.org/ffmpeg/trunk
17 years ago
Måns Rullgård
c07ed8c8a2
create and populate "tools" directory
...
Originally committed as revision 9634 to svn://svn.ffmpeg.org/ffmpeg/trunk
18 years ago
Diego Biurrun
bbec8c2c63
Recommend building qt-faststart using make instead of a manual cc invocation.
...
Originally committed as revision 8344 to svn://svn.ffmpeg.org/ffmpeg/trunk
18 years ago
Baptiste Coudurier
fd7789dbe8
decrease last_offset when ftyp is present
...
Originally committed as revision 5283 to svn://svn.ffmpeg.org/ffmpeg/trunk
19 years ago
Steve L'Homme
a8fcaf4019
#define fseeko/ftello to fseeko64/ftello64, fixes MinGW compilation.
...
patch by Steve Lhomme, steve.,.,.lhomme.,@,.free.,.,.fr
Originally committed as revision 5230 to svn://svn.ffmpeg.org/ffmpeg/trunk
19 years ago
Baptiste Coudurier
21c5aca65a
free ftyp atom
...
Originally committed as revision 5187 to svn://svn.ffmpeg.org/ffmpeg/trunk
19 years ago
Baptiste Coudurier
7db2245d0e
> 2GB file fix
...
Originally committed as revision 5173 to svn://svn.ffmpeg.org/ffmpeg/trunk
19 years ago
Baptiste Coudurier
60a9cc5879
keep ftyp first
...
Originally committed as revision 5170 to svn://svn.ffmpeg.org/ffmpeg/trunk
19 years ago
Baptiste Coudurier
c03395995a
fix warning
...
Originally committed as revision 5169 to svn://svn.ffmpeg.org/ffmpeg/trunk
19 years ago
Baptiste Coudurier
e2daf55465
use fseeko and ftello to be 64 bit offsets compliant
...
Originally committed as revision 5167 to svn://svn.ffmpeg.org/ffmpeg/trunk
19 years ago
Mike Melanson
d4fcd7c61a
yep, tyop
...
Originally committed as revision 3328 to svn://svn.ffmpeg.org/ffmpeg/trunk
21 years ago
Mike Melanson
38100e8c8d
added QT faststart remuxing utility to ffmpeg distribution per, ahem,
...
popular request
Originally committed as revision 2934 to svn://svn.ffmpeg.org/ffmpeg/trunk
21 years ago