Profiling on a Raspberry Pi revealed the best performance to correspond
with VLC_BITS = 5. Results for overall audio decode and the get_vlc2 function
in particular are as follows:
Before After
Mean StdDev Mean StdDev Confidence Change
6:2 total 348.8 20.1 339.6 15.1 88.8% +2.7% (insignificant)
6:2 function 38.1 8.1 26.4 4.1 100.0% +44.5%
8:2 total 339.1 15.4 324.5 15.5 99.4% +4.5%
8:2 function 33.8 7.0 27.3 5.6 99.7% +23.6%
6:6 total 604.6 20.8 572.8 20.6 100.0% +5.6%
6:6 function 95.8 8.4 68.9 8.2 100.0% +39.1%
8:8 total 766.4 17.6 741.5 21.2 100.0% +3.4%
8:8 function 106.0 11.4 86.1 9.9 100.0% +23.1%
Signed-off-by: Martin Storsjö <martin@martin.st>
Don't decode further substreams if request_channel_layout
is a subset of the current substream's channel_layout.
Before, we would only discard further substreams if
request_channel_layout matched the substream's
channel_layout extactly, thus decoding additional
channels which the caller would probably end up downmixing.
The faulty values rippled further down the codepath causing a
hard-to-track segfault in the assembly code.
Reported-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
CC: libav-stable@libav.org
Also stop storing the channel arrangement in the header info, as it's unused outside of ff_mlp_read_major_sync.
Signed-off-by: Justin Ruggles <justin.ruggles@gmail.com>
CC:libav-stable@libav.org
Also break some long lines, remove codec function placeholder comments
and add spaces in sample/pixel format lists.
Signed-off-by: Martin Storsjö <martin@martin.st>
was encountered with a channel range that overlapped the previous substreams,
and the code assumed no such overlap was possible.
Patch by Nick Brereton <nick at nbrereton dot net>
Originally committed as revision 23084 to svn://svn.ffmpeg.org/ffmpeg/trunk
Passing an explicit filename to this command is only necessary if the
documentation in the @file block refers to a file different from the
one the block resides in.
Originally committed as revision 22921 to svn://svn.ffmpeg.org/ffmpeg/trunk
Probably only DoS, init_get_bits sets buffer to NULL, thus causing a
NULL-dereference directly after.
Originally committed as revision 21426 to svn://svn.ffmpeg.org/ffmpeg/trunk
instances of the decoder were started at different times.
Bug reported by Maxim Anisiutkin.
Originally committed as revision 20254 to svn://svn.ffmpeg.org/ffmpeg/trunk
The previous code would print the wrong error message for MLP streams with
TrueHD noise type.
Originally committed as revision 18762 to svn://svn.ffmpeg.org/ffmpeg/trunk
Vittorio Giovara
Ben Avison
Michael Niedermayer
Tim Walker
Diego Biurrun
Luca Barbato
Anton Khirnov
Justin Ruggles
Martin Storsjö
Paul B Mahol
Mans Rullgard
Johan Andersson
Diego Elio Pettenò
Stefano Sabatini
Nick Brereton
Reimar Döffinger
Ramiro Polla