FFmpeg

Commit Graph

Author	SHA1	Message	Date
Kieran Kunhya	9f374c5906	diracdec: Make slice parameters common between lowdelay and future hq profile	9 years ago
Kieran Kunhya	3bb6ce1af9	diracdec: Rename lowdelay_subband to decode_subband because it is shared with HQ profile	9 years ago
Kieran Kunhya	3f07f12f65	diracdec: Template DSP functions adding 10-bit versions	9 years ago
Kieran Kunhya	9553689854	diracdec: Move strides to bytes, and pointer types to uint8_t. Start templating functions for move to support 10-bit Parts of this patch were written by Rostislav Pehlivanov	9 years ago
Claudio Freire	124c375938	AAC encoder: fix OOB access in search_for_pns Fix OOB access in search_for_pns which was using w2 outside the window group loop, and fix a typo in which it was checking sf_idx instead of band_type Reviewed-by: Andreas Cadhalpun <andreas.cadhalpun@googlemail.com> Signed-off-by: Andreas Cadhalpun <Andreas.Cadhalpun@googlemail.com>	9 years ago
Ganesh Ajjanagadde	cb93df0dcb	avcodec/aacsbr_tablegen: always initialize tables at runtime This gets rid of virtually useless hardcoded tables hackery. The reason it is useless is that a 320 element lut is anyway placed regardless of --enable-hardcoded-tables, from which all necessary tables are trivially derived at runtime at very low cost: sample benchmark (x86-64, Haswell, GNU/Linux, single run is really what is relevant here since looping drastically changes the bench). Fluctuations are on the order of 10% for the single run test: 39400 decicycles in aacsbr_tableinit, 1 runs, 0 skips 25325 decicycles in aacsbr_tableinit, 2 runs, 0 skips 18475 decicycles in aacsbr_tableinit, 4 runs, 0 skips 15008 decicycles in aacsbr_tableinit, 8 runs, 0 skips 13016 decicycles in aacsbr_tableinit, 16 runs, 0 skips 12005 decicycles in aacsbr_tableinit, 32 runs, 0 skips 11546 decicycles in aacsbr_tableinit, 64 runs, 0 skips 11506 decicycles in aacsbr_tableinit, 128 runs, 0 skips 11500 decicycles in aacsbr_tableinit, 256 runs, 0 skips 11183 decicycles in aacsbr_tableinit, 509 runs, 3 skips Tested with FATE with/without --enable-hardcoded-tables. Reviewed-by: Rostislav Pehlivanov <atomnuker@gmail.com> Signed-off-by: Ganesh Ajjanagadde <gajjanagadde@gmail.com>	9 years ago
Ganesh Ajjanagadde	42868ca569	avcodec/jpeg2000: replace naive pow call with smarter exp2fi pow is a very wasteful function for this purpose. A low hanging fruit would be simply to replace with exp2f, and that does yield some speedup. However, there are 2 drawbacks of this: 1. It does not exploit the integer nature of the argument. 2. (minor) Some platforms lack a proper exp2f routine, making benefits available only to non broken libm. 3. exp2f does not solve the same issue that plagues pow, namely terrible worst case performance. This is a fundamental issue known as the "table-maker's dilemma" recognized by Prof. Kahan himself and subsequently elaborated and researched by many others. All this is clear from benchmarks below. This exploits the IEEE-754 format to get very good performance even in the worst case for integer powers of 2. This solves all the issues noted above. Function tested with clang usan over [-1000, 1000] (beyond range of relevance for this, which is [-255, 255]), patch itself with FATE. Benchmarks obtained on x86-64, Haswell, GNU-Linux via 10^5 iterations of the pow call, START/STOP, and command ffplay ~/samples/jpeg2000/chiens_dcinema2K.mxf. Low number of runs also given to prove the point about worst case: pow: 216270 decicycles in pow, 1 runs, 0 skips 110175 decicycles in pow, 2 runs, 0 skips 56085 decicycles in pow, 4 runs, 0 skips 29013 decicycles in pow, 8 runs, 0 skips 15472 decicycles in pow, 16 runs, 0 skips 8689 decicycles in pow, 32 runs, 0 skips 5295 decicycles in pow, 64 runs, 0 skips 3599 decicycles in pow, 128 runs, 0 skips 2748 decicycles in pow, 256 runs, 0 skips 2304 decicycles in pow, 511 runs, 1 skips 2072 decicycles in pow, 1022 runs, 2 skips 1963 decicycles in pow, 2044 runs, 4 skips 1894 decicycles in pow, 4091 runs, 5 skips 1860 decicycles in pow, 8184 runs, 8 skips exp2f: 134140 decicycles in pow, 1 runs, 0 skips 68110 decicycles in pow, 2 runs, 0 skips 34530 decicycles in pow, 4 runs, 0 skips 17677 decicycles in pow, 8 runs, 0 skips 9175 decicycles in pow, 16 runs, 0 skips 4931 decicycles in pow, 32 runs, 0 skips 2808 decicycles in pow, 64 runs, 0 skips 1747 decicycles in pow, 128 runs, 0 skips 1208 decicycles in pow, 256 runs, 0 skips 952 decicycles in pow, 512 runs, 0 skips 822 decicycles in pow, 1024 runs, 0 skips 765 decicycles in pow, 2047 runs, 1 skips 722 decicycles in pow, 4094 runs, 2 skips 693 decicycles in pow, 8190 runs, 2 skips exp2fi: 2740 decicycles in pow, 1 runs, 0 skips 1530 decicycles in pow, 2 runs, 0 skips 955 decicycles in pow, 4 runs, 0 skips 622 decicycles in pow, 8 runs, 0 skips 477 decicycles in pow, 16 runs, 0 skips 368 decicycles in pow, 32 runs, 0 skips 317 decicycles in pow, 64 runs, 0 skips 291 decicycles in pow, 128 runs, 0 skips 277 decicycles in pow, 256 runs, 0 skips 268 decicycles in pow, 512 runs, 0 skips 265 decicycles in pow, 1024 runs, 0 skips 263 decicycles in pow, 2048 runs, 0 skips 263 decicycles in pow, 4095 runs, 1 skips 260 decicycles in pow, 8191 runs, 1 skips Reviewed-by: Michael Niedermayer <michael@niedermayer.cc> Signed-off-by: Ganesh Ajjanagadde <gajjanagadde@gmail.com>	9 years ago
Andreas Cadhalpun	5b0da6999f	aacenc: update max_sfb when num_swb changes This fixes out-of-bounds reads in avoid_clipping. Reviewed-by: Rostislav Pehlivanov <atomnuker@gmail.com> Signed-off-by: Andreas Cadhalpun <Andreas.Cadhalpun@googlemail.com>	9 years ago
Sebastian Dröge	9aebea0a4d	avcodec/h264: Set CORRUPT flag on output frames that are not fully recovered In the merge commit `78265fcfee` this behaviour was broken and the CORRUPT flag would never ever be set on a frame. However the flag on the AVCodecContext was taken into account properly, including AV_CODEC_FLAG2_SHOW_ALL. The reason for this was that the recovered field of the next output picture was always set to TRUE whenever one of the two AVCodecContext flags was set, which made it impossible to detect later, before outputting, if the frame was really recovered or not. Now don't set it to TRUE unless the frame is really recovered and check the AVCodecContext flags right before outputting. Signed-off-by: Sebastian Dröge <sebastian@centricular.com> Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>	9 years ago
Rostislav Pehlivanov	4c5136a48b	aacenc_ltp: disable LTP with high lambda values Makes no sense to enable for high bitrates, the coder does well enough. Signed-off-by: Rostislav Pehlivanov <atomnuker@gmail.com>	9 years ago
Rostislav Pehlivanov	6e5dbe7267	aacenc_tns: use 4 bits for short windows With only 7 coefficients per short window at most the extra precision makes a difference and seems to reduce crackling and stddev even further. Signed-off-by: Rostislav Pehlivanov <atomnuker@gmail.com>	9 years ago
foo86	ff6dd5851b	avcodec/libdcadec: honor -err_detect option Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>	9 years ago
foo86	de12aa51b6	avcodec/libdcadec: add some useful options Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>	9 years ago
foo86	704b278361	avcodec/libdcadec: implement logging callback Don't print a warning when dcadec_context_filter() returns positive warning code. Most relevant warnings are now output through the callback function. Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>	9 years ago
foo86	704654ea17	avcodec/libdcadec: fix request_channel_layout Take request_channel_layout as a hint and don't force 2.0 downmix by using both the 2CH and 6CH flags together. Remove warnings about missing coefficients because they are no longer relevant. Honor AV_CH_LAYOUT_NATIVE and make it possible for native DTS channel layout to be output. Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>	9 years ago
Clément Bœsch	a8bb81a05c	lavc, lavu: use avutil/thread.h instead of redundant conditional includes	9 years ago
Hendrik Leppkes	312c83e057	avcodec/g723_1: fix license header	9 years ago
Hendrik Leppkes	1e6cf7272f	avcodec: implement vp9 dxva2 hwaccel	9 years ago
Hendrik Leppkes	585083dd1f	vp9: add hwaccel hooks	9 years ago
Hendrik Leppkes	cd1b7e2bd7	vp9: fix pixel format changes with threading	9 years ago
Andreas Cadhalpun	5adb5d9d89	mjpegdec: consider chroma subsampling in size check If the chroma components are subsampled, smaller buffers are allocated for them. In that case the maximal block_offset for the chroma components is not as large as for the luma component. This fixes out of bounds writes causing segmentation faults or memory corruption. Reviewed-by: Michael Niedermayer <michael@niedermayer.cc> Signed-off-by: Andreas Cadhalpun <Andreas.Cadhalpun@googlemail.com>	9 years ago
Rostislav Pehlivanov	d55f83de4d	aacenc_tns: tune and reduce artifacts There are a couple of major changes here: 1. Start using TNS coefficient compression. 2. Start using 3 bits per coefficient maximum for short windows. The bits we save from these 2 changes seem to make a nice impact on the rest of the file/windows. 3. Remove special case gain checking for short windows. 4. Modify the coefficient loop to support up to 3 windows. The additional restrictions on TNS were something that was no in the specifications and furthermore restricting TNS to only low energy short windows was done to compensate for bugs elsewhere in the code. Overall, the improvements here reduce crackling artifacts heard in very noisy tracks. Signed-off-by: Rostislav Pehlivanov <atomnuker@gmail.com>	9 years ago
Rostislav Pehlivanov	b32e989e6c	aacenc: move the TNS search and filtering before PNS The original plan was to have TNS use data from the PNS search to better tune itself to noise but this was never used nor necessary. This should slightly boost the PNS accuracy if TNS was used. Signed-off-by: Rostislav Pehlivanov <atomnuker@gmail.com>	9 years ago
Ganesh Ajjanagadde	14886bebfe	avcodec/dvdsubdec: fix typo in dlog message Likely accidental in `764900d645`. Fixes: CID 1341578. Reviewed-by: Michael Niedermayer <michael@niedermayer.cc> Signed-off-by: Ganesh Ajjanagadde <gajjanagadde@gmail.com>	9 years ago
Michael Niedermayer	2140858524	avcodec/hevc: Fix integer overflow of entry_point_offset Fixes out of array read Fixes: d41d8cd98f00b204e9800998ecf8427e/signal_sigsegv_321165b_7641_077dfcd8cbc80b1c0b470c8554cd6ffb.bit Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>	9 years ago
Rostislav Pehlivanov	dcbe8d8abc	aacenc_ltp: use an AR filter for LTP encoding as well Seems to work better. Information on why the decoder does this is lacking. Signed-off-by: Rostislav Pehlivanov <atomnuker@gmail.com>	9 years ago
Rostislav Pehlivanov	3112501daf	aacenc: fix aac_pred option triggering an error Signed-off-by: Rostislav Pehlivanov <atomnuker@gmail.com>	9 years ago
Michael Niedermayer	a08681f1e6	avcodec/dirac_parser: Check that there is a previous PU before accessing it Fixes out of array read Fixes: 99d142c47e6ba3510a74b872a1a2ae72/asan_heap-oob_11b36f4_3811_0f5c69e7609a88a580135678de1df844.dxa Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>	9 years ago
Michael Niedermayer	c7d6ec947c	avcodec/dirac_parser: Add basic validity checks for next_pu_offset and prev_pu_offset Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>	9 years ago
Michael Niedermayer	79798f7c57	avcodec/dirac_parser: Fix potential overflows in pointer checks Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>	9 years ago
Rostislav Pehlivanov	d9791a8656	aacenc: remove the experimental flag Thiss commit removes the experimental flag from the native AAC Encoder and thus makes it the default. After a lot of work, done by myself and Claudio Freire, the quality of this encoder rivals and surpasses libfdk_aac in some situations. The encoder had instability issues earlier which prevented it from having its experimental flag removed, however the last commits done by Claudio removed the last known source of instability and solved a lot of problems which were previously observed. The issues were caused by the various coding tools interfering with the scalefactor indices. Thus, with these problems solved, it should now be possible to declare this encoder as the default and recommend that the users should use it instead of others provided by external libraries, as it is both faster and has a subjectively higher quality with selected tracks. The encoder has still yet to be fine tuned for every possible audio file type like music or voice, so it is hoped that with the experimental flag removed the users should be able to provide feedback and make the encoder better than the alternatives for every type of audio and at every bitrate. Signed-off-by: Rostislav Pehlivanov <atomnuker@gmail.com>	9 years ago
Rostislav Pehlivanov	b270ec9a10	aacenc: mark coders other than twoloop as experimental ANMR has some interesting things coming up but is currently not in a shape fit for non-experimental usage. Same with "FAST". Signed-off-by: Rostislav Pehlivanov <atomnuker@gmail.com>	9 years ago
Rostislav Pehlivanov	3a6e020861	aacenc: mark the "faac"-like coder for removal This coder produces a much lower quality audio than the rest, is much slower and is unstable. Hasn't been updated for a very long time as well, hence it is more appropriate to remove it since it also depends on a big burden of a code (the encode_window_bands_info function which is just as old, just as unstable and bad and in no way modifiable or fixable). Signed-off-by: Rostislav Pehlivanov <atomnuker@gmail.com>	9 years ago
Michael Niedermayer	66e05f6ff5	avcodec/wmaprodec: Check bits per sample to be within the range not causing integer overflows Fixes: 549d5aab1480d10f2a775ed90b0342f1/signal_sigabrt_7ffff6ae7cc9_5643_96bbb0cfe3e28be1dadfce1075016345.wma Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>	9 years ago
Luca Barbato	6788baebb3	log: Use a do {} while (0) for dlog Avoid the warning `-Wempty-body`.	9 years ago
Luca Barbato	7d36474d19	imgconvert: Re-enable the deprecation warnings The end-marked was typoed in `f7edcac040`	9 years ago
Michael Niedermayer	15d14ce47c	avcodec/utils: Fix overflow in get_bit_rates computations Fixes: 129ca3e28d73af7b1e24a9d4118e7a2d/signal_sigabrt_7ffff6ae7cc9_836_762b310fc3ef6087bd7771e5d8e90b9b.asf Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>	9 years ago
Michael Niedermayer	2de8bfd2ef	avcodec/pcm: Fix overflow in bitrate computation Fixes: 129ca3e28d73af7b1e24a9d4118e7a2d/signal_sigabrt_7ffff6ae7cc9_836_762b310fc3ef6087bd7771e5d8e90b9b.asf Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>	9 years ago
Michael Niedermayer	0c56f8303e	avcodec/wmaprodec: Fix overflow of cutoff Fixes: 129ca3e28d73af7b1e24a9d4118e7a2d/signal_sigabrt_7ffff6ae7cc9_836_762b310fc3ef6087bd7771e5d8e90b9b.asf Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>	9 years ago
Luca Barbato	f7edcac040	avpicture: Suppress warning from deprecated code	9 years ago
Luca Barbato	b805482b1f	aac: Provide more information on the failure message Bug-Id: 761	9 years ago
Luca Barbato	c5eb279e24	g723: Add missing header Unbreak make check.	9 years ago
Claudio Freire	293c170f59	AAC encoder: ANMR, avoid empty search ranges Avoid generating broken paths when some bands have an empty search space.	9 years ago
Andreas Cadhalpun	7a4652dd5d	aaccoder: prevent crash of anmr coder If minq is negative, the range of sf_idx can be larger than SCALE_MAX_DIFF allows, causing assertion failures later in encode_scale_factors. Reviewed-by: Claudio Freire <klaussfreire@gmail.com> Signed-off-by: Andreas Cadhalpun <Andreas.Cadhalpun@googlemail.com>	9 years ago
Michael Niedermayer	4f2419888b	avcodec/pgssubdec: Fix left shift of 255 by 24 places cannot be represented in type int Fixes: b293a6479bb4b5286cff24d356bfd955/asan_generic_225c3c9_7819_cc526b657450c6cdef1371b526499626.mkv Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>	9 years ago
Michael Niedermayer	a85b02dcf7	avcodec/jpeg2000dec: Check bpno in decode_cblk() Fixes: undefined shift Fixes: c409ef86f892335a0a164b5871174d5a/asan_heap-oob_1dff564_2159_162b7234616deab02b544410455eb07b.mov Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>	9 years ago
Clément Bœsch	60532348d2	avcodec/mpegvideo: use constants for rc_strategy	9 years ago
Clément Bœsch	fb99ef0bd3	avcodec: use AV_OPT_TYPE_BOOL in a bunch of places	9 years ago
Hendrik Leppkes	3c4e49187f	libavcodec/aacsbr_tablegen: fix tablegen on windows Including these headers is not needed and breaks building on Windows as it tries to activate the full compat tools, which are not needed for host tools.	9 years ago
Hendrik Leppkes	42a9aead85	avcodec: include tablegen compat header before the tablegen functionality	9 years ago

1 2 3 4 5 ...

34365 Commits (9f374c59061be6b3e5d394678e08adce42c1392e)