FFmpeg

Commit Graph

Author	SHA1	Message	Date
Luca Barbato	af4cc2605c	id3v2: check for end of file while unescaping tags Prevent a serious out of buffer bound write. Reported-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind CC:libav-stable@libav.org	12 years ago
Luca Barbato	0671adbb18	id3v2: K&R formatting cosmetics Signed-off-by: Diego Biurrun <diego@biurrun.de>	12 years ago
Diego Biurrun	e926b5ceb1	avformat: Drop unnecessary ff_ name prefixes from static functions	12 years ago
Anton Khirnov	8d617b11cf	id3v2: pad the APIC packets as required by lavc. Reported-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind CC: libav-stable@libav.org	12 years ago
Anton Khirnov	1afddbe59e	avpacket: use AVBuffer to allow refcounting the packets. This will allow us to avoid copying the packets in many cases. This breaks ABI.	12 years ago
Anton Khirnov	9ae80e6a9c	id3v2: fix reading unsynchronized frames. Current code would incorrectly process e.g. 'ff 00 ff 00 ff' to 'ff ff ff', while it should be 'ff ff 00 ff'. Fixes Bug 395. CC: libav-stable@libav.org	12 years ago
Clément Bœsch	049ce4facb	id3v2: strdup the genre name explicitly. It would have been done anyway in the av_dict_set() call. This simplifies the code and avoid a warning because of assigning a const string from ff_id3v1_genre_str to a non-const variable. Signed-off-by: Anton Khirnov <anton@khirnov.net>	12 years ago
Clément Bœsch	ffdd2e9144	lavf/id3v2: do not export empty fields. This also avoids a memleak. Signed-off-by: Anton Khirnov <anton@khirnov.net>	12 years ago
Mohammad Alsaleh	6e9bbc6525	id3v2: Match PIC mimetype/format case-insensitively Some files' embedded art seems to have the mimetype 'image/JPG' instead of 'image/jpg'. Libav fails to parse those because it matches case-sensitively. Use av_strncasecmp() to fix this behaviour. Signed-off-by: Mohammad Alsaleh <msal@tormail.org> Signed-off-by: Anton Khirnov <anton@khirnov.net>	12 years ago
Mohammad Alsaleh	385ec296f1	id3v2: Support v2.2 PIC id3 v2.2 uses image format ("JPG","PNG") instead of mimetypes. Currently, the attached picture is skipped because the format string does not match a known picture mimetype. This patch fixes this behaviour. Signed-off-by: Mohammad Alsaleh <msal@tormail.org> Signed-off-by: Anton Khirnov <anton@khirnov.net>	12 years ago
Anton Khirnov	36ef5369ee	Replace all CODEC_ID_* with AV_CODEC_ID_*	12 years ago
Anton Khirnov	25b51b2c44	id3v2: add a mimetype for bmp pictures.	13 years ago
Anton Khirnov	ddb4431208	id3v2: fix skipping extended header in id3v2.4 In v2.4, the length includes the length field itself.	13 years ago
Kostya Shishkov	f704eb612b	id3v2: add another mimetype for JPEG image	13 years ago
Anton Khirnov	713f3062a7	id3v2: set the keyframe flag on attached pictures.	13 years ago
Anton Khirnov	393fd0d89e	id3v2: remove unused ff_id3v2_read(). Rename ff_id3v2_read_all to ff_id3v2_read().	13 years ago
Anton Khirnov	079ea6ca5f	lavf: export id3v2 attached pictures as streams.	13 years ago
Anton Khirnov	a93b09cb45	id3v2: read attached pictures and export them in ID3v2ExtraMeta.	13 years ago
Diego Biurrun	da9cea77e3	Fix a bunch of common typos.	13 years ago
Anton Khirnov	ec22979a1d	id3v2: fix type of ID3v2EMFunc.free()	13 years ago
Diego Biurrun	c4a378855e	id3v2: reduce the scope of some non-globally-used symbols/structures	13 years ago
Diego Biurrun	3b78c180e4	id3v2: cosmetics: move some declarations before the places they are used	13 years ago
Anton Khirnov	c780b543e7	id3v2: fix NULL pointer dereference Bug found by Laurent Aimar fenrir at videolan org	13 years ago
Anton Khirnov	60df6b0048	id3v2: remove pointless casts	13 years ago
Anton Khirnov	d2961e4ebf	id3v2: read TXXX frames with two calls to decode_str() instead of one. Read the key in the first, value in the second. This allows to avoid pointless strdups and simplify decode_str() by dropping two of its parameters.	13 years ago
Anton Khirnov	1e18d32d01	id3v2: don't discard the whole tag when encountering empty frames. While they're technically invalid, it's better to skip them and try to read the rest of the tag.	13 years ago
David Goldwich	7a019dffe5	id3v2: add support for non-text and GEOB type tag frames This extends the ID3v2 parser to allow for reading of non-text (i.e. other than T***) meta tag frames providing a ff_id3v2_read_all() function. An additional data structure 'ID3v2ExtraMeta' is introduced for these tags since AVDictionary is string oriented and unsuitable for binary data. A parser for tag frames of type GEOB is implemented, which is needed to extract keyring information from encrypted OMA files. GEOB data is parsed into 'ID3v2ExtraMetaGEOB' data structures. The routine to decode characters from different encodings to UTF-8, formerly part of the read_ttag() function, is moved to its own function. Because some tag frames contain subparts of unknown length, the function is now also able to read until a null character is found. In addition, the function now takes care of allocating a buffer long enough to hold the decoded characters. Signed-off-by: David Goldwich <david.goldwich@gmail.com> Signed-off-by: Anton Khirnov <anton@khirnov.net>	13 years ago
Anton Khirnov	d2d67e424f	Remove all uses of now deprecated metadata functions.	14 years ago
Alex Converse	86f868771b	id3v2: Check malloc result. ID3v2 tags can be very large.	14 years ago
Alex Converse	40a5dd2f35	id3v2: Initialize tflags for version 2.2.	14 years ago
Anton Khirnov	c5f4c0fd5c	id3v2: skip broken tags with invalid size fixes issue2649.	14 years ago
Anton Khirnov	1885488757	id3v2: don't explicitly skip padding It's pointless, since there's a seek to the end of tag later.	14 years ago
Anton Khirnov	eb1e7f78ea	id3v2: simplify error handling. Signed-off-by: Ronald S. Bultje <rsbultje@gmail.com>	14 years ago
Anton Khirnov	bca6dee386	id3v2: explicitly seek to the end of the tag after reading Current code might stop in the middle of an invalid tag. fixes issue2650 Signed-off-by: Ronald S. Bultje <rsbultje@gmail.com>	14 years ago
Mans Rullgard	2912e87a6c	Replace FFmpeg with Libav in licence headers Signed-off-by: Mans Rullgard <mans@mansr.com>	14 years ago
Anton Khirnov	45a8a02a41	lavf: replace avio_seek(SEEK_CUR) with avio_skip where it makes sense Signed-off-by: Ronald S. Bultje <rsbultje@gmail.com>	14 years ago
Anton Khirnov	56e2ac6b45	id3v2: merge TYER/TDAT/TIME to date tag	14 years ago
Anton Khirnov	fb61a7c534	id3v2: fix typo in error message Signed-off-by: Mans Rullgard <mans@mansr.com>	14 years ago
Anton Khirnov	a2704c9712	avio: add avio_tell macro as a replacement for url_ftell Signed-off-by: Ronald S. Bultje <rsbultje@gmail.com>	14 years ago
Anton Khirnov	e356fc57a2	lavf: replace all uses of url_fskip with avio_seek Signed-off-by: Ronald S. Bultje <rsbultje@gmail.com>	14 years ago
Anton Khirnov	6b4aa5dac8	avio: avio_ prefix for url_fseek Signed-off-by: Ronald S. Bultje <rsbultje@gmail.com>	14 years ago
Anton Khirnov	b7effd4e83	avio: avio_ prefixes for get_* functions In the name of consistency: get_byte -> avio_r8 get_<type> -> avio_r<type> get_buffer -> avio_read get_partial_buffer will be made private later get_strz is left out becase I want to change it later to return something useful. Signed-off-by: Ronald S. Bultje <rsbultje@gmail.com>	14 years ago
Anton Khirnov	e731b8d872	avio: move init_put_byte() to a new private header and rename it init_put_byte should never be used outside of lavf, since sizeof(AVIOContext) isn't part of public ABI. Signed-off-by: Ronald S. Bultje <rsbultje@gmail.com>	14 years ago
Anton Khirnov	ae628ec1fd	avio: rename ByteIOContext to AVIOContext. Signed-off-by: Ronald S. Bultje <rsbultje@gmail.com>	14 years ago
Anton Khirnov	cb6bc57681	id3v2: split tables for various ID3v2 versions This is needed for upcoming ID3v2.3 muxing support. Signed-off-by: Janne Grunau <janne-ffmpeg@jannau.net>	14 years ago
Anton Khirnov	d66eff3685	id3v2: use an enum for encodings instead of magic numbers. Signed-off-by: Mans Rullgard <mans@mansr.com>	14 years ago
Anton Khirnov	75aded8328	id3v2: don't overwrite existing tags Apparently some broken taggers prepend a new ID3v2 tag leaving the existing one intact. Our parser currently reads all tags and overwrites existing values with supposedly outdated ones. fixes issue2419 Signed-off-by: Mans Rullgard <mans@mansr.com>	14 years ago
Anton Khirnov	f7fcd6a254	id3v2: convert metadata after all the tags were read Signed-off-by: Mans Rullgard <mans@mansr.com>	14 years ago
Anton Khirnov	46a2da7698	id3v2: make ff_id3v2_parse static Signed-off-by: Mans Rullgard <mans@mansr.com>	14 years ago
Anton Khirnov	a152c77f26	id3v2: skip data length indicator Originally committed as revision 25926 to svn://svn.ffmpeg.org/ffmpeg/trunk	14 years ago

1 2

82 Commits (79d9884e9590c28a0a7ca802a3ba54f2ff4ee423)