FFmpeg

Commit Graph

Author	SHA1	Message	Date
Michael Niedermayer	24cfe91a22	id3v2: allocate large enough buffer Fixes array overread Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind Signed-off-by: Michael Niedermayer <michaelni@gmx.at>	12 years ago
Anton Khirnov	1afddbe59e	avpacket: use AVBuffer to allow refcounting the packets. This will allow us to avoid copying the packets in many cases. This breaks ABI.	12 years ago
Matthieu Bouron	b3b456b258	lavf/id3v2: seek back to previous offset if header size is not matched Makes ff_id3v2_read reset stream position at the end of ID3 data if the header size is not matched (caused by an EOF for example). Current behaviour (without the patch): filesize = 400 id3 data size = 399 file offset after ff_id3v2_read is 400 instead of 399 Signed-off-by: Michael Niedermayer <michaelni@gmx.at>	12 years ago
Matthieu Bouron	61625565e4	lavf/id3v2: cosmetics: reindent Signed-off-by: Michael Niedermayer <michaelni@gmx.at>	12 years ago
Michael Niedermayer	10416a4d56	id3v2: check index against buffer size. Fix out of array access Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind Signed-off-by: Michael Niedermayer <michaelni@gmx.at>	12 years ago
Michael Niedermayer	e9c372362c	id3v2: restructure compressed and unsync code This should fix the interaction between the 2. Signed-off-by: Michael Niedermayer <michaelni@gmx.at>	12 years ago
Michael Niedermayer	08e26e7f5c	id3v2: print ver/flags/len on debug level. Signed-off-by: Michael Niedermayer <michaelni@gmx.at>	12 years ago
Anton Khirnov	9ae80e6a9c	id3v2: fix reading unsynchronized frames. Current code would incorrectly process e.g. 'ff 00 ff 00 ff' to 'ff ff ff', while it should be 'ff ff 00 ff'. Fixes Bug 395. CC: libav-stable@libav.org	12 years ago
Paul B Mahol	07ed191b15	parse ID3v2 chapters Signed-off-by: Paul B Mahol <onemda@gmail.com>	12 years ago
Clément Bœsch	049ce4facb	id3v2: strdup the genre name explicitly. It would have been done anyway in the av_dict_set() call. This simplifies the code and avoid a warning because of assigning a const string from ff_id3v1_genre_str to a non-const variable. Signed-off-by: Anton Khirnov <anton@khirnov.net>	12 years ago
Clément Bœsch	ffdd2e9144	lavf/id3v2: do not export empty fields. This also avoids a memleak. Signed-off-by: Anton Khirnov <anton@khirnov.net>	12 years ago
Piotr Bandurski	5081310b58	lavf: add missing new line to some error messages 2 Signed-off-by: Michael Niedermayer <michaelni@gmx.at>	12 years ago
Mohammad Alsaleh	6e9bbc6525	id3v2: Match PIC mimetype/format case-insensitively Some files' embedded art seems to have the mimetype 'image/JPG' instead of 'image/jpg'. Libav fails to parse those because it matches case-sensitively. Use av_strncasecmp() to fix this behaviour. Signed-off-by: Mohammad Alsaleh <msal@tormail.org> Signed-off-by: Anton Khirnov <anton@khirnov.net>	12 years ago
Mohammad Alsaleh	385ec296f1	id3v2: Support v2.2 PIC id3 v2.2 uses image format ("JPG","PNG") instead of mimetypes. Currently, the attached picture is skipped because the format string does not match a known picture mimetype. This patch fixes this behaviour. Signed-off-by: Mohammad Alsaleh <msal@tormail.org> Signed-off-by: Anton Khirnov <anton@khirnov.net>	12 years ago
Anton Khirnov	36ef5369ee	Replace all CODEC_ID_* with AV_CODEC_ID_*	12 years ago
Anton Khirnov	25b51b2c44	id3v2: add a mimetype for bmp pictures.	13 years ago
Piotr Bandurski	4d18f4c15b	id3v2: reject APICs with size of 0 fixes ticket #1324 Signed-off-by: Michael Niedermayer <michaelni@gmx.at>	13 years ago
Clément Bœsch	e5fcf3646a	lavf/id3v2: always strdup the value. This simplifies the code but also fix a warning: ff_id3v1_genre_str array contains const strings so do the string dup now instead of in av_dict_set().	13 years ago
Clément Bœsch	6ad974ae1c	lavf/id3v2: do not export empty fields. This also avoids a memleak.	13 years ago
Anton Khirnov	ddb4431208	id3v2: fix skipping extended header in id3v2.4 In v2.4, the length includes the length field itself.	13 years ago
Kostya Shishkov	f704eb612b	id3v2: add another mimetype for JPEG image	13 years ago
Piotr Bandurski	3c6397404b	id3v2: support JPEG APIC with incorrect (image/jpg) MIME type Signed-off-by: Michael Niedermayer <michaelni@gmx.at>	13 years ago
Anton Khirnov	713f3062a7	id3v2: set the keyframe flag on attached pictures.	13 years ago
Anton Khirnov	393fd0d89e	id3v2: remove unused ff_id3v2_read(). Rename ff_id3v2_read_all to ff_id3v2_read().	13 years ago
Anton Khirnov	079ea6ca5f	lavf: export id3v2 attached pictures as streams.	13 years ago
Anton Khirnov	a93b09cb45	id3v2: read attached pictures and export them in ID3v2ExtraMeta.	13 years ago
Jean First	acc88f07d4	id3v2: fix compiler warning for uninitialized variables Signed-off-by: Jean First <jeanfirst@gmail.com> Signed-off-by: Michael Niedermayer <michaelni@gmx.at>	13 years ago
Michael Niedermayer	084bd109fc	id3v2: fix variable type for uncompress() Signed-off-by: Michael Niedermayer <michaelni@gmx.at>	13 years ago
Adrian Drzewiecki	7e09fe15d5	Process compressed id3v2 tags. ID3v2.4 allows for zlib compressed tags, but libavformat skips them. Implement code to inflate compressed tags. Signed-off-by: Michael Niedermayer <michaelni@gmx.at>	13 years ago
Diego Biurrun	da9cea77e3	Fix a bunch of common typos.	13 years ago
Michael Niedermayer	aedd30b63a	id3v2: Fix null ptr crash in get_extra_meta_func() Signed-off-by: Michael Niedermayer <michaelni@gmx.at>	13 years ago
Adrian Drzewiecki	dd7453a24e	Fix id3v2 extended header handling. When skipping over the extended header, take into account that the size field has already been read. The extended header also takes up space, so adjust total header length accordingly. Signed-off-by: Michael Niedermayer <michaelni@gmx.at>	13 years ago
Anton Khirnov	ec22979a1d	id3v2: fix type of ID3v2EMFunc.free()	13 years ago
Diego Biurrun	c4a378855e	id3v2: reduce the scope of some non-globally-used symbols/structures	13 years ago
Diego Biurrun	3b78c180e4	id3v2: cosmetics: move some declarations before the places they are used	13 years ago
Anton Khirnov	c780b543e7	id3v2: fix NULL pointer dereference Bug found by Laurent Aimar fenrir at videolan org	13 years ago
Anton Khirnov	60df6b0048	id3v2: remove pointless casts	13 years ago
Anton Khirnov	d2961e4ebf	id3v2: read TXXX frames with two calls to decode_str() instead of one. Read the key in the first, value in the second. This allows to avoid pointless strdups and simplify decode_str() by dropping two of its parameters.	13 years ago
Anton Khirnov	1e18d32d01	id3v2: don't discard the whole tag when encountering empty frames. While they're technically invalid, it's better to skip them and try to read the rest of the tag.	13 years ago
Reimar Döffinger	a1526cd78f	id3v2: Fix some (function) pointer types. Signed-off-by: Reimar Döffinger <Reimar.Doeffinger@gmx.de> Signed-off-by: Michael Niedermayer <michaelni@gmx.at>	13 years ago
Laurent Aimar	f57b00e897	Fixed NULL pointer dereference in id3v2 parser. Signed-off-by: Michael Niedermayer <michaelni@gmx.at>	13 years ago
David Goldwich	7a019dffe5	id3v2: add support for non-text and GEOB type tag frames This extends the ID3v2 parser to allow for reading of non-text (i.e. other than T***) meta tag frames providing a ff_id3v2_read_all() function. An additional data structure 'ID3v2ExtraMeta' is introduced for these tags since AVDictionary is string oriented and unsuitable for binary data. A parser for tag frames of type GEOB is implemented, which is needed to extract keyring information from encrypted OMA files. GEOB data is parsed into 'ID3v2ExtraMetaGEOB' data structures. The routine to decode characters from different encodings to UTF-8, formerly part of the read_ttag() function, is moved to its own function. Because some tag frames contain subparts of unknown length, the function is now also able to read until a null character is found. In addition, the function now takes care of allocating a buffer long enough to hold the decoded characters. Signed-off-by: David Goldwich <david.goldwich@gmail.com> Signed-off-by: Anton Khirnov <anton@khirnov.net>	13 years ago
Anton Khirnov	d2d67e424f	Remove all uses of now deprecated metadata functions.	14 years ago
Alex Converse	86f868771b	id3v2: Check malloc result. ID3v2 tags can be very large.	14 years ago
Alex Converse	40a5dd2f35	id3v2: Initialize tflags for version 2.2.	14 years ago
Stefano Sabatini	64be0d1eda	id3v2: prevent unsigned integer overflow in ff_id3v2_parse() In ff_id3v2_parse(), prevent unsigned integer overflow if data length indicator is skipped and tlen is < 4. Fix crash decoding file Allaby_cut.mp3, fix trac issue #182.	14 years ago
Stefano Sabatini	b69e5ee902	id3v2: add @file doxy and link to format documentation	14 years ago
Anton Khirnov	c5f4c0fd5c	id3v2: skip broken tags with invalid size fixes issue2649.	14 years ago
Anton Khirnov	1885488757	id3v2: don't explicitly skip padding It's pointless, since there's a seek to the end of tag later.	14 years ago
Anton Khirnov	eb1e7f78ea	id3v2: simplify error handling. Signed-off-by: Ronald S. Bultje <rsbultje@gmail.com>	14 years ago

1 2 3 4

194 Commits (648b8cca6c56a4fa1760efc72dfe1363a5c6e31e)