Andreas Rheinhardt
dfe7c7ffce
avcodec/vorbis: Split data declarations out into new header
...
vorbis.h currently contains stuff only used by the native
Vorbis codecs and some Vorbis tables, which are also used by
Opus and libvorbis. Therefore split the data out into a header
of its own.
Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
2 years ago
Dale Curtis
95bacb521a
avcodec/vorbis: Fix another 1 << 31 > int32_t::max() with 1u.
...
Didn't notice this one when 9648cc6d
was landed.
Signed-off-by: Dale Curtis <dalecurtis@chromium.org>
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
7 years ago
Dale Curtis
9648cc6d7f
avcodec/vorbis: 1 << 31 > int32_t::max(), so use 1u << 31 instead.
...
Signed-off-by: Dale Curtis <dalecurtis@chromium.org>
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
7 years ago
Mark Thompson
c37de51920
vorbis: Reorder conditions to avoid possible overread
...
This can trigger a single-byte overread if the codebook has the maximum
number of entries.
Fixes #6743 .
7 years ago
Diego Biurrun
6d8fd614ff
vorbis: Kill some pointless debug code
9 years ago
Diego Biurrun
b668662939
get_bits: Move BITSTREAM_READER_LE definition before all relevant #includes
...
This avoids the danger that get_bits.h might get indirectly #included before
BITSTREAM_READER_LE is defined.
Also sort headers into canonical order where appropriate.
9 years ago
Michael Niedermayer
742d860103
avcodec/vorbis: fix decoding of single element huffman trees
...
Fixes Ticket2893
Signed-off-by: Michael Niedermayer <michaelni@gmx.at>
11 years ago
Michael Niedermayer
b918d6e2e6
avcodec/vorbis: return proper error codes from ff_vorbis_len2vlc()
...
Signed-off-by: Michael Niedermayer <michaelni@gmx.at>
11 years ago
Justin Ruggles
e951b6d94c
vorbisdec: cosmetics: rename variable avccontext to avctx
...
This is consistent with the rest of libavcodec.
12 years ago
Diego Biurrun
6f6b0311a3
avcodec: Drop some silly commented-out av_log() invocations
13 years ago
Alex Converse
ecf79c4d3e
vorbis: Validate that the floor 1 X values contain no duplicates.
...
Duplicate values in this vector are explicitly banned by the Vorbis I spec
and cause divide-by-zero crashes later on.
13 years ago
Ronald S. Bultje
24947d4988
vorbis: fix overflows in floor1[] vector and inverse db table index.
13 years ago
Chris Evans
57cd6d7095
vorbis: Avoid some out-of-bounds reads
...
Fixes Bug: #190
Chromium Bug: #100543
Related to CVE-2011-3893
Signed-off-by: Reinhard Tartler <siretart@tauware.de>
13 years ago
Michael Niedermayer
6fcf2bb8af
vorbis: Fix last quarter of CVE-2011-3893
...
Signed-off-by: Michael Niedermayer <michaelni@gmx.at>
13 years ago
Chris Evans
7149fce2ca
ogg: Avoid the possibility to read out-of-bounds of a static global array in Vorbis
...
decoding.
BUG=100543
Review URL: http://codereview.chromium.org/8365014
This fixes 25% of CVE-2011-3893
Signed-off-by: Michael Niedermayer <michaelni@gmx.at>
13 years ago
Diego Biurrun
aaf47bcde7
Drop ALT_ prefix from BITSTREAM_READER_LE name.
...
The prefix is a historic remnant that probably meant "alternative".
Now that the A32 bitstream reader has been dropped it makes no sense anymore.
13 years ago
Diego Biurrun
6168781f70
doxygen: do not include license boilerplate in Doxygen documentation
14 years ago
Diego Biurrun
f190f676bc
Replace custom DEBUG preprocessor trickery by the standard one.
14 years ago
Diego Biurrun
0a6b1a9f21
Replace int_fast integer types with their sized standard posix counterparts.
...
The _fast integer types provide no realworld benefits, but may introduce
portability issues and are just plain ugly.
14 years ago
Diego Biurrun
cf3ac54339
vorbis: Replace sized int_fast integer types with plain int/unsigned.
...
int/unsigned is the natural memory access type for CPUs, using sized types
for temporary variables, counters and similar just increases code size and
can possibly cause a slowdown.
14 years ago
Mans Rullgard
2912e87a6c
Replace FFmpeg with Libav in licence headers
...
Signed-off-by: Mans Rullgard <mans@mansr.com>
14 years ago
Diego Biurrun
ba87f0801d
Remove explicit filename from Doxygen @file commands.
...
Passing an explicit filename to this command is only necessary if the
documentation in the @file block refers to a file different from the
one the block resides in.
Originally committed as revision 22921 to svn://svn.ffmpeg.org/ffmpeg/trunk
15 years ago
Diego Biurrun
a7adcf29cf
whitespace cosmetics, prettyprinting, K&R coding style
...
Originally committed as revision 20080 to svn://svn.ffmpeg.org/ffmpeg/trunk
16 years ago
Diego Biurrun
0b8e7ab059
some more linebreak and brace placement cosmetics
...
Originally committed as revision 20071 to svn://svn.ffmpeg.org/ffmpeg/trunk
16 years ago
Diego Biurrun
5e56b30e1f
brace placement and linebreak cosmetics
...
Originally committed as revision 20070 to svn://svn.ffmpeg.org/ffmpeg/trunk
16 years ago
Reimar Döffinger
23638d8778
Remove unused variable.
...
Originally committed as revision 19745 to svn://svn.ffmpeg.org/ffmpeg/trunk
16 years ago
Loren Merritt
8fc9376c59
indent
...
Originally committed as revision 19727 to svn://svn.ffmpeg.org/ffmpeg/trunk
16 years ago
Loren Merritt
2f17f9c10c
1.5x faster ff_vorbis_floor1_render_list, 5% faster vorbis decoding on Core2.
...
1.3x and 3% on G4.
Though I think only part of this speedup is due to my optimizations per se;
some of it is that I got a better roll on the GCC random code generator.
Trivial reorderings of this function have a disproportionate effect on speed.
Originally committed as revision 19726 to svn://svn.ffmpeg.org/ffmpeg/trunk
16 years ago
Reimar Döffinger
5e039e1b4c
Add extra validation checks to ff_vorbis_len2vlc.
...
They should not be necessary, but it seems like a reasonable precaution.
Originally committed as revision 19374 to svn://svn.ffmpeg.org/ffmpeg/trunk
16 years ago
Stefano Sabatini
9106a698e7
Rename bitstream.h to get_bits.h.
...
Originally committed as revision 18494 to svn://svn.ffmpeg.org/ffmpeg/trunk
16 years ago
Diego Biurrun
bad5537e2c
Use full internal pathname in doxygen @file directives.
...
Otherwise doxygen complains about ambiguous filenames when files exist
under the same name in different subdirectories.
Originally committed as revision 16912 to svn://svn.ffmpeg.org/ffmpeg/trunk
16 years ago
Oded Shimon
05dee1b7df
Rename all vorbis encoder related typedefs to not use _t for POSIX compatibility
...
Originally committed as revision 16076 to svn://svn.ffmpeg.org/ffmpeg/trunk
16 years ago
Diego Biurrun
ccd425e799
Remove unnecessary parentheses from return calls.
...
Originally committed as revision 13069 to svn://svn.ffmpeg.org/ffmpeg/trunk
17 years ago
Loren Merritt
e1813a2f1e
30% faster ff_vorbis_floor1_render_list, 3% faster overall
...
Originally committed as revision 11883 to svn://svn.ffmpeg.org/ffmpeg/trunk
17 years ago
Diego Biurrun
e5a389a1b7
license header consistency cosmetics
...
Originally committed as revision 9484 to svn://svn.ffmpeg.org/ffmpeg/trunk
18 years ago
Aurelien Jacobs
07c55d8ea3
rename vorbis.c to vorbis_dec.c and vorbis_common.c to vorbis.c
...
Originally committed as revision 8981 to svn://svn.ffmpeg.org/ffmpeg/trunk
18 years ago
Aurelien Jacobs
f6bd6eeffd
loosen vorbis_enc.c dependencies by spliting vorbis.c
...
Originally committed as revision 8980 to svn://svn.ffmpeg.org/ffmpeg/trunk
18 years ago
Aurelien Jacobs
5bb127a98f
extract vorbis header spliting code into a reusable function
...
Original thread:
Date: Thu, 22 Mar 2007 20:23:08 -0400
Subject: [Ffmpeg-devel] [PATCH] Theora in MKV (GSoC '07 Qualification)
Originally committed as revision 8505 to svn://svn.ffmpeg.org/ffmpeg/trunk
18 years ago
Måns Rullgård
36cd306907
rename inverse -> ff_inverse
...
Originally committed as revision 6990 to svn://svn.ffmpeg.org/ffmpeg/trunk
19 years ago
Diego Biurrun
c26abfa541
Rename ABS macro to FFABS.
...
Originally committed as revision 6666 to svn://svn.ffmpeg.org/ffmpeg/trunk
19 years ago
Diego Biurrun
b78e7197a8
Change license headers to say 'FFmpeg' instead of 'this program/this library'
...
and fix GPL/LGPL version mismatches.
Originally committed as revision 6577 to svn://svn.ffmpeg.org/ffmpeg/trunk
19 years ago
Oded Shimon
7f09a56091
remove render_line from vorbis.h, add ff_vorbis_floor1_render_list instead
...
Originally committed as revision 6409 to svn://svn.ffmpeg.org/ffmpeg/trunk
19 years ago
Oded Shimon
6c29d7c8f3
make some more functions global so they can be shared with vorbis_enc.c
...
Originally committed as revision 6402 to svn://svn.ffmpeg.org/ffmpeg/trunk
19 years ago
Oded Shimon
9f963af5a0
make ready_floor1_list() shared for vorbis_enc.c
...
Originally committed as revision 6401 to svn://svn.ffmpeg.org/ffmpeg/trunk
19 years ago
Oded Shimon
cc0ba5a58f
vorbis.h -> vorbis_data.c
...
move tables from vorbis.h to a C file so they can be used later in
vorbis_enc.c
Originally committed as revision 6398 to svn://svn.ffmpeg.org/ffmpeg/trunk
19 years ago
Reimar Döffinger
544c449d12
Get rid of get_bits_long_le, get_bits_long was fixed and now behaves the same way.
...
Originally committed as revision 6334 to svn://svn.ffmpeg.org/ffmpeg/trunk
19 years ago
Oded Shimon
0e3cb7a1ff
fix to vorbis decoder for book==0
...
Originally committed as revision 6328 to svn://svn.ffmpeg.org/ffmpeg/trunk
19 years ago
Diego Biurrun
b7cff9ce7c
Remove unused variable.
...
Originally committed as revision 6223 to svn://svn.ffmpeg.org/ffmpeg/trunk
19 years ago
Loren Merritt
069720565c
vorbis simd tweaks
...
Originally committed as revision 5983 to svn://svn.ffmpeg.org/ffmpeg/trunk
19 years ago
Loren Merritt
0e0adae0ba
vorbis cosmetics: mdct0,mdct1 => mdct[2]
...
Originally committed as revision 5978 to svn://svn.ffmpeg.org/ffmpeg/trunk
19 years ago