FFmpeg

Commit Graph

Author	SHA1	Message	Date
Michael Niedermayer	a7ebd0b011	avcodec/mpegaudiodec_template: only allocate fdsp when its used Fixes memleak Signed-off-by: Michael Niedermayer <michaelni@gmx.at>	10 years ago
Michael Niedermayer	c5dc8cc03a	avcodec/mpegaudiodec_float: Use avpriv_float_dsp_alloc() Signed-off-by: Michael Niedermayer <michaelni@gmx.at>	10 years ago
Michael Niedermayer	c5e295cb9d	avcodec/mpegaudiodec_template: use av_freep(), do not leave stale pointers in memory Signed-off-by: Michael Niedermayer <michaelni@gmx.at>	10 years ago
Michael Niedermayer	81a663f49e	Drop remaining unneeded != NULL Reviewed-by: Clément Bœsch <u@pkh.me> Signed-off-by: Michael Niedermayer <michaelni@gmx.at>	10 years ago
Gabriel Dume	f929ab0569	cosmetics: Write NULL pointer equality checks more compactly Signed-off-by: Diego Biurrun <diego@biurrun.de>	10 years ago
Michael Niedermayer	bd650ee318	avcodec/mpegaudiodec: Reset dither and mdct state This makes the mp3 decoder produce the same result when repeatly flushing and decoding Suggested-by: Dale Curtis <dalecurtis@chromium.org> Signed-off-by: Michael Niedermayer <michaelni@gmx.at>	11 years ago
Michael Niedermayer	0be95996d0	avcodec/mpegaudiodec_template: make shift unsigned to avoid undefined behavior Signed-off-by: Michael Niedermayer <michaelni@gmx.at>	11 years ago
Michael Niedermayer	afbe8c6a84	avcodec/mpegaudiodec_template: decode_frame_mp3on4: conceal errors in decoding instead of discarding data Signed-off-by: Michael Niedermayer <michaelni@gmx.at>	11 years ago
Michael Niedermayer	2545182c29	avcodec/mpegaudiodec_template/mp3on4: check that all channels have been decoded before returnig a frame Fixes use of uninitialized memory Fixes: msan_uninit-mem_7f80bf9a259e_5774_id5_1.mp4 Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind Signed-off-by: Michael Niedermayer <michaelni@gmx.at>	11 years ago
Michael Niedermayer	c925e960e8	mp3on4: fail when the header check fails It seems the code assumed that when one out of multiple blocks fail some span of time is correct, its not, its some channels that are correct Fixes use of uninitialized memory Fixes: msan_uninit-mem_7f44a03ba3ce_5692_id5_1.mp4 Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind Signed-off-by: Michael Niedermayer <michaelni@gmx.at>	11 years ago
Martin Storsjö	35686a289f	mp3adu: Set the channel layout properly This fixes decoding, broken since `7e35037`. This is similar to what was done for the normal mp3 decoder in `f4a86bc9`. Signed-off-by: Martin Storsjö <martin@martin.st>	11 years ago
Michael Niedermayer	babb611d35	libavcodec/mpegaudio: change CONFIG_FLOAT to USE_FLOAT The CONFIG_ name-space is set by configure, so its better to use a different prefix here. This also unifies the encoder & decoder define that is used Signed-off-by: Michael Niedermayer <michaelni@gmx.at>	11 years ago
Diego Biurrun	0eeeb9647e	mpegaudiodec: Consistently handle fixed/float templating	11 years ago
Diego Biurrun	b2bed9325d	cosmetics: Group .name and .long_name together in codec/format declarations	11 years ago
Martin Storsjö	e9d61de96c	mpegaudiodec: Validate that the number of channels fits at the given offset This is similar to the fix in `35cbc98b`. Reported-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind CC: libav-stable@libav.org Signed-off-by: Martin Storsjö <martin@martin.st>	11 years ago
Diego Biurrun	6fee1b90ce	avcodec: Add av_cold attributes to init functions missing them	12 years ago
Diego Biurrun	088f38a4f9	avcodec: Drop unnecessary ff_ name prefixes from static functions	12 years ago
Paul B Mahol	a9b424879f	lavc & lavf: replace deprecated av_log* functions Signed-off-by: Paul B Mahol <onemda@gmail.com>	12 years ago
Clément Bœsch	1ec94b0f06	lavc: factorize ff_{thread_,re,}get_buffer error messages. Coccinelle profile used: @@ expression r, ctx, f, loglevel, str, flags; @@ -if ((r = ff_get_buffer(ctx, f, flags)) < 0) { - av_log(ctx, loglevel, str); - return r; -} +if ((r = ff_get_buffer(ctx, f, flags)) < 0) + return r; @@ expression r, ctx, f, loglevel, str; @@ -if ((r = ff_reget_buffer(ctx, f)) < 0) { - av_log(ctx, loglevel, str); - return r; -} +if ((r = ff_reget_buffer(ctx, f)) < 0) + return r; @@ expression r, ctx, f, loglevel, str, flags; @@ -if ((r = ff_thread_get_buffer(ctx, f, flags)) < 0) { - av_log(ctx, loglevel, str); - return r; -} +if ((r = ff_thread_get_buffer(ctx, f, flags)) < 0) + return r; ...along with some manual patches for the remaining ones.	12 years ago
Anton Khirnov	759001c534	lavc decoders: work with refcounted frames.	12 years ago
Diego Biurrun	c242bbd8b6	Remove unnecessary dsputil.h #includes	12 years ago
Justin Ruggles	2c785e250a	mpegaudio: decode directly to the user-provided AVFrame	12 years ago
Ronald S. Bultje	5959bfaca3	floatdsp: move butterflies_float from dsputil to avfloatdsp. This makes wmadec/enc, twinvq and mpegaudiodec (i.e. mp2/mp3) independent of dsputil.	12 years ago
Michael Niedermayer	4e0738cec9	mpegaudiodec/mp3on4: fix buffer size. The larger (and really ugly) size is not needed anymore. Found-by: Justin Ruggles Signed-off-by: Michael Niedermayer <michaelni@gmx.at>	12 years ago
Michael Niedermayer	51fcf276f8	mp3on4: fix null pointer dereference Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind Signed-off-by: Michael Niedermayer <michaelni@gmx.at>	12 years ago
Anton Khirnov	594d4d5df3	lavc: add a wrapper for AVCodecContext.get_buffer(). It will be useful in the upcoming transition to refcounted AVFrames.	12 years ago
Justin Ruggles	3ffed68c2a	mpegaudiodec: use planar sample format for output unless packed is requested	12 years ago
Michael Niedermayer	0efcf16a3e	replace av_log(0, by av_log(NULL, The first parameter is a pointer and NULL is more correct Signed-off-by: Michael Niedermayer <michaelni@gmx.at>	12 years ago
Justin Ruggles	a903f8f087	Include libavutil/channel_layout.h instead of libavutil/audioconvert.h Also reorder some other #include when applicable.	12 years ago
Luca Barbato	0c03cc6838	mp3: exit on parsing error in mp_decode_frame Properly forward mp_decode_layer3 errors, mp_decode_layer1 and mp_decode_layer2 do not return errors. Based on a patch by Michael Niedermayer.	12 years ago
Luca Barbato	9ab0874ea8	mp3: properly forward mp_decode_frame errors The function can return either a parsing error or a memory management error.	12 years ago
Michael Niedermayer	ec444c84cf	mpegaudiodec: Fix buffer handling on random access	12 years ago
Diego Biurrun	2f17f265ed	mpegaudio: Refactor mp3on4 flush function	12 years ago
Michael Niedermayer	5713091818	mpegaudiodec: Fix buffer handling on random access Signed-off-by: Michael Niedermayer <michaelni@gmx.at>	12 years ago
Michael Niedermayer	7696a392e2	mp3dec: propagate error code correctly. Signed-off-by: Michael Niedermayer <michaelni@gmx.at>	12 years ago
Diego Biurrun	1218777ffd	avcodec: Convert some commented-out printf/av_log instances to av_dlog	12 years ago
Diego Biurrun	6f6b0311a3	avcodec: Drop some silly commented-out av_log() invocations	12 years ago
Luca Barbato	97cfa55eea	mpegaudiodec: fix short_start calculation The value should be always 3, as it follows from the specification. Fix a stack buffer overflow in exponents_from_scale_factors as reported by asan. Thanks to Dale Curtis for the sample vector.	12 years ago
Michael Niedermayer	ac7d0c79c3	mp3dec: ask for 8khz switch point mp3s Signed-off-by: Michael Niedermayer <michaelni@gmx.at>	12 years ago
Michael Niedermayer	94041febc5	mp3dec: Fix possibly exploitable crash I was sadly unable to find a non fuzzed mp3 that uses the feature that contained the bug (and i searched hard ...), thus while this fixes the security issue. It may or may not fix mixed blocks in 8khz mp3s, i cant say due to lack of samples to test. Security issue exists since: `b37d945dd4` Reported-by: Dale Curtis <dalecurtis@google.com> (Probably) Found-by: inferno@chromium.org Signed-off-by: Michael Niedermayer <michaelni@gmx.at>	12 years ago
Michael Niedermayer	76fac07334	mpegaudiodec: replace pow(2.0,...) by exp2() Signed-off-by: Michael Niedermayer <michaelni@gmx.at>	12 years ago
Anton Khirnov	927e92cdc7	mpegaudiodec: don't print an error on > 1 frame in a packet. It's a perfectly normal situation, nothing to spam about.	12 years ago
Anton Khirnov	36ef5369ee	Replace all CODEC_ID_* with AV_CODEC_ID_*	12 years ago
Michael Niedermayer	29d1df66ad	mpegaudiodec: replace assert() by check under #ifdef DEBUG The assert can be false with some invalid inputs, the check is too expensive to always do though for just a warning message. Signed-off-by: Michael Niedermayer <michaelni@gmx.at>	12 years ago
Michael Niedermayer	a2f91e7bcd	mpegaudiodec: switch to av_assert Signed-off-by: Michael Niedermayer <michaelni@gmx.at>	12 years ago
Nedeljko Babic	6d74e3c6f2	Optimization of MP3 decoders for MIPS MP3 fixed and floating point decoders are optimized for MIPS architecture. Signed-off-by: Nedeljko Babic <nbabic@mips.com> Reviewed-by: Vitor Sessak <vitor1001@gmail.com> Signed-off-by: Michael Niedermayer <michaelni@gmx.at>	13 years ago
Kostya Shishkov	b37d945dd4	mp3: fix start band index for block type 2 in 8kHz audio In hybrid frames long window part ends at 36 samples for most of the cases but at 72 for 8kHz case. For some reason decoder assumed it's 48 or even 36 samples, which caused wrong bitstream decoding for such blocks. l3_25207.mpg from conformance suite demonstrates it the best.	13 years ago
Michael Niedermayer	c5371f775c	mpegaudidec: 10l forgot buf_size Signed-off-by: Michael Niedermayer <michaelni@gmx.at>	13 years ago
Michael Niedermayer	43bc5cf9f4	mpegaudiodec: skip initial zeros. Signed-off-by: Michael Niedermayer <michaelni@gmx.at>	13 years ago
Michael Niedermayer	3183c38aaa	mp3decoder: discard ID3 tags Signed-off-by: Michael Niedermayer <michaelni@gmx.at>	13 years ago

16 Commits (29d2197d880538550812db720539f8c4c4e89dc3)