Neil Birkbeck
a16243a4aa
libavformat/mov.c: allow QuickTime metadata to come after traks
...
QuickTime metadata can come after trak data. Add indicator for which trak is being parsed (-1 if none) so that global metadata after the trak can be parsed.
Signed-off-by: Neil Birkbeck <neil.birkbeck@gmail.com>
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
9 years ago
Michael Niedermayer
ab7ff38052
avformat/flvdec: Fix left shift of 137 by 24 places cannot be represented in type int
...
Fixes: 3c857d4d90365731524716e6d051e43a/signal_sigsegv_7f4f59bcc29e_1386_20abd2c8e655cb9c75b24368e65fe3b1.flv
Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
9 years ago
Michael Niedermayer
689a867413
avformat/msf: Check channels when reading the header
...
Fixes integer overflow
Fixes: 0c2625f236ced104d402b4a03c0d65c7/asan_generic_274e1ce_5990_9314e7a67c26aecf011b178ade9f217c.avi
Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
9 years ago
Clément Bœsch
43ecec0f03
avformat: use AV_OPT_TYPE_BOOL in a bunch of places
9 years ago
Andreas Cadhalpun
a611375db5
ffmdec: reject zero-sized chunks
...
If size is zero, avio_get_str fails, leaving the buffer uninitialized.
This causes invalid reads in av_set_options_string.
Reviewed-by: Michael Niedermayer <michael@niedermayer.cc>
Signed-off-by: Andreas Cadhalpun <Andreas.Cadhalpun@googlemail.com>
9 years ago
Andreas Cadhalpun
488e9a06f0
ffmdec: only seek back at EOF if a server is attached
...
Otherwise the ffm demuxer can return the same packets endlessly, if
there is no server attached.
Reviewed-by: Michael Niedermayer <michael@niedermayer.cc>
Signed-off-by: Andreas Cadhalpun <Andreas.Cadhalpun@googlemail.com>
9 years ago
Michael Niedermayer
0c1d62ab9d
avformat/oggparsetheora: Check duration to be not AV_NOPTS_VALUE (and positive) before use
...
Fixes: 1536b9b096a8f95b742bae9d3d761cc6/signal_sigsegv_294aaed_7322_4fad88a38dc8952dc20dcb60c1895758.ogg
Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
9 years ago
Yann Coupin
d89c4846e0
avformat/movenc: HE-AAC correct FourCC in ISML
...
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
9 years ago
Michael Niedermayer
9696a01f12
avformat/mpjpegdec: Fix "libavformat/mpjpegdec.c:269:9: warning: passing argument 3 of av_stristart from incompatible pointer type"
...
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
9 years ago
Sebastian Dröge
eb3628d87f
mpegtsenc: Fix off-by-one in indexing into Opus channel mapping arrays
...
Fixes, CID1338323, CID1338324
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
9 years ago
Michael Niedermayer
cafb195604
avformat/utils: Fix "libavformat/utils.c:927:35: runtime error: signed integer overflow: -2450238577049583619 - 9223090561878065151 cannot be represented in type long long"
...
Fixes Mozilla bug 1229205
Found-by: Tyson Smith
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
9 years ago
Michael Niedermayer
4e31176e14
avformat/riffdec: remove special case for bitrate > 32bit
...
AVCodecContext.bitrate is 64bit
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
9 years ago
Michael Niedermayer
32bf6550cb
avformat/riffdec: Initialize bitrate
...
Fixes CID1338334
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
9 years ago
Nicolas George
085ab74972
lavf/mpegts: use AVERROR_INVALIDDATA instead of AVERROR(EINTR).
9 years ago
Nicolas George
eb2e4fb674
lavf/lxfdec: use FFERROR_REDO instead of AVERROR(EAGAIN).
9 years ago
Nicolas George
cb14d30240
lavf/mpeg: use FFERROR_REDO instead of AVERROR(EAGAIN).
9 years ago
Nicolas George
0bac7a436b
lavf/flvdec: use FFERROR_REDO instead of AVERROR(EAGAIN).
...
Fix trac ticket #5041 .
9 years ago
Nicolas George
3ab1e5a48c
lavf: add FFERROR_REDO to let demuxers return no packet.
9 years ago
Timo Teräs
64f7db554e
mpegencts: Fix overflow in cbr mode period calculations
...
ts->mux_rate is int (signed 32-bit) type. The period calculations
will start to overflow when mux_rate > 5mbps. This fixes overflows
by converting first to 64-bit type.
Fixes #5044 .
Signed-off-by: Timo Teräs <timo.teras@iki.fi>
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
9 years ago
James Almer
9ac5beaa86
avformat/mpjpegdec: fix mixed declarations and code
9 years ago
Michael Niedermayer
ec7a3be11e
avformat/utils: Move end_time1 AV_NOPTS_VALUE Check after rescale
...
Fixes integer overflow
Fixes: 266ee543812e934f7b4a72923a2701d4/signal_sigabrt_7ffff6ae7cc9_7322_85218d61759d461bdf7387180e8000c9.ogg
Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
9 years ago
Michael Niedermayer
d872643cfe
avformat/utils: Check AVFormatContext->duration in compute_chapters_end() before use
...
Fixes integer overflow
Fixes: 266ee543812e934f7b4a72923a2701d4/signal_sigabrt_7ffff6ae7cc9_7322_85218d61759d461bdf7387180e8000c9.ogg
Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
9 years ago
Luca Barbato
5f3a081b42
avi: Spin out the logic to position to the next non-interleaved stream
...
Signed-off-by: Luca Barbato <lu_zero@gentoo.org>
9 years ago
Michael Niedermayer
0fc61c6ab6
avi: Validate the stream-id for DV as well
...
Avoid false positives while syncing.
Bug-Id: ffmpeg/4086
Bug-Id: 879
Signed-off-by: Michael Niedermayer <michaelni@gmx.at>
Signed-off-by: Luca Barbato <lu_zero@gentoo.org>
9 years ago
Luca Barbato
d017ed878a
avi: Use the correct data type
...
avio_tell returns an int64_t.
9 years ago
Alex Agranovsky
259c71c199
avformat/mpjpeg: utilize MIME boundary value to detect start of new frame
...
This code is disabled by default so not to regress endpoints sending invalid MIME, but can be enabled via AVOption 'strict_mime_boundary'
Signed-off-by: Alex Agranovsky <alex@sighthound.com>
9 years ago
Alex Agranovsky
79103f2199
avformat/mpjpeg: allow processing of MIME parts without Content-Length header
...
Fixes ticket 5023
Signed-off-by: Alex Agranovsky <alex@sighthound.com>
9 years ago
Carl Eugen Hoyos
d208acf2c8
lavf/rtpenc_jpeg: Less strict check for standard Huffman tables.
...
There can be one or more Huffman table segments DHT.
Reported-by: Andrey Utkin
9 years ago
Aaron Colwell
ec83efd4d3
avformat/matroskadec: Fix sample_aspect_ratio for stereo matroska content
...
matroskaenc.c applies divisors to the display width/height when generating
stereo content. This patch adds the corresponding multipliers to matroskadec.c
so that the original sample aspect ratio can be recovered.
Signed-off-by: wm4 <nfxjfg@googlemail.com>
9 years ago
Chris Cunningham
5e6ce28dab
avformat/mp3dec: prefer "fast_seek" to TOC seek for CBR files.
...
"Fast seek" uses linear interpolation to find the position of the
requested seek time. For CBR this is more direct than using the
mp3 TOC and bypassing the TOC avoids problems with TOC precision.
(see https://crbug.com/545914#c13 )
For VBR, fast seek is not precise, so continue to prefer the TOC
when available (the lesser of two evils).
Also, some re-ordering of the logic in mp3_seek to simplify and
give usetoc=1 precedence over fastseek flag.
Signed-off-by: wm4 <nfxjfg@googlemail.com>
9 years ago
Michael Niedermayer
8e7f452022
avformat/dump: Fix integer overflow in av_dump_format()
...
Fixes part of mozilla bug 1229167
Found-by: Tyson Smith
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
9 years ago
Mohamed Naufal
ca5f386e75
lavf: G.723.1 muxer
...
Signed-off-by: Vittorio Giovara <vittorio.giovara@gmail.com>
9 years ago
Carl Eugen Hoyos
ec494e6c83
lavf/mxfdec: Set width to actual coded_width for AVCI50.
...
Fixes ticket #5029 .
Reported and analyzed by videolan trac user HenkDemper in vlc ticket #15762 .
9 years ago
Hendrik Leppkes
2ea38a946d
avformat/mlpdec: consider all valid mlp access units when probing
...
Fixes probing of truehd/mlp files with a lot of frames in between the
major sync frames. The spec allows a distance of up to 128 frames in
between major sync frames, which leads to the probing code not reaching
the desired score.
9 years ago
Luca Barbato
a0fa6d06b8
matroska: Warn when metadata references a non-existent element
...
Avoid some confusion when the information is not present.
Bug-Id: 902
9 years ago
Luca Barbato
f7986239f4
dvenc: Validate the frame size before copying it
9 years ago
Matthieu Bouron
72eaf72623
lavf/utils: avoid decoding a frame to get the codec parameters
...
Avoid decoding a frame to get the codec parameters while the codec
supports FF_CODEC_CAP_SKIP_FRAME_FILL_PARAM. This is particulary useful
to avoid decoding twice images (once in avformat_find_stream_info and
once when the actual decode is made).
9 years ago
Rodger Combs
362c17e656
lavf/http: fix incorrect warning in range requests
9 years ago
Luca Barbato
0e2395293b
nut: Mark non-fatal errors as warnings
...
And make one more informative.
9 years ago
Luca Barbato
62f72b40c0
nut: Provide more information on failure
9 years ago
Luca Barbato
2c17fb61ce
rtsp: Log getaddrinfo failures
...
And forward the logging contexts when needed.
9 years ago
Luca Barbato
12b1438286
udp: Provide additional information on getaddrinfo failure
9 years ago
Luca Barbato
34af7813f7
udp: Use the logging context
9 years ago
Luca Barbato
98063bcf15
rtsp: Do not assume getnameinfo cannot fail
...
And properly report the error when it happens.
9 years ago
Marton Balint
65406b0bed
concatdec: add option for adding segment start time and duration metadata
...
Reviewed-by: Nicolas George <george@nsup.org>
Signed-off-by: Marton Balint <cus@passwd.hu>
9 years ago
Marton Balint
ba9191ab3a
concatdec: simplify duration calculation in open_next_file
...
If duration is still AV_NOPTS_VALUE when opening the next file, we can assume
that outpoint is not set.
Reviewed-by: Nicolas George <george@nsup.org>
Signed-off-by: Marton Balint <cus@passwd.hu>
9 years ago
Marton Balint
8f60663c8b
concatdec: calculate duration early if outpoint is known
...
Reviewed-by: Nicolas George <george@nsup.org>
Signed-off-by: Marton Balint <cus@passwd.hu>
9 years ago
Michael Niedermayer
5b70fb8fee
movenc-test: Fix integer overflows
...
Signed-off-by: Martin Storsjö <martin@martin.st>
9 years ago
Timothy Gu
12a419dacb
avformat/v210: Check width and height
...
Fixes a floating point exception when width and height are not supplied
(and therefore are zero).
9 years ago
Timothy Gu
e1a214cadf
avformat/rawvideodec: Rework packet size calculation
...
Calculate packet size only once, and propagate errors earlier in the chain.
Also remove use of the deprecated av_image_get_buffer_size().
9 years ago