From fab1562a50684783f5567c5262c942f5cda9656f Mon Sep 17 00:00:00 2001 From: Ganesh Ajjanagadde Date: Tue, 27 Oct 2015 19:58:41 -0400 Subject: [PATCH] avutil/ripemd: make rol macro more robust by adding parentheses This ensures that the macro remains correct in the sense of allowing expressions for value and bits, by placing the value and bits expressions within parentheses. Reviewed-by: James Almer Signed-off-by: Ganesh Ajjanagadde --- libavutil/ripemd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavutil/ripemd.c b/libavutil/ripemd.c index d247fb4fc7..6777c994f8 100644 --- a/libavutil/ripemd.c +++ b/libavutil/ripemd.c @@ -85,7 +85,7 @@ static const int WB[80] = { 12, 15, 10, 4, 1, 5, 8, 7, 6, 2, 13, 14, 0, 3, 9, 11 }; -#define rol(value, bits) ((value << bits) | (value >> (32 - bits))) +#define rol(value, bits) (((value) << (bits)) | ((value) >> (32 - (bits)))) #define ROUND128_0_TO_15(a,b,c,d,e,f,g,h) \ a = rol(a + (( b ^ c ^ d) + block[WA[n]]), ROTA[n]); \