From edfe609fc9466cbd4f847afac430545799a66e14 Mon Sep 17 00:00:00 2001 From: Luca Barbato Date: Tue, 14 May 2013 22:15:18 +0200 Subject: [PATCH 1/2] configure: Add basic valgrind-massif support With the parameter --toolchain valgrind-massif, the configure script sets reasonable defaults that can be overridden as explained in the documentation. --- configure | 4 ++++ doc/developer.texi | 7 ++++--- 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/configure b/configure index 94804bd8dd..f39a860dc3 100755 --- a/configure +++ b/configure @@ -2211,6 +2211,10 @@ case "$toolchain" in add_cflags -fsanitize=thread -pie add_ldflags -fsanitize=thread -pie ;; + valgrind-massif) + target_exec_default="valgrind" + target_exec_args="--alloc-fn=av_malloc --alloc-fn=av_mallocz" + ;; valgrind-memcheck) target_exec_default="valgrind" target_exec_args="--track-origins=yes --leak-check=full" diff --git a/doc/developer.texi b/doc/developer.texi index c3d0f2065c..58635f808f 100644 --- a/doc/developer.texi +++ b/doc/developer.texi @@ -578,9 +578,10 @@ new test. The configure script provides a shortcut for using valgrind to spot bugs related to memory handling. Just add the option -@code{--toolchain=valgrind-memcheck} to your configure line, and -reasonable defaults will be set for running FATE under the supervision -of the @strong{memcheck} tool of the valgrind suite. +@code{--toolchain=valgrind-memcheck} or @code{--toolchain=valgrind-massif} +to your configure line, and reasonable defaults will be set for running +FATE under the supervision of either the @strong{memcheck} or the +@strong{massif} tool of the valgrind suite. In case you need finer control over how valgrind is invoked, use the @code{--target-exec='valgrind } option in From 8e673efc6f5b7a095557664660305148f2788d30 Mon Sep 17 00:00:00 2001 From: Kostya Shishkov Date: Sat, 18 May 2013 07:09:47 +0200 Subject: [PATCH 2/2] prores: update FATE test to account for alpha plane present in the test sample --- tests/fate/prores.mak | 2 +- tests/ref/fate/prores-alpha | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/fate/prores.mak b/tests/fate/prores.mak index 9c1a1b1eec..ccc71af4c0 100644 --- a/tests/fate/prores.mak +++ b/tests/fate/prores.mak @@ -11,4 +11,4 @@ fate-prores-422: CMD = framecrc -i $(SAMPLES)/prores/Sequence_1-Apple_ProR fate-prores-422_hq: CMD = framecrc -i $(SAMPLES)/prores/Sequence_1-Apple_ProRes_422_HQ.mov -pix_fmt yuv422p10le fate-prores-422_lt: CMD = framecrc -i $(SAMPLES)/prores/Sequence_1-Apple_ProRes_422_LT.mov -pix_fmt yuv422p10le fate-prores-422_proxy: CMD = framecrc -i $(SAMPLES)/prores/Sequence_1-Apple_ProRes_422_Proxy.mov -pix_fmt yuv422p10le -fate-prores-alpha: CMD = framecrc -i $(SAMPLES)/prores/Sequence_1-Apple_ProRes_with_Alpha.mov -pix_fmt yuv444p10le +fate-prores-alpha: CMD = framecrc -i $(SAMPLES)/prores/Sequence_1-Apple_ProRes_with_Alpha.mov -pix_fmt yuva444p10le diff --git a/tests/ref/fate/prores-alpha b/tests/ref/fate/prores-alpha index 80442fe7b5..97be6cf236 100644 --- a/tests/ref/fate/prores-alpha +++ b/tests/ref/fate/prores-alpha @@ -1,3 +1,3 @@ #tb 0: 1/2997 -0, 0, 0, 0, 12441600, 0x254d8f95 -0, 100, 100, 0, 12441600, 0x254d8f95 +0, 0, 0, 0, 16588800, 0x8dcdb600 +0, 100, 100, 0, 16588800, 0x8dcdb600