avformat/hlsenc: fix base_output_dirname is null when basename_size is 0 bug

fix ticket id: #6777
when use argument hls_segment_filename, the basename_size will be 0

Signed-off-by: Steven Liu <lq@onvideo.cn>
pull/272/head
Steven Liu 7 years ago
parent ca2b779423
commit f520830761
  1. 10
      libavformat/hlsenc.c

@ -1335,6 +1335,7 @@ static int hls_write_header(AVFormatContext *s)
AVDictionary *options = NULL; AVDictionary *options = NULL;
int basename_size = 0; int basename_size = 0;
int vtt_basename_size = 0; int vtt_basename_size = 0;
int fmp4_init_filename_len = strlen(hls->fmp4_init_filename) + 1;
if (hls->segment_type == SEGMENT_TYPE_FMP4) { if (hls->segment_type == SEGMENT_TYPE_FMP4) {
pattern = "%d.m4s"; pattern = "%d.m4s";
@ -1445,7 +1446,6 @@ static int hls_write_header(AVFormatContext *s)
} }
if (av_strcasecmp(hls->fmp4_init_filename, "init.mp4")) { if (av_strcasecmp(hls->fmp4_init_filename, "init.mp4")) {
int fmp4_init_filename_len = strlen(hls->fmp4_init_filename) + 1;
hls->base_output_dirname = av_malloc(fmp4_init_filename_len); hls->base_output_dirname = av_malloc(fmp4_init_filename_len);
if (!hls->base_output_dirname) { if (!hls->base_output_dirname) {
ret = AVERROR(ENOMEM); ret = AVERROR(ENOMEM);
@ -1453,19 +1453,25 @@ static int hls_write_header(AVFormatContext *s)
} }
av_strlcpy(hls->base_output_dirname, hls->fmp4_init_filename, fmp4_init_filename_len); av_strlcpy(hls->base_output_dirname, hls->fmp4_init_filename, fmp4_init_filename_len);
} else { } else {
if (basename_size > 0) {
hls->base_output_dirname = av_malloc(basename_size); hls->base_output_dirname = av_malloc(basename_size);
} else {
hls->base_output_dirname = av_malloc(strlen(hls->fmp4_init_filename));
}
if (!hls->base_output_dirname) { if (!hls->base_output_dirname) {
ret = AVERROR(ENOMEM); ret = AVERROR(ENOMEM);
goto fail; goto fail;
} }
if (basename_size > 0) {
av_strlcpy(hls->base_output_dirname, s->filename, basename_size); av_strlcpy(hls->base_output_dirname, s->filename, basename_size);
p = strrchr(hls->base_output_dirname, '/'); p = strrchr(hls->base_output_dirname, '/');
}
if (p) { if (p) {
*(p + 1) = '\0'; *(p + 1) = '\0';
av_strlcat(hls->base_output_dirname, hls->fmp4_init_filename, basename_size); av_strlcat(hls->base_output_dirname, hls->fmp4_init_filename, basename_size);
} else { } else {
av_strlcpy(hls->base_output_dirname, hls->fmp4_init_filename, basename_size); av_strlcpy(hls->base_output_dirname, hls->fmp4_init_filename, fmp4_init_filename_len);
} }
} }

Loading…
Cancel
Save