lavc/vp9: reset segmentation fields when segmentation isn't enabled

Fields under the segmentation switch are never reset on a new frame, and
retain the value from the previous frame. This bugs out a bunch of
hwaccel drivers when segmentation is disabled but update_map isn't
reset because they don't ignore values behind switches. This commit also
resets the temporal field, though it may not be required.

We also do this for vp8 [1] so this commit is just mirroring the vp8
logic.

This fixes an issue with certain samples [2] that causes blocky
artifacts with vaapi, d3d11va and cuda (and possibly others).
Mesa worked around [3] this by ignoring these fields if
segmentation.enabled is 0, but d3d11va still displays blocky artifacts.

[1] 2e877090f9:/libavcodec/vp8.c#l797
[2] https://github.com/mpv-player/mpv/issues/13533
[3] https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27816

Signed-off-by: llyyr <llyyr.public@gmail.com>
release/6.1
llyyr 7 months ago committed by Hendrik Leppkes
parent 2ffc47b37d
commit e821e6c21d
No known key found for this signature in database
GPG Key ID: 846079A4B0A7C1B5
  1. 6
      libavcodec/vp9.c

@ -719,6 +719,12 @@ static int decode_frame_header(AVCodecContext *avctx,
s->s.h.segmentation.feat[i].skip_enabled = get_bits1(&s->gb);
}
}
} else {
// Reset fields under segmentation switch if segmentation is disabled.
// This is necessary because some hwaccels don't ignore these fields
// if segmentation is disabled.
s->s.h.segmentation.temporal = 0;
s->s.h.segmentation.update_map = 0;
}
// set qmul[] based on Y/UV, AC/DC and segmentation Q idx deltas

Loading…
Cancel
Save