From c9a9dbfebf749f0fa8d938e6f64adaef438ea9f9 Mon Sep 17 00:00:00 2001 From: Michael Niedermayer Date: Fri, 20 Oct 2023 18:20:14 +0200 Subject: [PATCH] avcodec/apedec: Fix integer overflow in predictor_decode_stereo_3950() Fixes: signed integer overflow: 1900031961 + 553590817 cannot be represented in type 'int' Fixes: 63061/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_APE_fuzzer-5166188298371072 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer (cherry picked from commit 2def61778777e998e2ac538f56b8e6779b0ca8c1) Signed-off-by: Michael Niedermayer --- libavcodec/apedec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/apedec.c b/libavcodec/apedec.c index 8bfbb75b41..d31c067152 100644 --- a/libavcodec/apedec.c +++ b/libavcodec/apedec.c @@ -1284,7 +1284,7 @@ static void predictor_decode_stereo_3950(APEContext *ctx, int count) *decoded1++ = a1; if (num_passes > 1) { int32_t left = a1 - (unsigned)(a0 / 2); - int32_t right = left + a0; + int32_t right = left + (unsigned)a0; if (FFMAX(FFABS(left), FFABS(right)) > (1<<23)) { ctx->interim_mode = !interim_mode;