From ab5d46df1656a23cb75b005a3d7730e189e38c4d Mon Sep 17 00:00:00 2001 From: Michael Niedermayer Date: Mon, 3 Mar 2014 17:04:57 +0100 Subject: [PATCH] avformat/httpauth: add comment about "" and algorithm Suggested-by: ubitux Signed-off-by: Michael Niedermayer --- libavformat/httpauth.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavformat/httpauth.c b/libavformat/httpauth.c index 3f90975ff3..dbe3eff48f 100644 --- a/libavformat/httpauth.c +++ b/libavformat/httpauth.c @@ -224,8 +224,11 @@ static char *make_digest_auth(HTTPAuthState *state, const char *username, av_strlcatf(authstr, len, ",nonce=\"%s\"", digest->nonce); av_strlcatf(authstr, len, ",uri=\"%s\"", uri); av_strlcatf(authstr, len, ",response=\"%s\"", response); + + // we are violating the RFC and use "" because all others seem to do that too. if (digest->algorithm[0]) av_strlcatf(authstr, len, ",algorithm=\"%s\"", digest->algorithm); + if (digest->opaque[0]) av_strlcatf(authstr, len, ",opaque=\"%s\"", digest->opaque); if (digest->qop[0]) {