Fix a bug in av_find_opt(). Because some of the AVOption structures have field

unit = NULL, the function could pass NULL to strcmp and cause a segfault.

Patch by Kamil Nowosad, k nowosad % students mimuw edu pl.

Original thread:
Subject: [PATCH] small bugfix in av_find_opt()
Date: 03/23/2007 12:20 PM

Originally committed as revision 8553 to svn://svn.ffmpeg.org/ffmpeg/trunk
pull/126/head
Kamil Nowosad 18 years ago committed by Panagiotis Issaris
parent 226d6947bc
commit a4072c453b
  1. 2
      libavcodec/opt.c

@ -36,7 +36,7 @@ const AVOption *av_find_opt(void *v, const char *name, const char *unit, int mas
const AVOption *o= c->option;
for(;o && o->name; o++){
if(!strcmp(o->name, name) && (!unit || !strcmp(o->unit, unit)) && (o->flags & mask) == flags )
if(!strcmp(o->name, name) && (!unit || (o->unit && !strcmp(o->unit, unit))) && (o->flags & mask) == flags )
return o;
}
return NULL;

Loading…
Cancel
Save