From a212a983c7f4faf06e600f32a165592dc5b6ae76 Mon Sep 17 00:00:00 2001 From: Michael Niedermayer Date: Thu, 3 Sep 2015 14:52:18 +0200 Subject: [PATCH] avfilter/avf_showwaves: Check max_samples Fixes potential division by zero Fixes: CID1292295 Reviewed-by: Ganesh Ajjanagadde Signed-off-by: Michael Niedermayer --- libavfilter/avf_showwaves.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/libavfilter/avf_showwaves.c b/libavfilter/avf_showwaves.c index 57a6b2e149..a19acf54b9 100644 --- a/libavfilter/avf_showwaves.c +++ b/libavfilter/avf_showwaves.c @@ -203,6 +203,11 @@ static int push_single_pic(AVFilterLink *outlink) int col = 0; int64_t *sum = showwaves->sum; + if (max_samples == 0) { + av_log(ctx, AV_LOG_ERROR, "Too few samples\n"); + return AVERROR(EINVAL); + } + av_log(ctx, AV_LOG_DEBUG, "Create frame averaging %"PRId64" samples per column\n", max_samples); memset(sum, 0, nb_channels);