From 805ec95f8eb5664bf11c4c9190c868fd5521d80a Mon Sep 17 00:00:00 2001 From: Andreas Rheinhardt Date: Fri, 3 Sep 2021 22:05:21 +0200 Subject: [PATCH] avformat/mux: Sanitize packets without data and side-data The BSF API treats such packets as signalling EOF and therefore such a packet might corrupt the BSF state. In such a case, the guarantee that av_interleaved_write_frame() always frees the packet is not upheld. Signed-off-by: Andreas Rheinhardt --- libavformat/mux.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/libavformat/mux.c b/libavformat/mux.c index 2053a5636e..d7b2bdb4b3 100644 --- a/libavformat/mux.c +++ b/libavformat/mux.c @@ -787,6 +787,13 @@ static int prepare_input_packet(AVFormatContext *s, AVStream *st, AVPacket *pkt) if (sti->is_intra_only) pkt->flags |= AV_PKT_FLAG_KEY; + if (!pkt->data && !pkt->side_data_elems) { + /* Such empty packets signal EOS for the BSF API; so sanitize + * the packet by allocating data of size 0 (+ padding). */ + av_buffer_unref(&pkt->buf); + return av_packet_make_refcounted(pkt); + } + return 0; }