avcodec/gdv: Remove dead check

At the end of its decode function, the decoder sets *got_frame to 1 and
then checks whether ret is < 0; if so, it is returned, otherwise
avpkt->size is. But it is impossible for ret to be < 0 here and if it
were, it would be nonsense to set *got_frame to 1 before this. Therefore
just return avpkt->size unconditionally.

Fixes Coverity issue #1439730.

Reviewed-by: Paul B Mahol <onemda@gmail.com>
Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@gmail.com>
pull/358/head
Andreas Rheinhardt 4 years ago
parent d2dcb113f8
commit 7e8306dd2d
  1. 2
      libavcodec/gdv.c

@ -551,7 +551,7 @@ static int gdv_decode_frame(AVCodecContext *avctx, void *data,
*got_frame = 1;
return ret < 0 ? ret : avpkt->size;
return avpkt->size;
}
static av_cold int gdv_decode_close(AVCodecContext *avctx)

Loading…
Cancel
Save