Chiebot-Mirror
/
FFmpeg
mirror of https://github.com/FFmpeg/FFmpeg.git
8
0
Fork 0
Code Issues Projects Releases Wiki Activity

tools/qt-faststart: Fix unintended sign extension of atom_size

Browse Source 
Fixes CID733810

Signed-off-by: Michael Niedermayer <michaelni@gmx.at>
pull/23/merge
Michael Niedermayer 12 years ago
parent c1075d6af7
commit 69ce34c796
1 changed files with 2 additions and 2 deletions
Whitespace
Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL
Unified View
Diff Options
Show Stats Download Patch File Download Diff File
  1. 4
      tools/qt-faststart.c

4
tools/qt-faststart.c
Unescape View File

@ -229,7 +229,7 @@ int main(int argc, char *argv[])
atom_type = BE_32(&moov_atom[i]); atom_type = BE_32(&moov_atom[i]);
if (atom_type == STCO_ATOM) { if (atom_type == STCO_ATOM) {
printf(" patching stco atom...\n"); printf(" patching stco atom...\n");
atom_size = BE_32(&moov_atom[i - 4]); atom_size = (uint32_t)BE_32(&moov_atom[i - 4]);
if (i + atom_size - 4 > moov_atom_size) { if (i + atom_size - 4 > moov_atom_size) {
printf(" bad atom size\n"); printf(" bad atom size\n");
goto error_out; goto error_out;
@ -250,7 +250,7 @@ int main(int argc, char *argv[])
i += atom_size - 4; i += atom_size - 4;
} else if (atom_type == CO64_ATOM) { } else if (atom_type == CO64_ATOM) {
printf(" patching co64 atom...\n"); printf(" patching co64 atom...\n");
atom_size = BE_32(&moov_atom[i - 4]); atom_size = (uint32_t)BE_32(&moov_atom[i - 4]);
if (i + atom_size - 4 > moov_atom_size) { if (i + atom_size - 4 > moov_atom_size) {
printf(" bad atom size\n"); printf(" bad atom size\n");
goto error_out; goto error_out;

Write Preview
Loading…
Cancel
Save