From 60e46128f720892834804b20f469136f86d6094f Mon Sep 17 00:00:00 2001 From: Michael Niedermayer Date: Mon, 7 Aug 2023 02:33:24 +0200 Subject: [PATCH] avcodec/wavarc: Check that nb_samples is not negative It is currently probably not possible for it to be negative as the needed 2Mb input buf size is not achievable. But it is more robust to check for it too. If it would become negative than code like s->samples[0][n] = s->samples[0][s->nb_samples + n]; would crash Signed-off-by: Michael Niedermayer (cherry picked from commit 5f5a1ccd04acc74e31e1e4fe7e297b3f589425b3) Signed-off-by: Michael Niedermayer --- libavcodec/wavarc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/wavarc.c b/libavcodec/wavarc.c index 5fb7dae172..09784a016d 100644 --- a/libavcodec/wavarc.c +++ b/libavcodec/wavarc.c @@ -298,7 +298,7 @@ static int decode_2slp(AVCodecContext *avctx, return AVERROR_EOF; case 8: s->nb_samples = get_urice(gb, 8); - if (s->nb_samples > 570) { + if (s->nb_samples > 570U) { s->nb_samples = 570; return AVERROR_INVALIDDATA; }